From 6505fa1c845c34d59c44a40f87b66ef79f3e911c Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Tue, 14 Aug 2018 09:45:44 -0400 Subject: Fixes for checkstyle issues More fixes for spacing, adding comments, adding period at the end, and move code closer to usage. Issue-ID: POLICY-881 Change-Id: Ife99eaf627a221e87d65d24dfd145b0ee4e06d21 Signed-off-by: Pamela Dragosh --- .../src/test/java/org/onap/policy/common/im/AllSeemsWellTest.java | 1 + .../test/java/org/onap/policy/common/im/IntegrityMonitorTest.java | 5 +++-- .../java/org/onap/policy/common/im/IntegrityMonitorTestBase.java | 7 ++++++- .../src/test/java/org/onap/policy/common/im/MonitorTimeTest.java | 6 ++++-- 4 files changed, 14 insertions(+), 5 deletions(-) (limited to 'integrity-monitor/src/test/java') diff --git a/integrity-monitor/src/test/java/org/onap/policy/common/im/AllSeemsWellTest.java b/integrity-monitor/src/test/java/org/onap/policy/common/im/AllSeemsWellTest.java index 8aec2f0b..fe408931 100644 --- a/integrity-monitor/src/test/java/org/onap/policy/common/im/AllSeemsWellTest.java +++ b/integrity-monitor/src/test/java/org/onap/policy/common/im/AllSeemsWellTest.java @@ -22,6 +22,7 @@ package org.onap.policy.common.im; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; + import java.util.Map; import java.util.Properties; import java.util.concurrent.Semaphore; diff --git a/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTest.java b/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTest.java index f7ffa217..3c4fba23 100644 --- a/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTest.java +++ b/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTest.java @@ -23,6 +23,7 @@ package org.onap.policy.common.im; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.fail; + import java.util.Date; import java.util.List; import java.util.Properties; @@ -645,8 +646,6 @@ public class IntegrityMonitorTest extends IntegrityMonitorTestBase { myProp.put(IntegrityMonitorProperties.MAX_FPC_UPDATE_INTERVAL, "5"); myProp.put(IntegrityMonitorProperties.CHECK_DEPENDENCY_INTERVAL, "5"); - IntegrityMonitor im = makeMonitor(resourceName, myProp); - // Note: do ***NOT*** do waitStep() here // Add a group1 dependent resources to put an entry in the forward @@ -663,6 +662,8 @@ public class IntegrityMonitorTest extends IntegrityMonitorTestBase { new StateManagement(emf, "group1_dep1"); + IntegrityMonitor im = makeMonitor(resourceName, myProp); + assertNoException(im, imx -> { imx.evaluateSanity(); }); diff --git a/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTestBase.java b/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTestBase.java index adde768e..ba1fc344 100644 --- a/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTestBase.java +++ b/integrity-monitor/src/test/java/org/onap/policy/common/im/IntegrityMonitorTestBase.java @@ -22,6 +22,7 @@ package org.onap.policy.common.im; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; + import java.io.FileOutputStream; import java.io.IOException; import java.util.Properties; @@ -233,6 +234,8 @@ public class IntegrityMonitorTestBase { } /** + * Get saved factory. + * * @return the original integrity monitor factory */ static Factory getSavedFactory() { @@ -252,6 +255,8 @@ public class IntegrityMonitorTestBase { } /** + * Get current test time. + * * @return the "current" time, in milliseconds */ protected static long getCurrentTestTime() { @@ -272,7 +277,7 @@ public class IntegrityMonitorTestBase { /** * Waits for a semaphore to be acquired. * - * @param sem + * @param sem semaphore to wait on * @throws InterruptedException if the thread is interrupted * @throws AssertionError if the semaphore was not acquired within the allotted time */ diff --git a/integrity-monitor/src/test/java/org/onap/policy/common/im/MonitorTimeTest.java b/integrity-monitor/src/test/java/org/onap/policy/common/im/MonitorTimeTest.java index 5f20a831..69d2f851 100644 --- a/integrity-monitor/src/test/java/org/onap/policy/common/im/MonitorTimeTest.java +++ b/integrity-monitor/src/test/java/org/onap/policy/common/im/MonitorTimeTest.java @@ -20,12 +20,14 @@ package org.onap.policy.common.im; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; + import org.junit.Test; import org.onap.policy.common.utils.time.CurrentTime; /** - * + * Class that tests MonitorTime. */ public class MonitorTimeTest { -- cgit 1.2.3-korg