From b52c7f21f7defaeaf86ff3921fe7bc18670ce2c1 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Mon, 24 Jun 2019 08:41:18 -0400 Subject: Fix more sonar issues in Integrity Audit & Monitor Removed duplicate code in DbDao by refactoring common code into a new updateIae() method. Removed duplicate code in IntegrityMonitor by refactoring common code into a new withinTransaction() method. Removed duplicate code in StateManagementEntity, StateElement by replacing with lombok Getter & Setter annotations. Removed duplicate code in StateManagement by refactoring common code into new setState() and getState() methods. Also removed logger.isDebugEnabled() tests. Added coverage for StateChangeNotifier. Change-Id: I2e29b836dafc5de569a2267206a6a34105e44021 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn --- .../policy/common/im/StateChangeNotifierTest.java | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 integrity-monitor/src/test/java/org/onap/policy/common/im/StateChangeNotifierTest.java (limited to 'integrity-monitor/src/test/java/org/onap/policy/common/im/StateChangeNotifierTest.java') diff --git a/integrity-monitor/src/test/java/org/onap/policy/common/im/StateChangeNotifierTest.java b/integrity-monitor/src/test/java/org/onap/policy/common/im/StateChangeNotifierTest.java new file mode 100644 index 00000000..46207804 --- /dev/null +++ b/integrity-monitor/src/test/java/org/onap/policy/common/im/StateChangeNotifierTest.java @@ -0,0 +1,48 @@ +/* + * ============LICENSE_START======================================================= + * ONAP + * ================================================================================ + * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.common.im; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertSame; +import static org.mockito.Mockito.mock; + +import org.junit.Test; + +public class StateChangeNotifierTest { + private static final String MESSAGE = "my message"; + + private StateChangeNotifier scn; + private StateManagement sm; + + @Test + public void test() { + sm = mock(StateManagement.class); + scn = new StateChangeNotifier(); + + scn.update(sm, MESSAGE); + + scn.handleStateChange(); + + assertSame(sm, scn.getStateManagement()); + assertEquals(MESSAGE, scn.getMessage()); + } + +} -- cgit 1.2.3-korg