From 65dff31a2e34b14347f1c0311420463c367afd3d Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Tue, 12 Sep 2017 10:28:35 -0400 Subject: Fix sonar critical associated with logging Addressing the following sonar critical: Use a logger to log this exception Either log or rethrow this exception It does not hurt to simply do these as well as clean out lines of code that dump to Sys.out via e.printStackTrace. Issue-ID: POLICY-195 Change-Id: Ibc328094a0653b7baa04778298e4a69955105ea3 Signed-off-by: Pamela Dragosh --- .../java/org/onap/policy/common/im/jmx/JmxAgentConnection.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/JmxAgentConnection.java') diff --git a/integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/JmxAgentConnection.java b/integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/JmxAgentConnection.java index 9b9bc48c..091f2d57 100644 --- a/integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/JmxAgentConnection.java +++ b/integrity-monitor/src/main/java/org/onap/policy/common/im/jmx/JmxAgentConnection.java @@ -26,6 +26,7 @@ package org.onap.policy.common.im.jmx; import java.io.IOException; import java.util.HashMap; import java.util.Map; + import javax.management.MBeanServerConnection; import javax.management.Notification; import javax.management.NotificationListener; @@ -34,10 +35,16 @@ import javax.management.remote.JMXConnector; import javax.management.remote.JMXConnectorFactory; import javax.management.remote.JMXServiceURL; +import org.onap.policy.common.logging.flexlogger.FlexLogger; +import org.onap.policy.common.logging.flexlogger.Logger; + /** * Class to create a JMX RMI connection to the JmxAgent. */ public final class JmxAgentConnection { + + private static final Logger logger = FlexLogger.getLogger(JmxAgentConnection.class); + private static final String DEFAULT_HOST = "localhost"; private static final String DEFAULT_PORT = "9996"; @@ -117,7 +124,7 @@ public final class JmxAgentConnection { */ public void disconnect() { if (connector != null) { - try { connector.close(); } catch (IOException e) { } + try { connector.close(); } catch (IOException e) { logger.debug(e); } } } } -- cgit 1.2.3-korg