From 0af104298947b796ebd511dcabd17209bf452a06 Mon Sep 17 00:00:00 2001
From: Jim Hahn <jrh3@att.com>
Date: Thu, 7 Mar 2019 19:51:59 -0500
Subject: Create ParameterGroupImpl

Classes that implement ParameterGroup all have to add their own
name and validate() fields and methods.  Added an "impl" class that
provides the standard functionality and modified subclasses to use
it.

Change-Id: Ic6ee1607fb4fe7164a4e1eeebc480ea7d1e7e4d7
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
---
 .../parameters/testclasses/TestParametersLGeneric.java | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

(limited to 'common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java')

diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java
index 1e5764c6..2fc04180 100644
--- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java
+++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java
@@ -22,13 +22,12 @@
 package org.onap.policy.common.parameters.testclasses;
 
 import org.onap.policy.common.parameters.GroupValidationResult;
-import org.onap.policy.common.parameters.ParameterGroup;
+import org.onap.policy.common.parameters.ParameterGroupImpl;
 import org.onap.policy.common.parameters.ValidationStatus;
 import org.onap.policy.common.parameters.annotations.NotBlank;
 import org.onap.policy.common.parameters.annotations.NotNull;
 
-public class TestParametersLGeneric implements ParameterGroup {
-    private String name;
+public class TestParametersLGeneric extends ParameterGroupImpl {
     private int lgenericIntField = 0;
 
     @NotNull @NotBlank
@@ -47,7 +46,7 @@ public class TestParametersLGeneric implements ParameterGroup {
      * @param name the parameter group name
      */
     public TestParametersLGeneric(final String name) {
-        this.name = name;
+        super(name);
     }
 
     public int getLgenericIntField() {
@@ -58,10 +57,6 @@ public class TestParametersLGeneric implements ParameterGroup {
         return lgenericStringField;
     }
 
-    public void setName(String name) {
-        this.name = name;
-    }
-
     public void setLgenericIntField(int lgenericIntField) {
         this.lgenericIntField = lgenericIntField;
     }
@@ -106,14 +101,9 @@ public class TestParametersLGeneric implements ParameterGroup {
 
     }
 
-    @Override
-    public String getName() {
-        return this.name;
-    }
-
     @Override
     public GroupValidationResult validate() {
-        GroupValidationResult validationResult = new GroupValidationResult(this);
+        GroupValidationResult validationResult = super.validate();
 
         if ("lgenericStringField".equals(lgenericStringField)) {
             validationResult.setResult("lgenericStringField", ValidationStatus.WARNING,
-- 
cgit 1.2.3-korg