From ae2b3da4f94f0ba59708042912c941732243496f Mon Sep 17 00:00:00 2001 From: "Magnusen, Drew (dm741q)" Date: Tue, 25 Jul 2017 12:25:52 -0500 Subject: [POLICY-81] Code cleanup to eliminate the presence of warning messages in Eclipse. Change-Id: Id98fdf0241487d56707ac91cde47975c91225f3c Signed-off-by: Magnusen, Drew (dm741q) --- .../openecomp/policy/common/logging/ECOMPLoggingContext.java | 8 -------- .../openecomp/policy/common/logging/eelf/ErrorCodeMap.java | 3 +-- .../org/openecomp/policy/common/logging/eelf/EventData.java | 2 -- .../openecomp/policy/common/logging/eelf/EventTrackInfo.java | 6 ------ .../policy/common/logging/eelf/EventTrackInfoHandler.java | 2 -- .../policy/common/logging/flexlogger/EelfLogger.java | 12 ++++++++---- .../openecomp/policy/common/logging/flexlogger/Logger4J.java | 6 +++++- .../policy/common/logging/flexlogger/SystemOutLogger.java | 6 +++++- 8 files changed, 19 insertions(+), 26 deletions(-) (limited to 'common-logging') diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/ECOMPLoggingContext.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/ECOMPLoggingContext.java index e6e2b1ca..606e872d 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/ECOMPLoggingContext.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/ECOMPLoggingContext.java @@ -24,18 +24,10 @@ package org.openecomp.policy.common.logging; //import static org.openecomp.policy.common.logging.eelf.Configuration.TRANSACTION_ELAPSED_TIME; //import static org.openecomp.policy.common.logging.eelf.Configuration.TRANSACTION_END_TIME_STAMP; -import static com.att.eelf.configuration.Configuration.MDC_ALERT_SEVERITY; -import static com.att.eelf.configuration.Configuration.MDC_INSTANCE_UUID; - import java.text.SimpleDateFormat; import java.time.Duration; import java.time.Instant; -import java.time.ZoneOffset; import java.util.Date; -import java.util.Properties; -import java.util.Timer; -import java.util.TimerTask; - import org.slf4j.MDC; import org.openecomp.policy.common.logging.nsa.LoggingContextFactory; diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/ErrorCodeMap.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/ErrorCodeMap.java index 4e4457d0..abd972e1 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/ErrorCodeMap.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/ErrorCodeMap.java @@ -21,7 +21,6 @@ package org.openecomp.policy.common.logging.eelf; import java.util.HashMap; -import java.util.Map; /** * @@ -31,7 +30,7 @@ import java.util.Map; public class ErrorCodeMap { - public static HashMap hm = new HashMap(); + public static HashMap hm = new HashMap(); private static String ERROR_PERMISSIONS = "POLICY-100E"; private static String ERROR_PERMISSIONS_DESCRIPTION = "This is a Permissions Error. Please check the error message for detail information"; diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventData.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventData.java index eb0bffc7..d26a4977 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventData.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventData.java @@ -22,8 +22,6 @@ package org.openecomp.policy.common.logging.eelf; import java.time.Instant; -import javax.swing.text.html.parser.Entity; - /** * * EventData can be used for logging a rule event. diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfo.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfo.java index c6ed63d4..f1b7afb5 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfo.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfo.java @@ -20,14 +20,8 @@ package org.openecomp.policy.common.logging.eelf; -import java.io.IOException; -import java.time.Instant; -import java.util.Properties; -import java.util.UUID; import java.util.concurrent.ConcurrentHashMap; -import org.openecomp.policy.common.logging.flexlogger.PropertyUtil; - /** * * EventTrackInfo contains a ConcurrentHashMap of EventData diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfoHandler.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfoHandler.java index a947ed01..e45f8998 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfoHandler.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/eelf/EventTrackInfoHandler.java @@ -23,8 +23,6 @@ package org.openecomp.policy.common.logging.eelf; import java.time.Duration; import java.time.Instant; import java.util.ArrayList; -import java.util.Iterator; -import java.util.Timer; import java.util.TimerTask; /** diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/EelfLogger.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/EelfLogger.java index 31c17554..106c734c 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/EelfLogger.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/EelfLogger.java @@ -36,14 +36,18 @@ import com.att.eelf.configuration.EELFLogger.Level; public class EelfLogger implements Logger, Serializable { - private String className = ""; + /** + * + */ + private static final long serialVersionUID = 5385586713941277192L; + private String className = ""; private String transId = UUID.randomUUID().toString(); /** * Constructor * @param clazz */ - public EelfLogger(Class clazz) { + public EelfLogger(Class clazz) { if(clazz != null){ className = clazz.getName(); } @@ -66,7 +70,7 @@ public class EelfLogger implements Logger, Serializable { * @param clazz * @param isNewTransaction */ - public EelfLogger(Class clazz, boolean isNewTransaction) { + public EelfLogger(Class clazz, boolean isNewTransaction) { if(clazz != null){ className = clazz.getName(); } @@ -98,7 +102,7 @@ public class EelfLogger implements Logger, Serializable { * @param clazz * @param transId */ - public EelfLogger(Class clazz, String transId) { + public EelfLogger(Class clazz, String transId) { if(clazz != null){ className = clazz.getName(); } diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/Logger4J.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/Logger4J.java index 23cafb41..506e1ea7 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/Logger4J.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/Logger4J.java @@ -40,6 +40,10 @@ import com.att.eelf.configuration.EELFLogger.Level; */ public class Logger4J implements org.openecomp.policy.common.logging.flexlogger.Logger, Serializable { + /** + * + */ + private static final long serialVersionUID = 3183729429888828471L; private Logger log = null; private String methodName = ""; private String className = ""; @@ -49,7 +53,7 @@ public class Logger4J implements org.openecomp.policy.common.logging.flexlogger. * Constructor * @param clazz */ - public Logger4J (Class clazz){ + public Logger4J (Class clazz){ System.out.println("create instance of Logger4J"); if(clazz != null){ log = Logger.getLogger(clazz); diff --git a/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/SystemOutLogger.java b/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/SystemOutLogger.java index 91e16b97..596914a2 100644 --- a/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/SystemOutLogger.java +++ b/common-logging/src/main/java/org/openecomp/policy/common/logging/flexlogger/SystemOutLogger.java @@ -34,6 +34,10 @@ import com.att.eelf.configuration.EELFLogger.Level; */ public class SystemOutLogger implements Logger, Serializable { + /** + * + */ + private static final long serialVersionUID = 4956408061058933929L; private String className = ""; private boolean isDebugEnabled = true; private boolean isInfoEnabled = true; @@ -47,7 +51,7 @@ public class SystemOutLogger implements Logger, Serializable { * Constructor * @param clazz */ - public SystemOutLogger (Class clazz){ + public SystemOutLogger (Class clazz){ System.out.println("create instance of SystemOutLogger"); if(clazz != null){ className = clazz.getName(); -- cgit 1.2.3-korg