From 5492c1dd9d7052781ae5cab28bf5bcc829ae9c9e Mon Sep 17 00:00:00 2001 From: mmis Date: Fri, 16 Mar 2018 14:42:22 +0000 Subject: Removed checkstyle warnings Removed checkstyle warnings in policy/common/logging Some warnings remain that required renaming of classes and public methods. These will be taken separately Issue-ID: POLICY-695 Change-Id: Id604c66708917de390c556b50f6266f929b09134 Signed-off-by: mmis --- .../policy/common/logging/eelf/MessageCodes.java | 228 +++++++++++---------- 1 file changed, 115 insertions(+), 113 deletions(-) (limited to 'common-logging/src/main/java/org/onap/policy/common/logging/eelf/MessageCodes.java') diff --git a/common-logging/src/main/java/org/onap/policy/common/logging/eelf/MessageCodes.java b/common-logging/src/main/java/org/onap/policy/common/logging/eelf/MessageCodes.java index 3bfce0b5..ab5712ff 100644 --- a/common-logging/src/main/java/org/onap/policy/common/logging/eelf/MessageCodes.java +++ b/common-logging/src/main/java/org/onap/policy/common/logging/eelf/MessageCodes.java @@ -2,7 +2,7 @@ * ============LICENSE_START======================================================= * ONAP-Logging * ================================================================================ - * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -24,140 +24,142 @@ import com.att.eelf.i18n.EELFResolvableErrorEnum; import com.att.eelf.i18n.EELFResourceManager; /** - * - * MessageCodes contains all the messagge codes for EELF logging messages - * + * MessageCodes contains all the messagge codes for EELF logging messages. */ public enum MessageCodes implements EELFResolvableErrorEnum { - // Below is a list of Error Messages taken from com.att.research.xacml.api XACMLErrorConstants - // found under: policy-engine\XACML\src\main\java\com\att\research\xacml\api\XACMLErrorConstants.java - - ERROR_PERMISSIONS, - - ERROR_SYSTEM_ERROR, - - ERROR_DATA_ISSUE, - - ERROR_SCHEMA_INVALID, - - ERROR_PROCESS_FLOW, - - ERROR_UNKNOWN, - - ERROR_AUDIT, - - // Above is a list of Error Messages taken from com.att.research.xacml.api XACMLErrorConstants - // found under: policy-engine\XACML\src\main\java\com\att\research\xacml\api\XACMLErrorConstants.java - - //----------------------5000-5099 Business/Flow Processing Related --------------------/ - - BAD_TYPE_WARNING, - - GENERAL_INFO, - - GENERAL_WARNING, - - MISS_PROPERTY_ERROR, - - EXCEPTION_ERROR, - - MISS_PROPERTY_INFO, - - RULE_AUDIT_EXEC_INFO, - - RULE_AUDIT_BEGIN_INFO, - - RULE_AUDIT_END_INFO, - - RULE_AUDIT_START_END_INFO, - - RULE_METRICS_INFO, - - UEB_AUDIT_EXEC_INFO, - - UEB_AUDIT_BEGIN_INFO, - - UEB_AUDIT_END_INFO, - - UPDATE_ERROR, - - GENERAL_ERROR, - - //----------------------New enums should be added above this line ------------------------------------------------------------------/ - - //--------------------- The enums below are old code. They should not be used since 1607 release and eventually will be removed -----/ - /** - * Application message which requires no arguments + // Below is a list of Error Messages taken from com.att.research.xacml.api XACMLErrorConstants + // found under: + // policy-engine\XACML\src\main\java\com\att\research\xacml\api\XACMLErrorConstants.java + + ERROR_PERMISSIONS, + + ERROR_SYSTEM_ERROR, + + ERROR_DATA_ISSUE, + + ERROR_SCHEMA_INVALID, + + ERROR_PROCESS_FLOW, + + ERROR_UNKNOWN, + + ERROR_AUDIT, + + // Above is a list of Error Messages taken from com.att.research.xacml.api XACMLErrorConstants + // found under: + // policy-engine\XACML\src\main\java\com\att\research\xacml\api\XACMLErrorConstants.java + + // ----------------------5000-5099 Business/Flow Processing Related --------------------/ + + BAD_TYPE_WARNING, + + GENERAL_INFO, + + GENERAL_WARNING, + + MISS_PROPERTY_ERROR, + + EXCEPTION_ERROR, + + MISS_PROPERTY_INFO, + + RULE_AUDIT_EXEC_INFO, + + RULE_AUDIT_BEGIN_INFO, + + RULE_AUDIT_END_INFO, + + RULE_AUDIT_START_END_INFO, + + RULE_METRICS_INFO, + + UEB_AUDIT_EXEC_INFO, + + UEB_AUDIT_BEGIN_INFO, + + UEB_AUDIT_END_INFO, + + UPDATE_ERROR, + + GENERAL_ERROR, + + // ----------------------New enums should be added above this line + // ------------------------------------------------------------------/ + + // --------------------- The enums below are old code. They should not be used since 1607 + // release and eventually will be removed -----/ + /** + * Application message which requires no arguments. */ - MESSAGE_SAMPLE_NOARGS, - - /** - * Application message which requires one argument {0} + MESSAGE_SAMPLE_NOARGS, + + /** + * Application message which requires one argument {0}. */ - MESSAGE_SAMPLE_ONEARGUMENT, - - /** - * Audit message which requires one argument {0} - */ - AUDIT_MESSAGE_ONEARGUMENT, - - /** - * Error message which requires one argument {0} + MESSAGE_SAMPLE_ONEARGUMENT, + + /** + * Audit message which requires one argument {0}. */ - ERROR_MESSAGE_ONEARGUMENT, - - /** - * Metrics message which requires one argument {0} + AUDIT_MESSAGE_ONEARGUMENT, + + /** + * Error message which requires one argument {0}. */ - METRICS_MESSAGE_ONEARGUMENT, - - /** - * Debug message which requires one argument {0} + ERROR_MESSAGE_ONEARGUMENT, + + /** + * Metrics message which requires one argument {0}. */ - DEBUG_MESSAGE_ONEARGUMENT, - + METRICS_MESSAGE_ONEARGUMENT, + /** - * Application message which requires two argument {0} and another argument {1} + * Debug message which requires one argument {0}. */ - MESSAGE_SAMPLE_TWOARGUMENTS, - - /** - * Sample error exception + DEBUG_MESSAGE_ONEARGUMENT, + + /** + * Application message which requires two argument {0} and another argument {1}. + */ + MESSAGE_SAMPLE_TWOARGUMENTS, + + /** + * Sample error exception. */ MESSAGE_SAMPLE_EXCEPTION, - - /** - * Sample warning message + + /** + * Sample warning message. */ - MESSAGE_WARNING_SAMPLE, - - /** - * Sample exception in method {0} + MESSAGE_WARNING_SAMPLE, + + /** + * Sample exception in method {0}. */ - MESSAGE_SAMPLE_EXCEPTION_ONEARGUMENT, - - /** - * Sample trace message + MESSAGE_SAMPLE_EXCEPTION_ONEARGUMENT, + + /** + * Sample trace message. */ - MESSAGE_TRACE_SAMPLE, - - /** - * Sample error message + MESSAGE_TRACE_SAMPLE, + + /** + * Sample error message. */ - MESSAGE_ERROR_SAMPLE; - - + MESSAGE_ERROR_SAMPLE; + + /** - * Static initializer to ensure the resource bundles for this class are loaded... - * Here this application loads messages from three bundles + * Static initializer to ensure the resource bundles for this class are loaded... Here this + * application loads messages from three bundles. */ static { EELFResourceManager.loadMessageBundle("org/onap/policy/common/logging/eelf/Resources"); String id = EELFResourceManager.getIdentifier(RULE_AUDIT_EXEC_INFO); String value = EELFResourceManager.getMessage(RULE_AUDIT_EXEC_INFO); - + PolicyLogger.info("*********************** Rule audit id: " + id); PolicyLogger.info("*********************** Rule audit value: " + value); - + } } -- cgit 1.2.3-korg