From 5492c1dd9d7052781ae5cab28bf5bcc829ae9c9e Mon Sep 17 00:00:00 2001
From: mmis <michael.morris@ericsson.com>
Date: Fri, 16 Mar 2018 14:42:22 +0000
Subject: Removed checkstyle warnings

Removed checkstyle warnings in policy/common/logging

Some warnings remain that required renaming of classes and public methods.
These will be taken separately

Issue-ID: POLICY-695
Change-Id: Id604c66708917de390c556b50f6266f929b09134
Signed-off-by: mmis <michael.morris@ericsson.com>
---
 .../onap/policy/common/logging/eelf/EventData.java | 47 ++++++++++++----------
 1 file changed, 26 insertions(+), 21 deletions(-)

(limited to 'common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventData.java')

diff --git a/common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventData.java b/common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventData.java
index 037a144d..a8d90ad7 100644
--- a/common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventData.java
+++ b/common-logging/src/main/java/org/onap/policy/common/logging/eelf/EventData.java
@@ -2,7 +2,7 @@
  * ============LICENSE_START=======================================================
  * ONAP-Logging
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,35 +23,40 @@ package org.onap.policy.common.logging.eelf;
 import java.time.Instant;
 
 /**
- *
  * EventData can be used for logging a rule event.
- *
  */
 public class EventData {
 
-    private String requestID = null;
+    private String requestId = null;
     private Instant startTime = null;
     private Instant endTime = null;
 
-    //Default constructor takes no arguments.
-    //Is empty because instance variables are assigned
-    //their default values upon declaration.
-    public EventData() { 
-        //See above comments for the reason this constructor is empty
+    // Default constructor takes no arguments.
+    // Is empty because instance variables are assigned
+    // their default values upon declaration.
+    public EventData() {
+        // See above comments for the reason this constructor is empty
     }
 
-    public EventData(String requestID, Instant startTime, Instant endTime) {
-        this.requestID = requestID;
+    /**
+     * Create an instance.
+     * 
+     * @param requestId the request ID
+     * @param startTime the start time
+     * @param endTime the end time
+     */
+    public EventData(String requestId, Instant startTime, Instant endTime) {
+        this.requestId = requestId;
         this.startTime = startTime;
         this.endTime = endTime;
     }
 
     public String getRequestID() {
-        return requestID;
+        return requestId;
     }
 
-    public void setRequestID(String requestID) {
-        this.requestID = requestID;
+    public void setRequestID(String requestId) {
+        this.requestId = requestId;
     }
 
     public Instant getStartTime() {
@@ -72,14 +77,14 @@ public class EventData {
 
     @Override
     public String toString() {
-        return requestID + " Starting Time : " + this.startTime + " Ending Time : " + this.endTime;
+        return requestId + " Starting Time : " + this.startTime + " Ending Time : " + this.endTime;
     }
 
     @Override
     public int hashCode() {
         final int prime = 31;
         int result = 1;
-        result = prime * result + ((requestID == null) ? 0 : requestID.hashCode());
+        result = prime * result + ((requestId == null) ? 0 : requestId.hashCode());
         return result;
     }
 
@@ -92,18 +97,18 @@ public class EventData {
             return false;
         }
         if (obj instanceof String) {
-            String requestId = (String) obj;
-            return requestID != null && requestID.equals(requestId);
+            String otherRequestId = (String) obj;
+            return requestId != null && requestId.equals(otherRequestId);
         }
         if (getClass() != obj.getClass()) {
             return false;
         }
         EventData other = (EventData) obj;
-        if (requestID == null) {
-            if (other.requestID != null) {
+        if (requestId == null) {
+            if (other.requestId != null) {
                 return false;
             }
-        } else if (!requestID.equals(other.requestID)) {
+        } else if (!requestId.equals(other.requestId)) {
             return false;
         }
         return true;
-- 
cgit 1.2.3-korg