From e9b5f957f3c27c0a225d7b8fa16a220c5c98c746 Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Thu, 14 Sep 2017 11:25:42 -0400 Subject: Logging exceptions to clear sonar critical Just logging the exceptions anyway and remove e.printstack since that goes to stdout/stderr. Issue-ID: POLICY-195 Change-Id: I60616bd6ce633e2fcae266bb37eb735c6e6bb4c4 Signed-off-by: Pamela Dragosh --- .../src/main/java/org/onap/policy/common/ia/DbDAO.java | 10 +--------- .../main/java/org/onap/policy/common/im/IntegrityMonitor.java | 3 ++- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/integrity-audit/src/main/java/org/onap/policy/common/ia/DbDAO.java b/integrity-audit/src/main/java/org/onap/policy/common/ia/DbDAO.java index b392b555..e1412094 100644 --- a/integrity-audit/src/main/java/org/onap/policy/common/ia/DbDAO.java +++ b/integrity-audit/src/main/java/org/onap/policy/common/ia/DbDAO.java @@ -237,9 +237,7 @@ public class DbDAO { } }catch(Exception e){ String msg = "getAllEntries encountered exception: " + e; - logger.error(msg); - System.out.println(new Date()); - e.printStackTrace(); + logger.error(msg, e); } em.close(); logger.debug("getAllEntries: Exit, resultMap, size=" + resultMap.size()); @@ -331,8 +329,6 @@ public class DbDAO { }catch (Exception e){ String msg = "DbDAO: " + "setLastUpdated() " + "ecountered a problem in execution: "; logger.error(msg + e); - System.out.println(new Date()); - e.printStackTrace(); throw new DbDaoTransactionException(e); } } @@ -362,8 +358,6 @@ public class DbDAO { }catch (Exception e){ String msg = "DbDAO: " + "getIntegrityAuditEntity() " + "ecountered a problem in execution: "; logger.error(msg + e); - System.out.println(new Date()); - e.printStackTrace(); throw new DbDaoTransactionException(e); } } @@ -711,8 +705,6 @@ public class DbDAO { String msg = "DbDAO: " + "changeDesignated() " + "caught Exception, message=" + e.getMessage(); logger.error(msg + e); - System.out.println(new Date()); - e.printStackTrace(); throw new DbDaoTransactionException(msg, e); } else { diff --git a/integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java b/integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java index fef4b897..9d437938 100644 --- a/integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java +++ b/integrity-monitor/src/main/java/org/onap/policy/common/im/IntegrityMonitor.java @@ -348,7 +348,7 @@ public class IntegrityMonitor { try { new ComponentAdmin(resourceName, this, stateManager); } catch (Exception e) { - logger.error("ComponentAdmin constructor exception: " + e.toString()); + logger.error("ComponentAdmin constructor exception: " + e); } new FPManager(); @@ -906,6 +906,7 @@ public class IntegrityMonitor { //Test any subsystems that are not covered under the dependency relationship subsystemTest(); }catch (Exception e){ + logger.error(e); //This indicates a subsystemTest failure try { logger.info(resourceName + ": There has been a subsystemTest failure with error: " + e.getMessage() + " Updating this resource's state to disableDependency"); -- cgit 1.2.3-korg