aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-07-09Release policy/common 1.7.0Ram Krishna Verma1-0/+4
Issue-ID: POLICY-2695 Change-Id: I3605de083efbaeae276a09da409ce44c982bc173 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-09Refer to released parent in policy/commonRam Krishna Verma1-1/+1
Issue-ID: POLICY-2695 Change-Id: Ife7a14cbc1197dd45281f1e846a906310496bf3a Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-02Merge "Removing hamcrest and openpojo from utils pom"Jorge Hernandez1-10/+0
2020-07-02Removing hamcrest and openpojo from utils pomRossC1-10/+0
Issue-ID: POLICY-2387 Change-Id: I43916ce97c43892fed4ed3a78f972f6b97e3237f Signed-off-by: RossC <ross.carter@est.tech>
2020-07-02Merge "Updating common dependencies"Jorge Hernandez4-6/+6
2020-07-01Updating common dependenciesRossC5-7/+6
Issue-ID: POLICY-2387 Change-Id: Ib2b14f66f6416ca3b8d6353bb6aa19fa2f41ebbb Signed-off-by: RossC <ross.carter@est.tech>
2020-07-01Fix build breakage in policy-commonJim Hahn4-8/+16
When the commit for https://gerrit.onap.org/r/c/policy/parent/+/109705 was applied, it broke the changes to common to fix new sonar issues. Backed out some of those changes. Issue-ID: POLICY-2650 Change-Id: Id498392ff798e49c281296575223298c0b6e5143 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-30Fix sonars in common due to dependency upgradesJim Hahn5-16/+8
Fixed the following issues: - don't use annotation wrappers - version overridden in pom Issue-ID: POLICY-2650 Change-Id: Ia520037529861f8ace160c172ed70a5671b740d9 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-30Fix sonar about always-trust-managerJim Hahn2-25/+7
This trust manager is not secure and should be avoided. However, it is only used when the configuration explicitly says to allow self-signed certificates. Modified the code to use an apache trust manager, thus avoid the sonar complaint. Issue-ID: POLICY-2650 Change-Id: Iaf4c72689916ed5ed5e6864666f3f54b2c5e0f12 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-29Fix new logger sonars in policy-commonJim Hahn3-24/+24
Not sure if this was introduced with the new logger version, but now seeing a number of new sonars about using "{}". Fixed those. Issue-ID: POLICY-2650 Change-Id: If36b2e89aa9151700bb9cea2906b6afaad5c4c72 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-29Merge "upgrade eelf-core dependency: 1.0.0 -> 2.0.0-oss"Ram Krishna Verma4-8/+18
2020-06-29Fix issues in common for new sonar rulesJim Hahn12-51/+67
Addressed issues reported due to updates to the sonar rules: - invoke only one method in a junit lambda - complete the assertion - add DOCTYPE to html Issue-ID: POLICY-2650 Change-Id: Ib8b8a2e4736cc23849c0f7aef972ffa3365a3e00 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-29upgrade eelf-core dependency: 1.0.0 -> 2.0.0-ossjhh4-8/+18
Issue-ID: POLICY-2387 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I837c2e958a388e8b6f2df2aff9f995359e44ad62
2020-06-25Merge "Fix deprecated method in policy-common"Pamela Dragosh1-2/+3
2020-06-25Fix Junit failed after AAF version change 2.1.21Utkarsh Jauhari1-0/+7
Issue-ID: POLICY-2623 Signed-off-by: Utkarsh Jauhari <uj426b@att.com> Change-Id: I86c5b6efac8f62dd0d4ba576d8ec49cfa63a58bb
2020-06-24Fix deprecated method in policy-commonJim Hahn1-2/+3
Probably due to a jar update, some methods are now deprecated. Fixed them. Issue-ID: POLICY-2650 Change-Id: I48aabd4552faaf88671dfbe6556dc739a8c94809 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-19Merge "More sonar issues in policy-common"Pamela Dragosh3-23/+31
2020-06-18More sonar issues in policy-commonJim Hahn3-23/+31
Addressed the following sonar issues: - add parameters to types - ObjectInputStream.readObject() is unsafe Issue-ID: POLICY-2650 Change-Id: I41e1bd08643b04f409ce87c884cb0c28995e431b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-18Changes for checkstyle 8.32liamfallon22-82/+42
Issue-ID: POLICY-2188 Change-Id: I00843c61a6567001fc35c3ebb77b6843a1eb7da2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-06-17Cleanup various sonar issues in policy-commonJim Hahn60-299/+237
Addressed the following issues: - unused imports - unused method parameters - use assertEquals, assertSame instead of assertTrue - provide the parametrized type for this generic Also fixed some checkstyle issues: - removed blank lines between "import" groups Issue-ID: POLICY-2650 Change-Id: I004bb650ac10c49ccd0fc405f6959896fec39f9b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-12Merge "Remove logback.xml files bundled as part of jar"Ram Krishna Verma3-777/+0
2020-06-12Remove logback.xml files bundled as part of jara.sreekumar3-777/+0
Change-Id: Ia98493a3ec6ad91a46c88ab71998eb039da44842 Issue-ID: POLICY-2627 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-06-11Removing log4j from policy/commonuj426b9-1052/+5
Change-Id: Ib662556533f72c99180b611d0a1933f20e231b2c Issue-ID: POLICY-2623 Signed-off-by: uj426b <uj426b@att.com>
2020-06-02Code changes for dmaap-client upgradeJim Hahn1-4/+11
Issue-ID: POLICY-1996 Change-Id: Id8a3acf9406c6acada4c3ffee679f2baf819cded Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-28jetty-servlets now defined in oparentPamela Dragosh1-3/+0
latest oparent has this new dependency in it. Issue-ID: POLICY-2319 Change-Id: If3b9f64caa41923da1fabc6183434fc21ec00548 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-28Point to parent SNAPSHOTPamela Dragosh1-1/+1
So we can tackle security dependency upgrades Issue-ID: POLICY-2391 Change-Id: Iffbcc045d487045a982035e1f832f8eede59c919 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-27Make GSON the default serializerJim Hahn2-6/+8
The default serialization provider for HttpClient and HttpServletServer was Jackson. Modified to use GSON instead. Issue-ID: POLICY-1526 Change-Id: Ic6282d119fa63d12470903a4f1eb4da3afd6efe7 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-19Bump common master to 1.7.0Pamela Dragosh11-12/+12
Issue-ID: POLICY-2514 Change-Id: Ic7bcf44a9f0c887d6c99edb8609725a15c4aa9a7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-05Bump common to 1.6.6-SNAPSHOTPamela Dragosh11-11/+11
Issue-ID: POLICY-2514 Change-Id: Ied6a2571a0f1008eefa87b8aefdde12bd494a79b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-05Release common 1.6.5 java6.0.0-ONAPPamela Dragosh1-0/+4
Issue-ID: POLICY-2514 Change-Id: Idc7bb4791743c52a0ceaef4316d7c4c47271ec05 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-05Point to released parentPamela Dragosh1-1/+1
Issue-ID: POLICY-2514 Change-Id: I5de2239e78761d0e4433521054fa9e3cad5f5a99 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-28Merge "Logging enhancement work"Pamela Dragosh9-70/+507
2020-04-28Logging enhancement workJoseph Chou9-70/+507
Update log tool to provide placeholder feature Change-Id: I3f2b10d009a1d51f30a6080c07459eb0ac07189f Issue-ID: POLICY-2478 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-04-24Bump parent release version in commonJim Hahn1-1/+1
Issue-ID: POLICY-2521 Change-Id: I27ca8ba624ce91a249be175b61d50f7ace5256da Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-14Bump common to 1.6.5-SNAPSHOTRam Krishna Verma11-11/+11
Issue-ID: POLICY-2378 Change-Id: I0012a2cd7acbb9d634b1fc7226992b873142016a Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-14Release common 1.6.4Ram Krishna Verma1-0/+4
Issue-ID: POLICY-2378 Change-Id: Id54e49ffded160a4df3540ed6adf3961ba6b9def Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-13Fix handling of number fields YamlJim Hahn1-4/+16
This fix also impacts StandardCoder, allowing Map.class to be used as the target type instead of requiring LinkedHashMap.class. Note: still doesn't do any translation if Object.class is used, as there is no way to override GSON's handler for the Object type. Issue-ID: POLICY-2488 Change-Id: Ia7cd0c85dc5a2a9e93360fa1c8397531b8503f2d Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-10Bump common to 1.6.4-SNAPSHOTPamela Dragosh11-11/+11
Issue-ID: POLICY-2378 Change-Id: Ib3afcf81460f42e1a62d51a484184763d61dace6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-10Release common 1.6.3Pamela Dragosh1-0/+4
Issue-ID: POLICY-2378 Change-Id: I708035d5e1ba13150d51a7bf6317ce43b313419e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-10Merge "Update common-logging for log enhancement work"Pamela Dragosh5-59/+65
2020-04-10Update common-logging for log enhancement workJoseph Chou5-59/+65
Resolve missing error code, add marker/mdc for audit/metrics Change-Id: I490b17aac86f3b63df43e267a5dbe1d1588e5fdf Issue-ID: POLICY-2478 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-04-10Point to released parent 3.1.2Pamela Dragosh1-1/+1
Issue-ID: POLICY-2378 Change-Id: If1ac42ecc4465321d0392610bf0d1c94ccb22dd7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-09rename jpa persistence filejhh3-0/+6
After inspecting the fat jar generated by brmsgw, noticed that the persistence.xml included from here it was overriden by another one, therefore the persistence unit was not available. This may solve the issue for the brmsgw, as with a far jar build, there are the risks of collisions such as this of files with the same name. Issue-ID: POLICY-2471 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I91cf2b6d3d2f5086d77795e08800ca96d984c214
2020-04-07Update licenses on sonar fixes in commonJim Hahn11-11/+11
Forgot to update licenses on some of the files that were modified as part of addressing sonar issues. Updated. Issue-ID: POLICY-2305 Change-Id: I9858bfb54be5b8eb42406e944361ec100ae238ff Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Merge "More sonar issues in common"Jim Hahn3-16/+27
2020-04-06Address sonar issues in ONAP-loggingJim Hahn11-37/+43
Addressed the following sonar issues in ONAP-logging: - use Map instead of ConcurrentHashMap - remove unusued fields - use Map.computeIfAbsent() instead of get()/put() pair - readObject is unsafe - use try-with-resources - junit should assert something Also removed some unused imports. Issue-ID: POLICY-2305 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I3480a55da4d0e771f8083c97770a6c9707d871f7 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06More sonar issues in commonJim Hahn3-16/+27
Fixed additional sonar issues: - infinit loop; while the issue is bogus, it was easy enough to modify the code to satisfy sonar - doesn't like "volatile"; again, the issue is bogus, but easy enough to modify the code Disabled a couple of sonars in NetworkUtil, as they are not actually an issue. Issue-ID: POLICY-2305 Change-Id: I5500183e3fe4060696994cff55bdae4ba7e138c7 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Address sonar issues in commonJim Hahn48-394/+403
Addressed the following sonar issues: - missing assertion in junit test case - disable sonars about setAccessible() as it's required for jackson emulation - sleep in junit - don't use wild-cards (e.g., "*") with java.util Pattern - use re2j instead of java.util Pattern - use String methods (e.g., startsWith()) - duplicate method bodies - duplicate code in Coder classes - string concatenation in logger calls - UTF-8 encoding - return primitive instead of boxed primitive - add assertion to tests - renamed support methods from doTestXxx to verifyXxx - cognitive complexity - use AtomicRef instead of volatile - use specific Functionals (e.g., IntConsumer) - function always returns the same value - serializable vs transient Issue-ID: POLICY-2305 Change-Id: I08eb7aa495a80bdc1d26827ba17a7946c83b9828 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-27More sonar issues cleanupPamela Dragosh9-44/+30
Either log or rethrow Use boolean expression Add at least one test Remove commented out code Issue-ID: POLICY-2204 Change-Id: I4fdf31aea75303e4f49d25198eb3b12341995bfe Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-24Sonar and eclipse warnings commonPamela Dragosh8-143/+108
Unused imports Not enough arguments Issue-ID: POLICY-2204 Change-Id: I6405cb697ea976096b1276e2291b1c73617d33b5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>