Fix bug where paramsAreBad doesn't update string

Replaced the string parameter with a StringBuilder so that the modified
version can be accessed outside the method, since strings are immutable.
Added null check for properties. Removed trim on properties in case the
property is null. Added junit to test that the modified StringBuilder can
be read outside the paramsAreBad method.

Issue-ID: POLICY-492
Change-Id: I0550e9d639cbbcc876e6aafb84f6e9a363b653ff
Signed-off-by: Temoc Rodriguez <cr056n@att.com>

1 files changed, 65 insertions, 0 deletions

diff --git a/integrity-audit/src/test/java/org/onap/policy/common/ia/test/IntegrityAuditTest.java b/integrity-audit/src/test/java/org/onap/policy/common/ia/test/IntegrityAuditTest.java
new file mode 100644
index 00000000..5f19e2b9
--- /dev/null
+++ b/integrity-audit/src/test/java/org/onap/policy/common/ia/test/IntegrityAuditTest.java
@@ -0,0 +1,65 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * Integrity Audit
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.common.ia.test;
+
+import static org.junit.Assert.*;
+
+import java.util.Properties;
+
+import org.junit.Test;
+import org.onap.policy.common.ia.IntegrityAudit;
+import org.onap.policy.common.ia.IntegrityAuditProperties;
+
+public class IntegrityAuditTest {
+
+	@Test
+	/**
+	 * Test if we can access the updated bad params outside of the parmsAreBad method
+	 */
+	public void parmsAreBadTest() {
+		// Try with 2 null params
+		StringBuilder badParams = new StringBuilder();
+		IntegrityAudit.parmsAreBad(null, "something", null, badParams);
+		
+		assertFalse("".equals(badParams.toString()));
+		assertTrue(badParams.toString().contains("resourceName"));
+		assertTrue(badParams.toString().contains("properties"));
+		
+		// Try with 1 null params
+		badParams = new StringBuilder();
+		Properties props = new Properties();
+		props.put(IntegrityAuditProperties.DB_DRIVER, "test_db_driver");
+		IntegrityAudit.parmsAreBad(null, "something", props, badParams);
+		
+		assertFalse("".equals(badParams.toString()));
+		assertTrue(badParams.toString().contains("resourceName"));
+		assertFalse(badParams.toString().contains("properties"));
+		
+		// Try with 0 null params
+		badParams = new StringBuilder();
+		IntegrityAudit.parmsAreBad("someting", "something", props, badParams);
+		assertFalse("".equals(badParams.toString()));
+		assertFalse(badParams.toString().contains("resourceName"));
+		assertFalse(badParams.toString().contains("properties"));
+
+	}
+
+}