From 7b8d18c2d8893e735e2809609361071bb702b53f Mon Sep 17 00:00:00 2001 From: "k.kedron" Date: Thu, 18 Apr 2019 13:42:40 +0200 Subject: Fixed generic Sonar issue in the clamp project Fixed Sonar issue: - name convection for static field in AuthorizationController - optimize condition flow in AuthorizationController - remove not used import in BlueprintParserMappingConfiguration - remove not used field in AuthorizationController, SdcControllersConfiguration, CldsService - add private constructor to the AwtUtils - change redundant EnableAutoConfiguration annotation to SpringBootApplication annotation - remove duplications of code in the CldsDao Change-Id: I49d8be9ec44b5930f76bace0fc9d8cf61ee000f5 Issue-ID: CLAMP-346 Signed-off-by: Krystian Kedron --- .../org/onap/clamp/clds/it/AuthorizationControllerItCase.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/test/java') diff --git a/src/test/java/org/onap/clamp/clds/it/AuthorizationControllerItCase.java b/src/test/java/org/onap/clamp/clds/it/AuthorizationControllerItCase.java index a15c556ed..58d946857 100644 --- a/src/test/java/org/onap/clamp/clds/it/AuthorizationControllerItCase.java +++ b/src/test/java/org/onap/clamp/clds/it/AuthorizationControllerItCase.java @@ -87,9 +87,9 @@ public class AuthorizationControllerItCase { PrincipalUtils.setSecurityContext(securityContext); AuthorizationController auth = new AuthorizationController(); - assertTrue(auth.isUserPermittedNoException(new SecureServicePermission("permission-type-cl","dev","read"))); - assertTrue(auth.isUserPermittedNoException(new SecureServicePermission("permission-type-cl-manage","dev","DEPLOY"))); - assertTrue(auth.isUserPermittedNoException(new SecureServicePermission("permission-type-filter-vf","dev","12345-55555-55555-5555"))); - assertFalse(auth.isUserPermittedNoException(new SecureServicePermission("permission-type-cl","test","read"))); + assertTrue(auth.isUserPermitted(new SecureServicePermission("permission-type-cl","dev","read"))); + assertTrue(auth.isUserPermitted(new SecureServicePermission("permission-type-cl-manage","dev","DEPLOY"))); + assertTrue(auth.isUserPermitted(new SecureServicePermission("permission-type-filter-vf","dev","12345-55555-55555-5555"))); + assertFalse(auth.isUserPermitted(new SecureServicePermission("permission-type-cl","test","read"))); } } -- cgit 1.2.3-korg