From b2e2d5f8daeefb08873d11de44cb4cfe7cfab03a Mon Sep 17 00:00:00 2001 From: waynedunican Date: Fri, 24 Jul 2020 09:46:36 +0100 Subject: SONAR assertions apex-pdp Ensure assertions are present in test cases Issue-ID: POLICY-2706 Change-Id: I3673a7668564401d2136450b0bdd7a013605dd7c Signed-off-by: waynedunican --- .../integration/executor/engine/TestApexEngineJava.java | 10 +++++++--- .../integration/executor/engine/TestApexEngineJavascript.java | 9 ++++++--- .../integration/executor/engine/TestApexEngineJython.java | 8 ++++++-- .../integration/executor/engine/TestApexEngineMvel.java | 8 ++++++-- 4 files changed, 25 insertions(+), 10 deletions(-) (limited to 'testsuites/integration') diff --git a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJava.java b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJava.java index 1bdd0758c..937a89d9d 100644 --- a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJava.java +++ b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJava.java @@ -21,6 +21,8 @@ package org.onap.policy.apex.testsuites.integration.executor.engine; +import static org.assertj.core.api.Assertions.assertThatCode; + import java.io.IOException; import org.junit.After; import org.junit.Before; @@ -96,8 +98,10 @@ public class TestApexEngineJava { * @throws ApexException the apex exception */ @Test - public void testApexEngineJava() throws InterruptedException, IOException, ApexException { - new TestApexEngine("JAVA", engineParameters); - new TestApexEngine("JAVA", engineParameters); + public void testApexEngineJava() { + assertThatCode(() -> { + new TestApexEngine("JAVA", engineParameters); + new TestApexEngine("JAVA", engineParameters); + }).doesNotThrowAnyException(); } } diff --git a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJavascript.java b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJavascript.java index a06c49f7a..108416bca 100644 --- a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJavascript.java +++ b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJavascript.java @@ -21,6 +21,8 @@ package org.onap.policy.apex.testsuites.integration.executor.engine; +import static org.assertj.core.api.Assertions.assertThatCode; + import java.io.IOException; import org.junit.After; import org.junit.Before; @@ -95,8 +97,9 @@ public class TestApexEngineJavascript { */ @Test public void testApexEngineJavascript() throws ApexException, InterruptedException, IOException { - - new TestApexEngine("JAVASCRIPT", engineParameters); - new TestApexEngine("JAVASCRIPT", engineParameters); + assertThatCode(() -> { + new TestApexEngine("JAVASCRIPT", engineParameters); + new TestApexEngine("JAVASCRIPT", engineParameters); + }).doesNotThrowAnyException(); } } diff --git a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJython.java b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJython.java index f62c7e3e7..76b3835a1 100644 --- a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJython.java +++ b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineJython.java @@ -21,6 +21,8 @@ package org.onap.policy.apex.testsuites.integration.executor.engine; +import static org.assertj.core.api.Assertions.assertThatCode; + import java.io.IOException; import org.junit.After; import org.junit.Before; @@ -98,7 +100,9 @@ public class TestApexEngineJython { */ @Test public void testApexEngineJython() throws ApexException, InterruptedException, IOException { - new TestApexEngine("JAVASCRIPT", engineParameters); - new TestApexEngine("JAVASCRIPT", engineParameters); + assertThatCode(() -> { + new TestApexEngine("JAVASCRIPT", engineParameters); + new TestApexEngine("JAVASCRIPT", engineParameters); + }).doesNotThrowAnyException(); } } diff --git a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineMvel.java b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineMvel.java index bb24ed9e7..499dc59d9 100644 --- a/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineMvel.java +++ b/testsuites/integration/integration-executor-test/src/test/java/org/onap/policy/apex/testsuites/integration/executor/engine/TestApexEngineMvel.java @@ -21,6 +21,8 @@ package org.onap.policy.apex.testsuites.integration.executor.engine; +import static org.assertj.core.api.Assertions.assertThatCode; + import java.io.IOException; import org.junit.After; import org.junit.Before; @@ -95,7 +97,9 @@ public class TestApexEngineMvel { */ @Test public void testApexEngineMvel() throws ApexException, InterruptedException, IOException { - new TestApexEngine("MVEL", engineParameters); - new TestApexEngine("MVEL", engineParameters); + assertThatCode(() -> { + new TestApexEngine("MVEL", engineParameters); + new TestApexEngine("MVEL", engineParameters); + }).doesNotThrowAnyException(); } } -- cgit 1.2.3-korg