From 7a0a44eac6167cfeff935c39f2c3f20d3a893c3e Mon Sep 17 00:00:00 2001 From: liamfallon Date: Wed, 4 Dec 2019 09:20:04 +0000 Subject: Minor changes for new Eclipse checkstyle checks The laest Eclipse checkstyle version 8.26.0 does more thorough checking and identified a number of small issues in the apex-pdp codebase. This review fixes those issues. Issue-ID: POLICY-1913 Change-Id: I30ba25e3e425c6d54c77f925e8da3ab841a8357c Signed-off-by: liamfallon --- .../context/factory/TestContextAlbumFactory.java | 4 +- .../integration/context/utils/Constants.java | 4 +- .../integration/context/utils/NetworkUtils.java | 11 ++- .../resources/infinispan/default-jgroups-udp.xml | 101 +++++++++++---------- 4 files changed, 65 insertions(+), 55 deletions(-) (limited to 'testsuites/integration/integration-context-test/src') diff --git a/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/factory/TestContextAlbumFactory.java b/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/factory/TestContextAlbumFactory.java index 45ea0fdc4..4abbc2051 100644 --- a/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/factory/TestContextAlbumFactory.java +++ b/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/factory/TestContextAlbumFactory.java @@ -60,7 +60,9 @@ public final class TestContextAlbumFactory { /** * Default constructor to prevent sub-classing. */ - private TestContextAlbumFactory() {} + private TestContextAlbumFactory() { + // Private constructor to block subclassing + } /** * Creates the policy context model. diff --git a/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/Constants.java b/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/Constants.java index 6fdcf6121..bf0c57a5f 100644 --- a/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/Constants.java +++ b/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/Constants.java @@ -68,7 +68,9 @@ public class Constants { /** * Instantiates a new constants. */ - private Constants() {} + private Constants() { + // Private constructor to block subclassing + } /** * Gets the ax artifact key array. diff --git a/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/NetworkUtils.java b/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/NetworkUtils.java index ac43b7120..30bc8d823 100644 --- a/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/NetworkUtils.java +++ b/testsuites/integration/integration-context-test/src/test/java/org/onap/policy/apex/testsuites/integration/context/utils/NetworkUtils.java @@ -37,12 +37,14 @@ public class NetworkUtils { /** * Instantiates a new network utils. */ - private NetworkUtils() {} + private NetworkUtils() { + // Private constructor to block subclassing + } /** - * The JGroups IP address must be set to a real (not loopback) IP address for Infinispan to - * work. In order to ensure that all the JVMs in a test pick up the same IP address, this - * function sets the address to be the first non-loopback IPv4 address on a host + * The JGroups IP address must be set to a real (not loopback) IP address for Infinispan to work. In order to ensure + * that all the JVMs in a test pick up the same IP address, this function sets the address to be the first + * non-loopback IPv4 address on a host * * @return Set of IPv4 addresses * @throws SocketException throw socket exception if error occurs @@ -63,5 +65,4 @@ public class NetworkUtils { return ipAddressSet; } - } diff --git a/testsuites/integration/integration-context-test/src/test/resources/infinispan/default-jgroups-udp.xml b/testsuites/integration/integration-context-test/src/test/resources/infinispan/default-jgroups-udp.xml index a84a737b5..79a3d0633 100644 --- a/testsuites/integration/integration-context-test/src/test/resources/infinispan/default-jgroups-udp.xml +++ b/testsuites/integration/integration-context-test/src/test/resources/infinispan/default-jgroups-udp.xml @@ -6,23 +6,25 @@ Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - + http://www.apache.org/licenses/LICENSE-2.0 - + Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - + SPDX-License-Identifier: Apache-2.0 ============LICENSE_END========================================================= --> - - + - - - - - - - - - - - - - - + thread_pool.keep_alive_time="60000" /> + + + + + + + + + + + + + + -- cgit 1.2.3-korg