From 04561e175d3fde166c0f54e4dcd276e347340bde Mon Sep 17 00:00:00 2001 From: liamfallon Date: Thu, 24 Jun 2021 17:01:11 +0100 Subject: Update apex-pdp for checkstyle 8.43 Issue-ID: POLICY-3206 Change-Id: I3873c85aab577e85a9ae6b610c3871ee4de6ea53 Signed-off-by: liamfallon --- .../engine/event/impl/jsonprotocolplugin/Apex2JsonEventConverter.java | 2 +- .../policy/apex/service/engine/main/ApexEngineServiceHandler.java | 3 +-- .../java/org/onap/policy/apex/service/parameters/ApexParameters.java | 4 ++-- .../carriertechnology/RestPluginCarrierTechnologyParameters.java | 4 ++-- .../policy/apex/services/onappf/handler/PdpUpdateMessageHandler.java | 1 - 5 files changed, 6 insertions(+), 8 deletions(-) (limited to 'services') diff --git a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/jsonprotocolplugin/Apex2JsonEventConverter.java b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/jsonprotocolplugin/Apex2JsonEventConverter.java index d64d46a7c..56f0d6ba8 100644 --- a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/jsonprotocolplugin/Apex2JsonEventConverter.java +++ b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/jsonprotocolplugin/Apex2JsonEventConverter.java @@ -466,7 +466,7 @@ public class Apex2JsonEventConverter implements ApexEventProtocolConverter { * Determine the name space field of the event header. * * @param jsonObject the event in JSON format - * @param eventName the name of the event + * @param name the name of the event * @param eventDefinition the definition of the event structure * @return the event version */ diff --git a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/main/ApexEngineServiceHandler.java b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/main/ApexEngineServiceHandler.java index f278fd59d..ca76a53a6 100644 --- a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/main/ApexEngineServiceHandler.java +++ b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/main/ApexEngineServiceHandler.java @@ -1,7 +1,7 @@ /*- * ============LICENSE_START======================================================= * Copyright (C) 2016-2018 Ericsson. All rights reserved. - * Modifications Copyright (C) 2020 Nordix Foundation. + * Modifications Copyright (C) 2021 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -43,7 +43,6 @@ public class ApexEngineServiceHandler { * Instantiates a new engine holder with its engine service and EngDep service. * * @param apexEngineService the apex engine service - * @param engDepService the EngDep service */ ApexEngineServiceHandler(final EngineService apexEngineService) { this.apexEngineService = apexEngineService; diff --git a/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/ApexParameters.java b/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/ApexParameters.java index 90c5f43ae..a9ed3265c 100644 --- a/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/ApexParameters.java +++ b/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/ApexParameters.java @@ -258,8 +258,8 @@ public class ApexParameters implements ParameterGroup { * * @param handlerMapVariableName the variable name of the map on which the paired parameters are being checked * @param result The result object to which to append any error messages - * @param leftModeParameters The mode parameters being checked - * @param rightModeParameters The mode parameters being referenced by the checked parameters + * @param leftModeParameterMap The mode parameters being checked + * @param rightModeParameterMap The mode parameters being referenced by the checked parameters */ private void validatePeeredModePeers(final String handlerMapVariableName, final BeanValidationResult result, final EventHandlerPeeredMode peeredMode, final Map leftModeParameterMap, diff --git a/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/carriertechnology/RestPluginCarrierTechnologyParameters.java b/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/carriertechnology/RestPluginCarrierTechnologyParameters.java index 4e086e809..2c5c4c05a 100644 --- a/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/carriertechnology/RestPluginCarrierTechnologyParameters.java +++ b/services/services-engine/src/main/java/org/onap/policy/apex/service/parameters/carriertechnology/RestPluginCarrierTechnologyParameters.java @@ -1,7 +1,7 @@ /*- * ============LICENSE_START======================================================= * Copyright (C) 2016-2018 Ericsson. All rights reserved. - * Modifications Copyright (C) 2019-2020 Nordix Foundation. + * Modifications Copyright (C) 2019-2021 Nordix Foundation. * Modifications Copyright (C) 2021 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); @@ -201,7 +201,7 @@ public class RestPluginCarrierTechnologyParameters extends CarrierTechnologyPara /** * Validate the HTTP headers. * - * @param result the result of the validation + * @return the result of the validation */ private ValidationResult validateHttpHeaders() { if (httpHeaders == null) { diff --git a/services/services-onappf/src/main/java/org/onap/policy/apex/services/onappf/handler/PdpUpdateMessageHandler.java b/services/services-onappf/src/main/java/org/onap/policy/apex/services/onappf/handler/PdpUpdateMessageHandler.java index 479ec9a72..e6c2c399a 100644 --- a/services/services-onappf/src/main/java/org/onap/policy/apex/services/onappf/handler/PdpUpdateMessageHandler.java +++ b/services/services-onappf/src/main/java/org/onap/policy/apex/services/onappf/handler/PdpUpdateMessageHandler.java @@ -134,7 +134,6 @@ public class PdpUpdateMessageHandler { * * @param pdpUpdateMsg the pdp update message from pap * @param pdpMessageHandler pdp message handler - * @param pdpStatusContext the pdp status object in memory * @return pdpResponseDetails the pdp response */ private PdpResponseDetails startOrStopApexEngineBasedOnPolicies(final PdpUpdate pdpUpdateMsg, -- cgit 1.2.3-korg