From 51f1fffd687e53c858685ec41fd3ab8cfd4fcdf1 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Wed, 1 Sep 2021 11:45:05 -0400 Subject: Fix sonars in apex-pdp #3 Fixed: - use "var" - use assertEquals instead of assertTrue(xxx.equals()) - separate assertions Issue-ID: POLICY-3093 Change-Id: Id4db62626948681cd267e68a56dda65fa355c6f8 Signed-off-by: Jim Hahn --- .../policy/apex/service/engine/event/impl/EventConsumerFactory.java | 4 ++-- .../policy/apex/service/engine/event/impl/EventProducerFactory.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'services/services-engine/src/main/java') diff --git a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventConsumerFactory.java b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventConsumerFactory.java index 2f6922a2b..acf49e385 100644 --- a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventConsumerFactory.java +++ b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventConsumerFactory.java @@ -2,6 +2,7 @@ * ============LICENSE_START======================================================= * Copyright (C) 2016-2018 Ericsson. All rights reserved. * Modifications Copyright (C) 2019-2020 Nordix Foundation. + * Modifications Copyright (C) 2021 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,7 +24,6 @@ package org.onap.policy.apex.service.engine.event.impl; import org.onap.policy.apex.service.engine.event.ApexEventConsumer; import org.onap.policy.apex.service.engine.event.ApexEventException; -import org.onap.policy.apex.service.parameters.carriertechnology.CarrierTechnologyParameters; import org.onap.policy.apex.service.parameters.eventhandler.EventHandlerParameters; import org.slf4j.ext.XLogger; import org.slf4j.ext.XLoggerFactory; @@ -48,7 +48,7 @@ public class EventConsumerFactory { public ApexEventConsumer createConsumer(final String name, final EventHandlerParameters consumerParameters) throws ApexEventException { // Get the carrier technology parameters - final CarrierTechnologyParameters technologyParameters = consumerParameters.getCarrierTechnologyParameters(); + final var technologyParameters = consumerParameters.getCarrierTechnologyParameters(); // Get the class for the event consumer using reflection final String consumerPluginClass = technologyParameters.getEventConsumerPluginClass(); diff --git a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventProducerFactory.java b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventProducerFactory.java index e87e2fd78..7139625ab 100644 --- a/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventProducerFactory.java +++ b/services/services-engine/src/main/java/org/onap/policy/apex/service/engine/event/impl/EventProducerFactory.java @@ -2,6 +2,7 @@ * ============LICENSE_START======================================================= * Copyright (C) 2016-2018 Ericsson. All rights reserved. * Modifications Copyright (C) 2019-2020 Nordix Foundation. + * Modifications Copyright (C) 2021 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,7 +24,6 @@ package org.onap.policy.apex.service.engine.event.impl; import org.onap.policy.apex.service.engine.event.ApexEventException; import org.onap.policy.apex.service.engine.event.ApexEventProducer; -import org.onap.policy.apex.service.parameters.carriertechnology.CarrierTechnologyParameters; import org.onap.policy.apex.service.parameters.eventhandler.EventHandlerParameters; import org.slf4j.ext.XLogger; import org.slf4j.ext.XLoggerFactory; @@ -48,7 +48,7 @@ public class EventProducerFactory { public ApexEventProducer createProducer(final String name, final EventHandlerParameters producerParameters) throws ApexEventException { // Get the carrier technology parameters - final CarrierTechnologyParameters technologyParameters = producerParameters.getCarrierTechnologyParameters(); + final var technologyParameters = producerParameters.getCarrierTechnologyParameters(); // Get the class for the event producer using reflection final String producerPluginClass = technologyParameters.getEventProducerPluginClass(); -- cgit 1.2.3-korg