From 5bf11a7500944b8b306c5d4f478e4bc45ef1fb51 Mon Sep 17 00:00:00 2001 From: liamfallon Date: Wed, 21 Aug 2019 09:39:44 +0000 Subject: Fix checkstyle warnings in apex-pdp Unit tests introduced some checkstyle warnings, this review resolves those warnings. Issue-ID: POLICY-1942 Change-Id: I16438621c1db0adfbe70bc8b237d05bd7cc72697 Signed-off-by: liamfallon --- client/client-deployment/pom.xml | 1 - .../policy/apex/client/deployment/rest/ApexDeploymentRestResource.java | 1 - .../onap/policy/apex/client/deployment/rest/DeploymentExceptionTest.java | 1 + .../onap/policy/apex/client/deployment/rest/DeploymentRestMainTest.java | 1 + .../policy/apex/client/deployment/rest/DeploymentRestParameterTest.java | 1 + .../org/onap/policy/apex/client/deployment/rest/ParameterCheckTest.java | 1 + .../org/onap/policy/apex/client/deployment/rest/RestResourceTest.java | 1 + client/client-full/pom.xml | 1 - .../java/org/onap/policy/apex/client/full/rest/ParameterCheckTest.java | 1 + .../org/onap/policy/apex/client/full/rest/ServicesExceptionTest.java | 1 + .../java/org/onap/policy/apex/client/full/rest/ServicesRestMainTest.java | 1 + .../org/onap/policy/apex/client/full/rest/ServicesRestParameterTest.java | 1 + 12 files changed, 9 insertions(+), 3 deletions(-) (limited to 'client') diff --git a/client/client-deployment/pom.xml b/client/client-deployment/pom.xml index aef5450ed..118d0870f 100644 --- a/client/client-deployment/pom.xml +++ b/client/client-deployment/pom.xml @@ -68,7 +68,6 @@ org.assertj assertj-core - 3.13.2 test diff --git a/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestResource.java b/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestResource.java index 55cabe900..4f6e71b2f 100644 --- a/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestResource.java +++ b/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestResource.java @@ -95,7 +95,6 @@ public class ApexDeploymentRestResource { * @param hostName the host name of the engine service to connect to. * @param port the port number of the engine service to connect to. * @param uploadedInputStream input stream - * @param fileDetail details on the file * @param ignoreConflicts conflict policy * @param forceUpdate update policy * @return a response object in plain text confirming the upload was successful diff --git a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentExceptionTest.java b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentExceptionTest.java index fc941acf0..d89f1faa6 100644 --- a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentExceptionTest.java +++ b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentExceptionTest.java @@ -21,6 +21,7 @@ package org.onap.policy.apex.client.deployment.rest; import static org.junit.Assert.assertEquals; + import org.junit.Test; /** diff --git a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestMainTest.java b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestMainTest.java index 2ca12ab9a..12fe8e528 100644 --- a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestMainTest.java +++ b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestMainTest.java @@ -23,6 +23,7 @@ package org.onap.policy.apex.client.deployment.rest; import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatCode; import static org.assertj.core.api.Assertions.catchThrowable; + import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.InputStream; diff --git a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestParameterTest.java b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestParameterTest.java index 4fddffaef..16a7b2897 100644 --- a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestParameterTest.java +++ b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/DeploymentRestParameterTest.java @@ -21,6 +21,7 @@ package org.onap.policy.apex.client.deployment.rest; import static org.junit.Assert.assertEquals; + import org.junit.Test; /** diff --git a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/ParameterCheckTest.java b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/ParameterCheckTest.java index a0c4c9c3e..9218347df 100644 --- a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/ParameterCheckTest.java +++ b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/ParameterCheckTest.java @@ -22,6 +22,7 @@ package org.onap.policy.apex.client.deployment.rest; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; + import java.util.LinkedHashMap; import java.util.Map; import org.junit.Test; diff --git a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/RestResourceTest.java b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/RestResourceTest.java index e8625af5e..019ccc8cb 100644 --- a/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/RestResourceTest.java +++ b/client/client-deployment/src/test/java/org/onap/policy/apex/client/deployment/rest/RestResourceTest.java @@ -22,6 +22,7 @@ package org.onap.policy.apex.client.deployment.rest; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; + import java.io.ByteArrayInputStream; import java.io.InputStream; import javax.ws.rs.core.Response; diff --git a/client/client-full/pom.xml b/client/client-full/pom.xml index c4591af85..56d00dc20 100644 --- a/client/client-full/pom.xml +++ b/client/client-full/pom.xml @@ -80,7 +80,6 @@ org.assertj assertj-core - 3.13.2 test diff --git a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ParameterCheckTest.java b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ParameterCheckTest.java index 0be0ac91c..7203fdcc3 100644 --- a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ParameterCheckTest.java +++ b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ParameterCheckTest.java @@ -22,6 +22,7 @@ package org.onap.policy.apex.client.full.rest; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; + import java.util.LinkedHashMap; import java.util.Map; import org.junit.Test; diff --git a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesExceptionTest.java b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesExceptionTest.java index 7ae8e7143..7504a7271 100644 --- a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesExceptionTest.java +++ b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesExceptionTest.java @@ -21,6 +21,7 @@ package org.onap.policy.apex.client.full.rest; import static org.junit.Assert.assertEquals; + import org.junit.Test; /** diff --git a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestMainTest.java b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestMainTest.java index f6b3373ce..1c5c440b4 100644 --- a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestMainTest.java +++ b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestMainTest.java @@ -23,6 +23,7 @@ package org.onap.policy.apex.client.full.rest; import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatCode; import static org.assertj.core.api.Assertions.catchThrowable; + import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.InputStream; diff --git a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestParameterTest.java b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestParameterTest.java index 777a9c170..4c06d246f 100644 --- a/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestParameterTest.java +++ b/client/client-full/src/test/java/org/onap/policy/apex/client/full/rest/ServicesRestParameterTest.java @@ -22,6 +22,7 @@ package org.onap.policy.apex.client.full.rest; import static org.assertj.core.api.Assertions.assertThatCode; import static org.junit.Assert.assertEquals; + import org.junit.Test; /** -- cgit 1.2.3-korg