From 933af17963b47650fe9864d03e63a06aa08e31a9 Mon Sep 17 00:00:00 2001 From: Dinh Danh Le Date: Mon, 13 Aug 2018 11:20:21 +0100 Subject: Fix checkstyle warnings in the client module Change-Id: I3263a833cc9dd6d86afdf2ae53de0e53c92850c9 Signed-off-by: Dinh Danh Le Issue-ID: POLICY-1034 --- .../onap/policy/apex/client/full/rest/ApexServicesRest.java | 12 +++++++----- .../policy/apex/client/full/rest/ApexServicesRestMain.java | 2 +- .../client/full/rest/ApexServicesRestParameterException.java | 4 ++-- .../client/full/rest/ApexServicesRestParameterParser.java | 6 +++--- .../apex/client/full/rest/ApexServicesRestParameters.java | 4 ++-- .../onap/policy/apex/client/full/rest/ParameterCheck.java | 4 ++-- 6 files changed, 17 insertions(+), 15 deletions(-) (limited to 'client/client-full/src/main') diff --git a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRest.java b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRest.java index 3a38dc082..c6460d2c9 100644 --- a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRest.java +++ b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRest.java @@ -29,7 +29,8 @@ import org.slf4j.ext.XLogger; import org.slf4j.ext.XLoggerFactory; /** - * This class is used to launch the services. It creates a Grizzly embedded web server and runs the services. + * This class is used to launch the services. It creates a Grizzly embedded web server and runs the + * services. */ public class ApexServicesRest { // Logger for this class @@ -39,16 +40,17 @@ public class ApexServicesRest { private HttpServer server; /** - * Starts the HTTP server for the Apex services client on the default base URI and with the default REST packages + * Starts the HTTP server for the Apex services client on the default base URI and with the + * default REST packages. */ public ApexServicesRest() { this(new ApexServicesRestParameters()); } /** - * Starts the HTTP server for the Apex services client + * Starts the HTTP server for the Apex services client. * - * @param parameters: The Apex parameters to use to start the server + * @param parameters The Apex parameters to use to start the server */ public ApexServicesRest(final ApexServicesRestParameters parameters) { Assertions.argumentNotNull(parameters, "parameters may not be null"); @@ -74,7 +76,7 @@ public class ApexServicesRest { } /** - * Shut down the web server + * Shut down the web server. */ public void shutdown() { logger.debug("Apex services RESTful client shutting down . . ."); diff --git a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestMain.java b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestMain.java index a9e5db9d0..a2fb0ac73 100644 --- a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestMain.java +++ b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestMain.java @@ -40,7 +40,7 @@ public class ApexServicesRestMain { INITIALIZING, /** The editor is running. */ RUNNING - }; + } private static final int EDITOR_RNNING_CHECK_TIMEOUT = 1000; diff --git a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterException.java b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterException.java index 8b966b13f..f78de67c6 100644 --- a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterException.java +++ b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterException.java @@ -23,13 +23,13 @@ package org.onap.policy.apex.client.full.rest; /** * A run time exception used to report parsing and parameter input errors. * - * User: ewatkmi Date: 31 Jul 2017 + * @author Michael Watkins (michael.watkins@ericsson.com) */ public class ApexServicesRestParameterException extends IllegalArgumentException { private static final long serialVersionUID = 6520231162404452427L; /** - * Create an ApexServicesRestParameterException with a message + * Create an ApexServicesRestParameterException with a message. * * @param message the message */ diff --git a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterParser.java b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterParser.java index 28b0d4cf4..8a90aa633 100644 --- a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterParser.java +++ b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameterParser.java @@ -32,16 +32,16 @@ import org.apache.commons.cli.Options; import org.apache.commons.cli.ParseException; /** - * This class reads and handles command line parameters to the Apex RESTful services + * This class reads and handles command line parameters to the Apex RESTful services. * - * User: ewatkmi Date: 31 Jul 2017 + * @author Michael Watkins (michael.watkins@ericsson.com) */ public class ApexServicesRestParameterParser { // Apache Commons CLI options Options options; /** - * Construct the options for the CLI RESTful services + * Construct the options for the CLI RESTful services. */ public ApexServicesRestParameterParser() { options = new Options(); diff --git a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameters.java b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameters.java index ab81d4b05..52ad885fd 100644 --- a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameters.java +++ b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ApexServicesRestParameters.java @@ -23,9 +23,9 @@ package org.onap.policy.apex.client.full.rest; import java.net.URI; /** - * This class reads and handles command line parameters to the Apex RESTful services + * This class reads and handles command line parameters to the Apex RESTful services. * - * User: ewatkmi Date: 31 Jul 2017 + * @author Michael Watkins (michael.watkins@ericsson.com) */ public class ApexServicesRestParameters { public static final int DEFAULT_REST_PORT = 18989; diff --git a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ParameterCheck.java b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ParameterCheck.java index 3384a17f8..8e7cbea71 100644 --- a/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ParameterCheck.java +++ b/client/client-full/src/main/java/org/onap/policy/apex/client/full/rest/ParameterCheck.java @@ -40,7 +40,7 @@ public final class ParameterCheck { private ParameterCheck() {} /** - * The Enum StartStop is used to hold . + * The Enum StartStop is used to hold. * * @author Liam Fallon (liam.fallon@ericsson.com) */ @@ -49,7 +49,7 @@ public final class ParameterCheck { START, /** Stop of an Apex engine has been ordered. */ STOP - }; + } private static final XLogger LOGGER = XLoggerFactory.getXLogger(ParameterCheck.class); -- cgit 1.2.3-korg