From 9c0c0c8f61a08aec5c95ebb90647a0aae445e129 Mon Sep 17 00:00:00 2001 From: liamfallon Date: Fri, 19 Jun 2020 17:04:51 +0100 Subject: Changes for checkstyle 8.32 Issue-ID: POLICY-2188 Change-Id: I56bbf3aa3bd9e1ef433cc93ad2be0c54d141a2a5 Signed-off-by: liamfallon --- .../java/org/onap/policy/apex/client/editor/rest/ApexEditorMain.java | 4 +--- .../policy/apex/client/editor/rest/ApexEditorParameterParser.java | 1 - .../org/onap/policy/apex/client/editor/rest/ApexEditorParameters.java | 1 - .../apex/client/editor/rest/handling/ApexEditorRestResource.java | 2 -- .../onap/policy/apex/client/editor/rest/handling/KeyInfoHandler.java | 3 +-- .../onap/policy/apex/client/editor/rest/handling/PolicyHandler.java | 1 - .../org/onap/policy/apex/client/editor/rest/handling/RestSession.java | 3 +-- .../policy/apex/client/editor/rest/handling/RestSessionHandler.java | 1 - .../org/onap/policy/apex/client/editor/rest/handling/RestUtils.java | 3 --- .../org/onap/policy/apex/client/editor/rest/handling/TaskHandler.java | 1 - .../onap/policy/apex/client/editor/rest/handling/bean/BeanEvent.java | 1 - .../onap/policy/apex/client/editor/rest/handling/bean/BeanPolicy.java | 1 - .../onap/policy/apex/client/editor/rest/handling/bean/BeanState.java | 1 - .../onap/policy/apex/client/editor/rest/handling/bean/BeanTask.java | 1 - .../onap/policy/apex/client/editor/rest/ApexEditorStartupTest.java | 1 - .../java/org/onap/policy/apex/client/editor/rest/ExceptionsTest.java | 1 - .../org/onap/policy/apex/client/editor/rest/RestInterfaceTest.java | 2 -- .../apex/client/editor/rest/handling/ApexEditorRestResourceTest.java | 2 -- 18 files changed, 3 insertions(+), 27 deletions(-) (limited to 'client/client-editor/src') diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorMain.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorMain.java index 558cbadc7..3f728827e 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorMain.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorMain.java @@ -22,7 +22,6 @@ package org.onap.policy.apex.client.editor.rest; import java.io.PrintStream; - import org.slf4j.ext.XLogger; import org.slf4j.ext.XLoggerFactory; @@ -140,8 +139,7 @@ public class ApexEditorMain { String message = REST_ENDPOINT_PREFIX + this.toString() + ") failed at with error: " + e.getMessage(); outStream.println(message); LOGGER.warn(message, e); - } - finally { + } finally { if (apexEditor != null) { apexEditor.shutdown(); apexEditor = null; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameterParser.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameterParser.java index d67c6b1c6..ef89945aa 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameterParser.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameterParser.java @@ -23,7 +23,6 @@ package org.onap.policy.apex.client.editor.rest; import java.io.PrintWriter; import java.io.StringWriter; import java.util.Arrays; - import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.DefaultParser; import org.apache.commons.cli.HelpFormatter; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameters.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameters.java index d220d85c4..1687c01e0 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameters.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/ApexEditorParameters.java @@ -22,7 +22,6 @@ package org.onap.policy.apex.client.editor.rest; import java.net.URI; import java.net.URISyntaxException; - import org.slf4j.ext.XLogger; import org.slf4j.ext.XLoggerFactory; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResource.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResource.java index 51dcf0987..9c3a3de26 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResource.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResource.java @@ -22,7 +22,6 @@ package org.onap.policy.apex.client.editor.rest.handling; import java.io.IOException; - import javax.ws.rs.Consumes; import javax.ws.rs.DELETE; import javax.ws.rs.GET; @@ -33,7 +32,6 @@ import javax.ws.rs.PathParam; import javax.ws.rs.Produces; import javax.ws.rs.QueryParam; import javax.ws.rs.core.MediaType; - import org.onap.policy.apex.model.modelapi.ApexApiResult; import org.onap.policy.apex.model.modelapi.ApexApiResult.Result; import org.onap.policy.common.utils.resources.TextFileUtils; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/KeyInfoHandler.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/KeyInfoHandler.java index f4ff4cd93..ddf1db35d 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/KeyInfoHandler.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/KeyInfoHandler.java @@ -53,8 +53,7 @@ public class KeyInfoHandler implements RestCommandHandler { if (RestCommandType.KEY_INFO.equals(commandType) && RestCommand.LIST.equals(command)) { return listKeyInformation(session, name, version); - } - else { + } else { return getUnsupportedCommandResultMessage(session, commandType, command); } } diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/PolicyHandler.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/PolicyHandler.java index ee6164468..7de16b044 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/PolicyHandler.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/PolicyHandler.java @@ -21,7 +21,6 @@ package org.onap.policy.apex.client.editor.rest.handling; import java.util.Map; - import org.onap.policy.apex.client.editor.rest.handling.bean.BeanKeyRef; import org.onap.policy.apex.client.editor.rest.handling.bean.BeanLogic; import org.onap.policy.apex.client.editor.rest.handling.bean.BeanPolicy; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSession.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSession.java index 3e616ef3a..46d57fd01 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSession.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSession.java @@ -93,8 +93,7 @@ public class RestSession { public void finishSession(boolean commitFlag) { if (commitFlag) { commitChanges(); - } - else { + } else { discardChanges(); } } diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSessionHandler.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSessionHandler.java index b717944ed..c6cfca845 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSessionHandler.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestSessionHandler.java @@ -23,7 +23,6 @@ package org.onap.policy.apex.client.editor.rest.handling; import java.util.Map; import java.util.TreeMap; import java.util.concurrent.atomic.AtomicInteger; - import org.onap.policy.apex.model.modelapi.ApexApiResult; import org.onap.policy.apex.model.modelapi.ApexApiResult.Result; import org.slf4j.ext.XLogger; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestUtils.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestUtils.java index 738f33cb1..55a07a30f 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestUtils.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/RestUtils.java @@ -26,19 +26,16 @@ import com.google.gson.JsonElement; import com.google.gson.JsonNull; import com.google.gson.JsonObject; import com.google.gson.JsonPrimitive; - import java.io.StringReader; import java.util.Map; import java.util.Map.Entry; import java.util.TreeMap; - import javax.ws.rs.core.MediaType; import javax.xml.bind.JAXBContext; import javax.xml.bind.JAXBElement; import javax.xml.bind.JAXBException; import javax.xml.bind.Unmarshaller; import javax.xml.transform.stream.StreamSource; - import org.eclipse.persistence.jaxb.MarshallerProperties; import org.onap.policy.apex.client.editor.rest.handling.bean.BeanBase; import org.onap.policy.apex.model.basicmodel.concepts.AxConcept; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/TaskHandler.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/TaskHandler.java index 2b90282d3..87f5fca26 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/TaskHandler.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/TaskHandler.java @@ -21,7 +21,6 @@ package org.onap.policy.apex.client.editor.rest.handling; import java.util.Map.Entry; - import org.onap.policy.apex.client.editor.rest.handling.bean.BeanField; import org.onap.policy.apex.client.editor.rest.handling.bean.BeanKeyRef; import org.onap.policy.apex.client.editor.rest.handling.bean.BeanLogic; diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanEvent.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanEvent.java index c96e43c29..0d2ad737b 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanEvent.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanEvent.java @@ -21,7 +21,6 @@ package org.onap.policy.apex.client.editor.rest.handling.bean; import java.util.Map; - import javax.xml.bind.annotation.XmlType; /** diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanPolicy.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanPolicy.java index da2f721e7..a3a4194f9 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanPolicy.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanPolicy.java @@ -21,7 +21,6 @@ package org.onap.policy.apex.client.editor.rest.handling.bean; import java.util.Map; - import javax.xml.bind.annotation.XmlType; /** diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanState.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanState.java index 8ca5912fa..575511be6 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanState.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanState.java @@ -22,7 +22,6 @@ package org.onap.policy.apex.client.editor.rest.handling.bean; import java.util.Arrays; import java.util.Map; - import javax.xml.bind.annotation.XmlType; /** diff --git a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanTask.java b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanTask.java index b5a231bcd..6c023e89f 100644 --- a/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanTask.java +++ b/client/client-editor/src/main/java/org/onap/policy/apex/client/editor/rest/handling/bean/BeanTask.java @@ -22,7 +22,6 @@ package org.onap.policy.apex.client.editor.rest.handling.bean; import java.util.Arrays; import java.util.Map; - import javax.xml.bind.annotation.XmlType; /** diff --git a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ApexEditorStartupTest.java b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ApexEditorStartupTest.java index ac1c60553..fdf1e804a 100644 --- a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ApexEditorStartupTest.java +++ b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ApexEditorStartupTest.java @@ -29,7 +29,6 @@ import java.io.ByteArrayOutputStream; import java.io.IOException; import java.io.PrintStream; import java.util.concurrent.TimeUnit; - import org.junit.Test; import org.onap.policy.apex.client.editor.rest.ApexEditorMain.EditorState; diff --git a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ExceptionsTest.java b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ExceptionsTest.java index 987076fd1..cbe0e4b58 100644 --- a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ExceptionsTest.java +++ b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/ExceptionsTest.java @@ -23,7 +23,6 @@ package org.onap.policy.apex.client.editor.rest; import static org.junit.Assert.assertNotNull; import java.io.IOException; - import org.junit.Test; /** diff --git a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/RestInterfaceTest.java b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/RestInterfaceTest.java index c95a04a76..a1d0a7b3f 100644 --- a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/RestInterfaceTest.java +++ b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/RestInterfaceTest.java @@ -30,14 +30,12 @@ import java.io.ByteArrayInputStream; import java.io.IOException; import java.io.InputStream; import java.util.concurrent.TimeUnit; - import javax.ws.rs.client.Client; import javax.ws.rs.client.ClientBuilder; import javax.ws.rs.client.Entity; import javax.ws.rs.client.Invocation.Builder; import javax.ws.rs.client.WebTarget; import javax.xml.bind.JAXBException; - import org.eclipse.persistence.jpa.jpql.Assert; import org.junit.AfterClass; import org.junit.BeforeClass; diff --git a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResourceTest.java b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResourceTest.java index 346376d22..642628f97 100644 --- a/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResourceTest.java +++ b/client/client-editor/src/test/java/org/onap/policy/apex/client/editor/rest/handling/ApexEditorRestResourceTest.java @@ -25,11 +25,9 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import java.io.IOException; - import javax.ws.rs.client.Entity; import javax.ws.rs.core.Application; import javax.ws.rs.core.MediaType; - import org.glassfish.jersey.server.ResourceConfig; import org.glassfish.jersey.test.JerseyTest; import org.junit.Test; -- cgit 1.2.3-korg