From 952d4f5aab9913f961e77fa0457da5d38f31d94f Mon Sep 17 00:00:00 2001 From: liamfallon Date: Sun, 16 Sep 2018 02:03:12 +0100 Subject: Fix Sonar issues in apex Fixing various Sonar issues in apex. Issue-ID: POLICY-1034 Change-Id: Ie693637d75bd7e38c71b7ba04886fb75636276ed Signed-off-by: liamfallon --- .../client/deployment/rest/ApexDeploymentRestParameterParser.java | 2 +- .../org/onap/policy/apex/client/deployment/rest/ParameterCheck.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'client/client-deployment') diff --git a/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestParameterParser.java b/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestParameterParser.java index 7e305788f..d56e05d29 100644 --- a/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestParameterParser.java +++ b/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ApexDeploymentRestParameterParser.java @@ -38,7 +38,7 @@ import org.apache.commons.cli.ParseException; */ public class ApexDeploymentRestParameterParser { // Apache Commons CLI options - Options options; + private Options options; /** * Construct the options for the CLI RESTful services. diff --git a/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ParameterCheck.java b/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ParameterCheck.java index fb18a002f..5026c5162 100644 --- a/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ParameterCheck.java +++ b/client/client-deployment/src/main/java/org/onap/policy/apex/client/deployment/rest/ParameterCheck.java @@ -178,9 +178,9 @@ public final class ParameterCheck { } ParameterCheck.StartStop startStop; - if (startStopValue[0].equalsIgnoreCase("start")) { + if ("start".equalsIgnoreCase(startStopValue[0])) { startStop = ParameterCheck.StartStop.START; - } else if (startStopValue[0].equalsIgnoreCase("stop")) { + } else if ("stop".equalsIgnoreCase(startStopValue[0])) { startStop = ParameterCheck.StartStop.STOP; } else { LOGGER.warn("value \"{}\"of parameter \"{}\" not \"start\" or \"stop\"", startStopValue[0], startStopPar); -- cgit 1.2.3-korg