From 3ab54a2340f40d11d9a0a3994f579baeeb6c0ca6 Mon Sep 17 00:00:00 2001 From: Dinh Danh Le Date: Tue, 14 Aug 2018 12:32:51 +0100 Subject: Fix checkstyle warnings in the auth package Change-Id: I64f783d5325301862e2438ac5d22cfcc0a150579 Signed-off-by: Dinh Danh Le Issue-ID: POLICY-1034 --- .../org/onap/policy/apex/auth/clieditor/ApexCLIEditorMain.java | 5 +++-- .../java/org/onap/policy/apex/auth/clieditor/CLIException.java | 6 +++--- .../java/org/onap/policy/apex/auth/clieditor/CLILineParser.java | 4 ++-- .../org/onap/policy/apex/auth/clieditor/CLIParameterParser.java | 9 ++++++--- .../java/org/onap/policy/apex/auth/clieditor/CLIParameters.java | 2 +- 5 files changed, 15 insertions(+), 11 deletions(-) (limited to 'auth/cli-editor/src/main/java/org') diff --git a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/ApexCLIEditorMain.java b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/ApexCLIEditorMain.java index e484ff03f..c7f7c7bb1 100644 --- a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/ApexCLIEditorMain.java +++ b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/ApexCLIEditorMain.java @@ -152,7 +152,8 @@ public class ApexCLIEditorMain { if (errorCount == 0) { LOGGER.info("Apex CLI editor completed execution"); } else { - LOGGER.error("execution of Apex command line editor failed: {} command execution failure(s) occurred", errorCount); + LOGGER.error("execution of Apex command line editor failed: {} command execution failure(s) occurred", + errorCount); } } catch (final IOException e) { LOGGER.error("execution of Apex command line editor failed: " + e.getMessage()); @@ -160,7 +161,7 @@ public class ApexCLIEditorMain { } /** - * Get the number of errors encountered in command processing + * Get the number of errors encountered in command processing. * * @return the number of errors */ diff --git a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIException.java b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIException.java index 8e1104c3b..94b8c14a6 100644 --- a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIException.java +++ b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIException.java @@ -41,9 +41,9 @@ public class CLIException extends IllegalArgumentException { * Create a CLIException with a message and an exception. * * @param message the message - * @param t the t + * @param th the throwable */ - public CLIException(final String message, final Throwable t) { - super(message, t); + public CLIException(final String message, final Throwable th) { + super(message, th); } } diff --git a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLILineParser.java b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLILineParser.java index bbeface32..70c2f834b 100644 --- a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLILineParser.java +++ b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLILineParser.java @@ -36,9 +36,9 @@ public class CLILineParser { * single words followed by an '=' character Arguments are single words or a block of quoted * text following an '=' character. * - * Format: command [command....] parameter=argument [parameter = argument] + *

Format: command [command....] parameter=argument [parameter = argument] * - * Examples entity create name=hello description="description of hello" help entity list + *

Examples entity create name=hello description="description of hello" help entity list * * @param line The line to parse * @param logicBlock A block of logic code to be taken literally diff --git a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameterParser.java b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameterParser.java index 382f23fb0..8a0c6eff3 100644 --- a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameterParser.java +++ b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameterParser.java @@ -57,7 +57,8 @@ public class CLIParameterParser { .desc("name of a file containing editor commands to run into the editor").hasArg() .argName("COMMAND_FILE").required(false).type(String.class).build()); options.addOption(Option.builder("l").longOpt("log-file") - .desc("name of a file that will contain command logs from the editor, will log to standard output if not specified or suppressed with \"-nl\" flag") + .desc("name of a file that will contain command logs from the editor, will log to standard output " + + "if not specified or suppressed with \"-nl\" flag") .hasArg().argName("LOG_FILE").required(false).type(String.class).build()); options.addOption(Option.builder("nl").longOpt("no-log") .desc("if specified, no logging or output of commands to standard output or log file is carried out") @@ -74,10 +75,12 @@ public class CLIParameterParser { + "will output model to standard output if not specified or suppressed with \"-nm\" flag") .hasArg().argName("OUTPUT_MODEL_FILE").required(false).type(String.class).build()); options.addOption(Option.builder("if").longOpt("ignore-failures") - .desc("true or false, ignore failures of commands in command files and continue executing the command file") + .desc("true or false, ignore failures of commands in command files and continue executing the " + + "command file") .hasArg().argName("IGNORE_FAILURES_FLAG").required(false).type(Boolean.class).build()); options.addOption(Option.builder("wd").longOpt("working-directory") - .desc("the working directory that is the root for the CLI editor and is the root from which to look for included macro files") + .desc("the working directory that is the root for the CLI editor and is the root from which to " + + "look for included macro files") .hasArg().argName("WORKING_DIRECTORY").required(false).type(String.class).build()); } diff --git a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameters.java b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameters.java index ebaa6c572..24356d128 100644 --- a/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameters.java +++ b/auth/cli-editor/src/main/java/org/onap/policy/apex/auth/clieditor/CLIParameters.java @@ -522,7 +522,7 @@ public class CLIParameters { } /** - * Check if the command failures flag is set + * Check if the command failures flag is set. * * @return true if the command failures flag has been set */ -- cgit 1.2.3-korg