Age | Commit message (Collapse) | Author | Files | Lines |
|
ApexCommandLineArguments class to have parse() overriden to keep
remainingArgs taking the tosca file without -p.
Issue-ID: POLICY-3129
Change-Id: Ib067bf4c32992c4477cb6751f65269c103513d10
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
Change-Id: I2fbf0303805b4c5feead522ad78fd4ef518659af
Issue-ID: POLICY-3173
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
|
|
Deploying invalid APEX policies with duplicate concepts resulting in
corrupting all the policies in memory. This is fixed here.
This entire functionality handling multiple policies will be
revisited as part of https://jira.onap.org/browse/POLICY-3018
Change-Id: I751102d5dddcb92cdcede8222855e2f467bb724d
Issue-ID: POLICY-3141
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
The Keystore is no longer needed in the tarball, as it is supplied
externally by the CSITs and Helm charts. Deleted that file.
Also modified the junits to use utils-test to generates keystores at
runtime, thus deleted the junit keystore file, too.
Issue-ID: POLICY-3143
Change-Id: I9bb53fcb5887e73d661ec4c4083970630c61e5c1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3139
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia67cb1486a5625385a710c5f6c2b4325ca108820
|
|
Issue-ID: POLICY-3105
Change-Id: I53abd7e9cf8c1425d115b0bb917db6389e9ded92
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: I291f968367b1f864bb417a72fd0bdb22a07ba0f7
Issue-ID: POLICY-3127
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I761ded255a97128f858d3a7ce95f2479b6208a4e
Issue-ID: POLICY-3088
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-3069
Change-Id: Ib30782485652ec693d2dbea79514183c7cfbb0c4
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Addressed the following issues:
- initialize mocks before use
- use parameterized queries
- Random() is not secure
- provide parameterized type for generics
- unused imports
- constructor visibility
- use compute() instead of containsKey()/put()
- make final fields static
- rename constants to all upper case
- no assert() in Thread.run() methods
- nested try
- nested if/else
- too many break/continue
- use try-with-resources
- repeatable annotations
- overlapping characters in reg ex
- hashcode is not sufficient in compareTo()
- need equals() with compareTo()
- make class an interface
- use parameterized test
- multiple calls in assert()
- log or re-throw
- use different type of lambda
- use parameterized logging
- use StringBuilder instead of concatenation
- use StandardCharsets.UTF_8
Issue-ID: POLICY-2906
Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This review fixes an issue identified during testing the changes done
for improving multiple policy handling in APEX.
Changes done to a few test files in the previous review are reverted as
well.
Change-Id: I98324da708239d314aadd4c45dc377137fd552ba
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: Ic4adf5bd8876dc31fc93993298e90389baaa2c39
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: I5df89d023949cdf0f649951dbbd81a0b30f44ef6
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2875
Change-Id: Ibb0e9a243bf92f0255cb5c145d31ccddb988fdf5
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: I5e2cd92ee3620dea4070d9fa3aeb5ffd65f9412c
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2839
Change-Id: Ia7c847b3dafd28958d5df209af95cac19fa480a0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
The legacy operational policy type for apex has been removed in Guilin release.
Removing it fron supported policy type and other places in apex-pdp.
Issue-ID: POLICY-2857
Change-Id: I41d58bf7e82292e11ff752f61dbe9be96a8a7af4
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7cde8197621ccc3d366baab952243c7b7894a29b
|
|
Change-Id: Idde5050b425eb1bebe312e80e795c21513367a1b
Issue-ID: POLICY-2789
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Legacy format support is removed, and Tosca format support is added.
Change-Id: I3cfc181ccb5471a5d224c0162af18c1fa0fdbc70
Issue-ID: POLICY-2812
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I1d36c28cfb07881ebede1cf918140397b076512c
Issue-ID: POLICY-2753
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Fixed the sonar issues relating to Printf format being used for logging
instead of String concatenation
Issue-ID: POLICY-2773
Change-Id: I38db8d1df077fd7102f6c4f9b33685f2914bd624
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Ensure assertions are present in test cases
Issue-ID: POLICY-2706
Change-Id: I3673a7668564401d2136450b0bdd7a013605dd7c
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
apex-pdp/testsuites
Replace assertTrue with assertEquals and assertFalse with
assertNotEquals in apex-pdp/model, apex-pdp/plugins, apex-pdp/services
and apex-pdp/testsuites
Issue-ID: POLICY-2690
Change-Id: If088371cf012d5648e04ade2aa4d49b38945f6d2
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
|
|
|
|
Replaced try/catch blocks with assertj assertions in apex-pdp. Last
batch of changes
Issue-ID: POLICY-2451
Change-Id: I39bd02fdbd8389818dcf1b786189c1e344ddcea5
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Issue-ID: POLICY-2695
Change-Id: I15b489de9ca2614e3a6c94b450a3d6397d17d4ff
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Change-Id: I0da222e592e6e29f0afca4a1515d8f126fe91cbb
Issue-ID: POLICY-2623
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issue-ID: POLICY-2188
Change-Id: I56bbf3aa3bd9e1ef433cc93ad2be0c54d141a2a5
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2514
Change-Id: I764cfe41ed8cf8ffebd4ff076d0b76b79d61e142
Signed-off-by: RossC <ross.carter@est.tech>
|
|
Issue-ID: POLICY-2514
Change-Id: I5b130b052150eb0e51759c751b83ab9d6f199759
Signed-off-by: RossC <ross.carter@est.tech>
|
|
Change-Id: Ic668ab20498bdc41edc78f52c7ce9d89a1385f19
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I59b93fccb0f3a41f8db753d1e8e2978bbb51e9a0
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6bd157d80a0aa1604e634ec561ee76e8197e97df
|
|
Change-Id: If76ddc860b67e0d8dcd4c48bacb5436ffc773faa
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
|
|
apex-pdp
Change-Id: I6de1fd31c2e73814a546b05ee71419fded4a3357
Issue-ID: POLICY-2147
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Currently APEX specific information is placed under properties|content in ToscaPolicy.
Avoid keeping under "content" and keep the information directly under properties.
Change-Id: Ic437271c9a2d71104013b5568af5525df4a4bb56
Issue-ID: POLICY-2332
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
This change brings in the minimum changes to get apex-pdp running in
Java 11. Other reviews will bring in changes to remove Java 11 warnings
and to convert apex-pdp Javascript handling from the now deprecated
nashorn engine.
Issue-ID: POLICY-1581
Change-Id: I879bbae08d4e67aca3f1bfeedeca639d8dbbc281
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Apex to populate the PdpStatistics data in every heartbeat sent to PAP
Issue-ID: POLICY-2302
Change-Id: I2d3a6c1e8605d53bf754a135980527bd50762abd
Signed-off-by: shaoqiu <tim.huang@est.tech>
|
|
|
|
|
|
Change-Id: If8167c837d7d28ec9049b00ff6ca314eb4199930
Issue-ID: POLICY-2279
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: Iafd2e2625cfabd89480ca1807eb1607788b30899
Issue-ID: POLICY-2235
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
The laest Eclipse checkstyle version 8.26.0 does more thorough checking
and identified a number of small issues in the apex-pdp codebase. This
review fixes those issues.
Issue-ID: POLICY-1913
Change-Id: I30ba25e3e425c6d54c77f925e8da3ab841a8357c
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: If0ad9c6b3a0f19ff3711d6230eb64e0dca1c1ef1
Issue-ID: POLICY-2272
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I6cff921bdc65fe505c0b5e7dba94a6cf9aa3ba91
Issue-ID: POLICY-2234
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I73fad5bf76ed6b4979f5ab76013f204ea82da30b
Issue-ID: POLICY-2215
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
There is no need to have Jersey dependencies in the PDP POMs as they are
inherited from the policy-endpoints POM.
Issue-ID: POLICY-2209
Change-Id: I5c53e7b29f4df25fd730f7a521e149e4ee70d964
Signed-off-by: liamfallon <liam.fallon@est.tech>
|