Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-2695
Change-Id: I15b489de9ca2614e3a6c94b450a3d6397d17d4ff
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Issue-ID: POLICY-2188
Change-Id: I56bbf3aa3bd9e1ef433cc93ad2be0c54d141a2a5
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2514
Change-Id: I764cfe41ed8cf8ffebd4ff076d0b76b79d61e142
Signed-off-by: RossC <ross.carter@est.tech>
|
|
Issue-ID: POLICY-2514
Change-Id: I5b130b052150eb0e51759c751b83ab9d6f199759
Signed-off-by: RossC <ross.carter@est.tech>
|
|
Change-Id: Ic668ab20498bdc41edc78f52c7ce9d89a1385f19
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Change-Id: I59b93fccb0f3a41f8db753d1e8e2978bbb51e9a0
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Integation unit tests resultd in StackOverflowException errors in the
Graal Javascript interpreter. Following extensive testing and
trouobleshooting, it proved very difficult to fix these issues in Graal
as the stck overflow errors were occurring in native class instantiation
methods being invoked by Grall on the JVM.
The alternative Rhino Javascript engine is developed by mozilla, and was
incorporated into the Java 6 JVM and evolved into Nashorn in the Java 8
JVM. Oracle dropped Nashorn in Java 11. However, in parallel, Rhino
development has continued.
This review brings in the Rhino javascript engine into apex-pdp as the
replacement for Nashorn and instead of Graal. Graal seems to be pretty
unstable as yet so we may bring it in in future releases but for now
Rhino is a more stable and reliable alternative.
Issue-ID: POLICY-2106
Change-Id: I0edeff3b0bee404b38e3ebe22001a6e3375a44dc
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
A number of Java 11, checkstyle, and SONAR warnings have crept into the
Apex codebase over the last number of reviews. This change fixes those
issues.
Issue-ID: POLICY-1913
Change-Id: I2afd607e80f48323355380fb2fe5e048e18879f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1861
Change-Id: Iccbdcbc5b5978305c56ab74c01a52a562697bee1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Logging dialled back in logback.xml files and on ligging statements in
unit test java code.
Issue-ID: POLICY-2272
Change-Id: I3b9a46d8993b1571c8dc62687a9c136af46c1f51
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: I73fad5bf76ed6b4979f5ab76013f204ea82da30b
Issue-ID: POLICY-2215
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Also added defaultbranch to the .gitreview file to make it easier
to change it when apex-pdp is branched in the future.
Issue-ID: POLICY-2045
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ib2570fd395aae38862299f2193b07ab06e32ace5
|
|
Issue-ID: POLICY-1965
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Icd437f10c4d991030652ffa1abf48b7b5738145c
|
|
Released 2.2.0
Issue-ID: POLICY-1737
Change-Id: I144a3c07d3eaf8c53d339eecedf2b3d8d3ce3c7e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Copyright headers not changed as this review only amends comments.
Issue-ID: POLICY-1791
Change-Id: Icbeb2c6e591b3b160ae102bb67aef2d407924a4d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: Ifcd8866e65a7bc1238d5a4137f7bad288a5bfb3b
Issue-ID: POLICY-1861
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Iba1c6a80917a37cc63e2250a32df40046df9ee4f
|
|
Issue-ID: POLICY-1630
Change-Id: I6dfce7eb33d9bc41caabf6b8842377b486de672d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change import line in all classes that use
the Assertions class, there are a lot of them.
Issue-ID: POLICY-1264
Change-Id: I8480264be4e36348b3fc63acf1bc36e9c9dd250b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
This review changes the versions of Zookeeper and C3P0 to
resolve security issues.
It also merges the context test utils module into the context test because that
module was misplaced and put an incompatible Zookeeper dependency in the
APEX context module.
Issue-ID: POLICY-1540
Change-Id: I86048ae1fc8b818611f423d6fd1f4a9fcc3f76f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Previous checkstyle fixes rationalised the
exceptions thrown by methods, however the javadoc
comments were not updated. This review updates them.
Issue-ID: POLICY-1263
Change-Id: I2746f30e76018ec4d0f1e74a6a415979b7874329
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1074
Change-Id: I88dc888b2a374b38499241f578a36dd116e2b85b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Some minor line length and formatting checkstyle warnings fixed.
Change-Id: Ib92069bbdb444560083e6d0dbf5d16a3ab824d82
Issue-ID: POLICY-1074
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The context flushing support in the context distributor can throw a
concurrent exception when a lot of context is active and a flush takes
place. This fix introduces proper synchronized access to the album maps.
In addition, there was an incorrect cast in the call to the persist() method
of the persistor.
Change-Id: I6594ffed83a0b34251a0c5c7893d4abb17437fd4
Issue-ID: POLICY-1380
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I1dc1a7f174660a90664ebdcff2ea79ed30aa465c
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Change-Id: Ibc07c20fa8ac1018443a3c061613fdaecc5efb83
Issue-ID: POLICY-1280
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Apex performance tests are refactored and reorganised
to be all in the one place and to be coherent.
A test REST server that can generate events in batches
is introduced and this can be configured to respond to REST
calls from Apex with various batch sizes that can be varied
for performance tests.
Actual performance tests are added for the various executors
in Apex.
Change-Id: I692b41e1e4451e821a618c64dead5cc8e9685d08
Issue-ID: POLICY-812
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Make test classes name consistence by putting 'Test' at end
Issue-ID: POLICY-1263
Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Issue-ID: POLICY-1232
Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-1213
Change-Id: I9187462aa470cff6ca7adc750c8a666bf8e15429
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Change-Id: I1ab9b9d9b0b8d1655301959d7d6b9ab3cc87eba3
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Pretty printing was set off, making debugging of JSON
messages more difficult.
Issue-ID: POLICY-954
Change-Id: Ifcc32cdba822f2bfc105c99cc3dc85ee05a89f6f
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
When an Avro object is created, nested sub avro objects
are not created automatically. This change allows
invocation of a method to create sub objects of Avro
objects.
Issue-ID: POLICY-954
Change-Id: Ie510867f2631ba6a8c6f5452c08aef5db67e8997
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
This code is covered by feature testing but does not
show up in Sonar. These unit tests give coverage on engine
modules.
Issue-ID: POLICY-1034
Change-Id: Ib7a288bcb9729ec88346cc8047e38f3a58f9a97c
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
JUnit test for test concepts.
Issue-ID: POLICY-1034
Change-Id: Ia2cd896272d4278d842d19d21237edcdca54a1f8
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Removed PowerMock from tests becasue coverage of PowerMock is not counted
by JaCoCO. It was easier to remove PowerMock than to try and hack the build
get PowerMock coverage counted.
Issue-ID: POLICY-1034
Change-Id: Ifc3e1ff93b2bfcb5619a5af6dec320d2de992f87
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Coverage for the client monitoring module.
Issue-ID: POLICY-1034
Change-Id: I6bb6dab26ce0572923c3d451a3b5f4745d40d088
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
In order to decode and encode complex Java POJOs with GSON,
type adapters must be specified. This change allows specification
of GSON type adapters for decoding and encoding of JSON in apex.
Issue-ID: POLICY-954
Change-Id: Ib402d4e82c4f22fa4d532c016f77fb8e7bb568d3
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Fixed some easy to resolve Sonar issues.
Issue-ID: POLICY-1034
Change-Id: Ia8e4606bd4307daca499b4a74c96135211e572fd
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Fixing various Sonar issues in apex.
Issue-ID: POLICY-1034
Change-Id: Ie693637d75bd7e38c71b7ba04886fb75636276ed
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Eclipse sonarlint does not check for exception dropping by default,
it must be configured. This commit addresses exception dropping in
apex.
Change-Id: I406838990b3424c2912124b25d7326502cacc96c
Issue-ID: POLICY-1034
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Sonar and Checkstyle changes in plugins and services, and
knock on changes
Issue-ID: POLICY-1034
Change-Id: Iff7df74e54fce2c661dcc2fae75ae93d4cacfe5b
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Checkstyle and sonar changes in the model, contexot
and core modules.
Issue-ID: POLICY-1034
Change-Id: I2d40bc877f3a548844470fc290fc89d63fa465ae
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Fix checkstyle warnings in the apex mode
and knock on changes.
Issue-ID: POLICY-1034
Change-Id: I10537e4288e9cad5ef18165ed2cdc1d3ab3139c1
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Modifications to apex parameters to include getters
that follow naming conventions, and knock on changes.
Also checkstyle fixes taken in modifified classes.
Issue-ID: POLICY-1095
Change-Id: Iff5ccc7a069a4ec2b2b974ed9f5ed70a88692e00
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
The examples are not packaged correctly in the apex build
and the client wars are missing
The links and location of the documents are corrected.
Some POM duplicate dependencies removed.
Javadoc warnings removed.
Issue-ID: POLICY-867
Change-Id: I555c29191c61c0a9887365d95005dbc584eddf04
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
CHeckstyle issues in apex model basic and knock on changes
in other apex modules.
Issue-ID: POLICY-1034
Change-Id: I65823f5e2e344526abc74b0812877113acb056ec
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Switch parameter handling in apex to use
the ONAP PF common parameter service
Change-Id: Id318d19c726b18b1a69c630fa81ca7d695355e9c
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Change-Id: I5b72c7a35d56296cd5053659a9d4c1e8f3b058be
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
|
|
Change-Id: I6d6e7bdc19e4e90f5f0a31ac3c8f06514ac10264
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
|