Fix sonars in apex-pdp #3

Fixed:
- use "var"
- use assertEquals instead of assertTrue(xxx.equals())
- separate assertions

Issue-ID: POLICY-3093
Change-Id: Id4db62626948681cd267e68a56dda65fa355c6f8
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/examples/examples-servlet/src/main/java/org/onap/policy/apex/examples/servlet/ApexServletListener.java b/examples/examples-servlet/src/main/java/org/onap/policy/apex/examples/servlet/ApexServletListener.java
index 80ef7354b..c1b7fbc11 100644
--- a/examples/examples-servlet/src/main/java/org/onap/policy/apex/examples/servlet/ApexServletListener.java
+++ b/examples/examples-servlet/src/main/java/org/onap/policy/apex/examples/servlet/ApexServletListener.java
@@ -1,6 +1,7 @@
 /*-
  * ============LICENSE_START=======================================================
  *  Copyright (C) 2018 Ericsson. All rights reserved.
+ *  Modifications Copyright (C) 2021 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -57,7 +58,7 @@ public class ApexServletListener implements ServletContextListener {
 
         // Check that a configuration file have been specified
         if (servletContextEvent.getServletContext().getInitParameter("config-file") == null) {
-            final String errorMessage =
+            final var errorMessage =
                     "Apex servlet start failed, servlet parameter \"config-file\" has not been specified";
             LOGGER.error("Apex servlet start failed, servlet parameter \"config-file\" has not been specified");
             throw new ApexRuntimeException(errorMessage);
@@ -89,8 +90,7 @@ public class ApexServletListener implements ServletContextListener {
             apexMain.shutdown();
             apexMain = null;
         } catch (final ApexException e) {
-            final String errorMessage = "Apex servlet stop did not execute normally";
-            LOGGER.error(errorMessage, e);
+            LOGGER.error("Apex servlet stop did not execute normally", e);
         }
 
         LOGGER.info("Apex Servliet has been stopped");