From 614f8f9a33ade5b523003c9f5aa7299f11fcfc19 Mon Sep 17 00:00:00 2001 From: anushadasari Date: Wed, 20 Nov 2019 15:57:35 +0530 Subject: Move "*" string literal on left side of string It is preferable to place string literals on the left-hand side of an equals() or equalsIgnoreCase() method call. Issue-ID: OPTFRA-647 Change-Id: Idd9ac257f96553a00f8a455a48d678adb167a382 Signed-off-by: anushadasari --- .../src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'cmso-optimizer/src') diff --git a/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java b/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java index 295221c..cda740f 100755 --- a/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java +++ b/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java @@ -158,7 +158,7 @@ public class AafUserRole { while (!inNodes.isEmpty() && !matchNodes.isEmpty()) { String inNode = inNodes.remove(0); String matchNode = matchNodes.get(0); - if (matchNode.equals(inNode) || matchNode.equals("*")) { + if (matchNode.equals(inNode) || "*".equals(matchNode)) { matchNodes.remove(0); } else { if (!matchNode.equals("**")) { @@ -174,10 +174,10 @@ public class AafUserRole { // We have incoming nodes remaining, see if we can wildcard them if (matchNodes.size() == 1) { - if (matchNodes.get(0).equals("**")) { + if ("**".equals(matchNodes.get(0))) { return true; } - if (inNodes.size() == 1 && matchNodes.get(0).equals("*")) { + if (inNodes.size() == 1 && "*".equals(matchNodes.get(0))) { return true; } } -- cgit 1.2.3-korg