From 7abd8c33af95f94bdbf21f372b372373c294e9f7 Mon Sep 17 00:00:00 2001 From: Guillaume Lambert Date: Mon, 26 Apr 2021 21:48:38 +0200 Subject: [COMMON] Fix condition bracket bashisms - step 2 pointed out by checkbashisms $ mycmd=$(tox -e checkbashisms | grep '(\[\[ foo \]\] should be \[ foo \])' | sed -e "s@^[^.]*\(.[^ ]*\) line \([0-9]*\) .*@sed -i '\2s/\\\[\\\[\\\( [^]]*\\\)\\\]\\\]/[\\\1]/g' \1;@") $ eval $mycmd plus fix manually quoting hells induced and bash specific regex and multi-conditions Issue-ID: OOM-2643 Signed-off-by: Guillaume Lambert Change-Id: Ia9626256b5efc837ba12b25d351c8d8a0ba75fb4 --- .../contrib/metallb-loadbalancer-inst/install-metallb-on-cluster.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'kubernetes/contrib/metallb-loadbalancer-inst') diff --git a/kubernetes/contrib/metallb-loadbalancer-inst/install-metallb-on-cluster.sh b/kubernetes/contrib/metallb-loadbalancer-inst/install-metallb-on-cluster.sh index 44fe79a0c6..bf2bc121a7 100755 --- a/kubernetes/contrib/metallb-loadbalancer-inst/install-metallb-on-cluster.sh +++ b/kubernetes/contrib/metallb-loadbalancer-inst/install-metallb-on-cluster.sh @@ -76,9 +76,11 @@ manual_configuration() { generate_config_map $@ } -if [[ $# -eq 1 ]] && [[ $1 = "-h" || $1 = "--help" ]]; then +if [ $# -eq 1 ] && [ "$1" = "-h" ]; then usage -elif [[ $# -eq 0 ]]; then +if [ $# -eq 1 ] && [ "$1" = "--help" ]; then + usage +elif [ $# -eq 0 ]; then automatic_configuration else manual_configuration $@ -- cgit 1.2.3-korg