From f2b9a04b5bc1f8c22cba4ba587f0526306d92ac8 Mon Sep 17 00:00:00 2001 From: Michal Zegan Date: Wed, 22 May 2019 15:52:37 +0200 Subject: Make molecule tests for certificates independent from docker role Currently molecule tests for certificates role call the docker role just to make one handler available. It actually breaks best practices of unit testing, the docker role shouldn't be called nor tested in unit test of certificates role. This commit makes certificates role independent by just creating fake handlers. Change-Id: Iec7934c7c1f4e9b37ff523e1d86a3beaaa88bdcf Issue-ID: OOM-1864 Signed-off-by: Michal Zegan --- ansible/roles/certificates/molecule/default/playbook.yml | 9 ++++++--- ansible/roles/certificates/molecule/default/prepare.yml | 5 ----- 2 files changed, 6 insertions(+), 8 deletions(-) delete mode 100644 ansible/roles/certificates/molecule/default/prepare.yml (limited to 'ansible') diff --git a/ansible/roles/certificates/molecule/default/playbook.yml b/ansible/roles/certificates/molecule/default/playbook.yml index 5dcd42ee..13583ebb 100644 --- a/ansible/roles/certificates/molecule/default/playbook.yml +++ b/ansible/roles/certificates/molecule/default/playbook.yml @@ -1,14 +1,17 @@ --- - name: Infra hosts: infrastructure + handlers: + - name: Restart Docker + debug: msg="Docker restart called" roles: - certificates - - docker # docker role needed here just because of docker restart handler - name: Kube hosts: kubernetes - roles: - - docker # docker role needed here just because of docker restart handler + handlers: + - name: Restart Docker + debug: msg="Docker restart called" tasks: - include_role: name: certificates diff --git a/ansible/roles/certificates/molecule/default/prepare.yml b/ansible/roles/certificates/molecule/default/prepare.yml deleted file mode 100644 index 8df759c9..00000000 --- a/ansible/roles/certificates/molecule/default/prepare.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -- name: Prepare infra - hosts: all - roles: - - prepare-docker -- cgit 1.2.3-korg