From 979a66083901482c457005a8c9f82c0366492499 Mon Sep 17 00:00:00 2001 From: Bartek Grzybowski Date: Fri, 17 Dec 2021 11:35:58 +0100 Subject: [ANSIBLE] Drop shell completion code generation in 'kubectl' role Moved to a dedicated role Change-Id: I9000403ff619a784c9a480d5de2eafe857c80d8f Issue-ID: OOM-2902 Signed-off-by: Bartek Grzybowski --- ansible/roles/kubectl/defaults/main.yml | 2 -- .../kubectl/molecule/default/tests/test_default.py | 12 ------------ ansible/roles/kubectl/tasks/main.yml | 22 ---------------------- 3 files changed, 36 deletions(-) (limited to 'ansible') diff --git a/ansible/roles/kubectl/defaults/main.yml b/ansible/roles/kubectl/defaults/main.yml index 5c2a4c69..b922fb58 100644 --- a/ansible/roles/kubectl/defaults/main.yml +++ b/ansible/roles/kubectl/defaults/main.yml @@ -1,4 +1,2 @@ --- kubectl_bin_dir: /usr/local/bin -completion_dir: /etc/bash_completion.d -completion_package: bash-completion diff --git a/ansible/roles/kubectl/molecule/default/tests/test_default.py b/ansible/roles/kubectl/molecule/default/tests/test_default.py index 3f4c7c7d..5d675fec 100644 --- a/ansible/roles/kubectl/molecule/default/tests/test_default.py +++ b/ansible/roles/kubectl/molecule/default/tests/test_default.py @@ -1,15 +1,3 @@ -import os - -import testinfra.utils.ansible_runner - -testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner( - os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all') - - def test_kubectl(host): assert host.file('/usr/local/bin/kubectl').exists assert host.run('kubectl').rc != 127 - - -def test_kubectl_bash_completion(host): - assert host.file('/etc/bash_completion.d/kubectl').exists diff --git a/ansible/roles/kubectl/tasks/main.yml b/ansible/roles/kubectl/tasks/main.yml index 03b9f9b0..7c77c3c5 100644 --- a/ansible/roles/kubectl/tasks/main.yml +++ b/ansible/roles/kubectl/tasks/main.yml @@ -5,25 +5,3 @@ dest: "{{ kubectl_bin_dir }}/kubectl" remote_src: true mode: 0755 - -- name: Install completion for the bash shell - package: - name: "{{ completion_package }}" - state: present - -- name: Generate shell autocompletion code for kubectl - command: kubectl completion bash - register: kubectl_completion - changed_when: false - -- name: Ensure bash completion dir exists - file: - path: "{{ completion_dir }}" - state: directory - mode: 0755 - -- name: Install bash autocompletion code for kubectl - copy: - content: "{{ kubectl_completion.stdout }}" - dest: "{{ completion_dir }}/kubectl" - mode: 0644 -- cgit 1.2.3-korg