From 2108abf11dd00f1190a7fb3630b8555381b616cf Mon Sep 17 00:00:00 2001
From: "r.bogacki" <r.bogacki@samsung.com>
Date: Tue, 19 Feb 2019 11:24:29 +0100
Subject: Fixed major Sonar issues in JsonDelete

Removed unnecessary imports.
Changed return type from ArrayList to List.

Change-Id: I9a17c9848b33be9f6ca5a2d51ee4b3f18abfcc38
Issue-ID: MUSIC-338
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
---
 .../onap/music/unittests/jsonobjects/JsonDeleteTest.java  | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

(limited to 'src/test')

diff --git a/src/test/java/org/onap/music/unittests/jsonobjects/JsonDeleteTest.java b/src/test/java/org/onap/music/unittests/jsonobjects/JsonDeleteTest.java
index 4c5af38f..a069b81d 100644
--- a/src/test/java/org/onap/music/unittests/jsonobjects/JsonDeleteTest.java
+++ b/src/test/java/org/onap/music/unittests/jsonobjects/JsonDeleteTest.java
@@ -4,6 +4,8 @@
  * ===================================================================
  *  Copyright (c) 2017 AT&T Intellectual Property
  * ===================================================================
+ *  Modifications Copyright (c) 2019 Samsung
+ * ===================================================================
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
@@ -25,25 +27,24 @@ package org.onap.music.unittests.jsonobjects;
 import static org.junit.Assert.*;
 import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.junit.Before;
 import org.junit.Test;
 import org.onap.music.datastore.jsonobjects.JsonDelete;
 
 public class JsonDeleteTest {
-    
+
     JsonDelete jd = null;
-    
+
     @Before
     public void init() {
         jd = new JsonDelete();
     }
-    
-    
+
     @Test
     public void testGetConditions() {
         Map<String,Object>  mapSo = new HashMap<>();
-        mapSo = new HashMap<>();
         mapSo.put("key1","one");
         mapSo.put("key2","two");
         jd.setConditions(mapSo);
@@ -53,7 +54,6 @@ public class JsonDeleteTest {
     @Test
     public void testGetConsistencyInfo() {
         Map<String,String>  mapSs = new HashMap<>();
-        mapSs = new HashMap<>();
         mapSs.put("key3","three");
         mapSs.put("key4","four");
         jd.setConsistencyInfo(mapSs);
@@ -62,8 +62,7 @@ public class JsonDeleteTest {
 
     @Test
     public void testGetColumns() {
-        ArrayList<String> ary = new ArrayList<>();
-        ary = new ArrayList<>();
+        List<String> ary = new ArrayList<>();
         ary.add("e1");
         ary.add("e2");
         ary.add("e3");
-- 
cgit 1.2.3-korg