From 49a5bf8abc9a1f69695ed1d1b22268871b49eb11 Mon Sep 17 00:00:00 2001
From: Arundathi Patil <arundpil@in.ibm.com>
Date: Tue, 13 Nov 2018 19:47:19 +0530
Subject: Sonar Fix:MusicServiceException,ReturnType

Fixed sonar isues/code-smells across this file

Issue-ID: MUSIC-180
Change-Id: I2ef2f6902b9d783a498c1fc69e383bc94f61fbc6
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
---
 .../music/exceptions/MusicServiceException.java    | 41 +++++++++++-----------
 src/main/java/org/onap/music/main/ReturnType.java  |  4 +--
 2 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/src/main/java/org/onap/music/exceptions/MusicServiceException.java b/src/main/java/org/onap/music/exceptions/MusicServiceException.java
index a3b1fc56..1f0264b3 100644
--- a/src/main/java/org/onap/music/exceptions/MusicServiceException.java
+++ b/src/main/java/org/onap/music/exceptions/MusicServiceException.java
@@ -32,26 +32,6 @@ public class MusicServiceException extends Exception {
     private int errorCode;
     private String errorMessage;
 
-    public int getErrorCode() {
-        return errorCode;
-    }
-
-
-    public void setErrorCode(int errorCode) {
-        this.errorCode = errorCode;
-    }
-
-
-    public String getErrorMessage() {
-        return errorMessage;
-    }
-
-
-    public void setErrorMessage(String errorMessage) {
-        this.errorMessage = errorMessage;
-    }
-
-
     public MusicServiceException() {
         super();
     }
@@ -76,9 +56,28 @@ public class MusicServiceException extends Exception {
 
 
     public MusicServiceException(String message, Throwable cause, boolean enableSuppression,
-                    boolean writableStackTrace) {
+                                 boolean writableStackTrace) {
         super(message, cause, enableSuppression, writableStackTrace);
 
     }
 
+    public int getErrorCode() {
+        return errorCode;
+    }
+
+
+    public void setErrorCode(int errorCode) {
+        this.errorCode = errorCode;
+    }
+
+
+    public String getErrorMessage() {
+        return errorMessage;
+    }
+
+
+    public void setErrorMessage(String errorMessage) {
+        this.errorMessage = errorMessage;
+    }
+
 }
diff --git a/src/main/java/org/onap/music/main/ReturnType.java b/src/main/java/org/onap/music/main/ReturnType.java
index 1453a1bf..33f68d7d 100644
--- a/src/main/java/org/onap/music/main/ReturnType.java
+++ b/src/main/java/org/onap/music/main/ReturnType.java
@@ -28,6 +28,8 @@ public class ReturnType {
     private ResultType result;
     private String message;
 
+    private String timingInfo;
+
     public ReturnType(ResultType result, String message) {
         super();
         this.result = result;
@@ -42,8 +44,6 @@ public class ReturnType {
         this.timingInfo = timingInfo;
     }
 
-    private String timingInfo;
-
     public ResultType getResult() {
         return result;
     }
-- 
cgit 1.2.3-korg