From 947aac66eb03dc62a5f93e798325a3ad30e3c10d Mon Sep 17 00:00:00 2001 From: Bartosz Gardziejewski Date: Tue, 21 Apr 2020 09:13:14 +0200 Subject: Resolve checkstyle warnings in PNF simulator Issue-ID: INT-1517 Signed-off-by: Bartosz Gardziejewski Change-Id: I43e9f129c24ef33d93b550600e4dd850f881126b --- .../simulator/client/HttpClientAdapterImplTest.java | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) (limited to 'pnfsimulator/src/test/java/org/onap/pnfsimulator/simulator/client/HttpClientAdapterImplTest.java') diff --git a/pnfsimulator/src/test/java/org/onap/pnfsimulator/simulator/client/HttpClientAdapterImplTest.java b/pnfsimulator/src/test/java/org/onap/pnfsimulator/simulator/client/HttpClientAdapterImplTest.java index 63c1b72..9eaab5c 100644 --- a/pnfsimulator/src/test/java/org/onap/pnfsimulator/simulator/client/HttpClientAdapterImplTest.java +++ b/pnfsimulator/src/test/java/org/onap/pnfsimulator/simulator/client/HttpClientAdapterImplTest.java @@ -26,7 +26,7 @@ import org.apache.http.conn.socket.PlainConnectionSocketFactory; import org.apache.http.conn.ssl.SSLConnectionSocketFactory; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -import org.onap.pnfsimulator.simulator.client.utils.ssl.SSLAuthenticationHelper; +import org.onap.pnfsimulator.simulator.client.utils.ssl.SslAuthenticationHelper; import java.io.IOException; import java.net.MalformedURLException; @@ -59,17 +59,18 @@ class HttpClientAdapterImplTest { } @Test - void sendShouldSuccessfullySendRequestGivenValidUrlUsingHTTPS() throws IOException { + void sendShouldSuccessfullySendRequestGivenValidUrlUsingHttps() throws IOException { assertAdapterSentRequest("https://valid-url:8443"); } @Test - void shouldThrowExceptionWhenMalformedVesUrlPassed(){ - assertThrows(MalformedURLException.class, () -> new HttpClientAdapterImpl("http://blablabla:VES-PORT", new SSLAuthenticationHelper())); + void shouldThrowExceptionWhenMalformedVesUrlPassed() { + assertThrows(MalformedURLException.class, () -> new HttpClientAdapterImpl("http://blablabla:VES-PORT", new SslAuthenticationHelper())); } + @Test - void shouldCreateAdapterWithClientNotSupportingSSLConnection() throws IOException, GeneralSecurityException { - HttpClientAdapter adapterWithHttps = new HttpClientAdapterImpl(HTTPS_URL, new SSLAuthenticationHelper()); + void shouldCreateAdapterWithClientNotSupportingSslConnection() throws IOException, GeneralSecurityException { + HttpClientAdapter adapterWithHttps = new HttpClientAdapterImpl(HTTPS_URL, new SslAuthenticationHelper()); try { adapterWithHttps.send("sample"); } catch (Exception actualException) { @@ -79,7 +80,7 @@ class HttpClientAdapterImplTest { @Test void shouldCreateAdapterWithClientSupportingPlainConnectionOnly() throws IOException, GeneralSecurityException { - HttpClientAdapter adapterWithHttps = new HttpClientAdapterImpl(HTTP_URL, new SSLAuthenticationHelper()); + HttpClientAdapter adapterWithHttps = new HttpClientAdapterImpl(HTTP_URL, new SslAuthenticationHelper()); try { adapterWithHttps.send("sample"); } catch (Exception actualException) { -- cgit 1.2.3-korg