From 4cc2f536708fc15d5c7aebcdbd28c475a26abc70 Mon Sep 17 00:00:00 2001 From: Michal Jagiello Date: Mon, 5 Feb 2024 13:01:24 +0100 Subject: Fix parameter types on some methods doc Some methods documentation had invalid parameters types what could be confusing for developers Issue-ID: TEST-404 Signed-off-by: Michal Jagiello Change-Id: I8def66fa7211d85f07b8d935e9fe39c4c029ecaf --- src/onapsdk/aai/business/service.py | 24 ++++++++++++------------ src/onapsdk/so/instantiation.py | 12 ++++++------ 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/onapsdk/aai/business/service.py b/src/onapsdk/aai/business/service.py index 49b94cd..87781a5 100644 --- a/src/onapsdk/aai/business/service.py +++ b/src/onapsdk/aai/business/service.py @@ -350,8 +350,8 @@ class ServiceInstance(Instance): # pylint: disable=too-many-instance-attributes def add_vnf(self, # pylint: disable=too-many-arguments vnf: "Vnf", - line_of_business: "LineOfBusiness", - platform: "Platform", + line_of_business: str, + platform: str, cloud_region: "CloudRegion" = None, tenant: "Tenant" = None, vnf_instance_name: str = None, @@ -365,8 +365,8 @@ class ServiceInstance(Instance): # pylint: disable=too-many-instance-attributes Args: vnf (Vnf): Vnf from service configuration to instantiate - line_of_business (LineOfBusiness): LineOfBusiness to use in instantiation request - platform (Platform): Platform to use in instantiation request + line_of_business (str): LineOfBusiness name to use in instantiation request + platform (str): Platform name to use in instantiation request cloud_region (CloudRegion, optional): Cloud region to use in instantiation request. Defaults to None. THAT PROPERTY WILL BE REQUIRED IN ONE OF THE FUTURE RELEASE. REFACTOR YOUR CODE @@ -422,8 +422,8 @@ class ServiceInstance(Instance): # pylint: disable=too-many-instance-attributes def add_pnf(self, # pylint: disable=too-many-arguments pnf: "Pnf", - line_of_business: "LineOfBusiness", - platform: "Platform", + line_of_business: str, + platform: str, pnf_instance_name: str = None, customer: "Customer" = None, service_subscription: "ServiceSubscription" = None, @@ -435,8 +435,8 @@ class ServiceInstance(Instance): # pylint: disable=too-many-instance-attributes Args: pnf (Pnf): Pnf from service configuration to instantiate - line_of_business (LineOfBusiness): LineOfBusiness to use in instantiation request - platform (Platform): Platform to use in instantiation request + line_of_business (str): LineOfBusiness name to use in instantiation request + platform (str): Platform name to use in instantiation request customer (Customer): Customer to use in instantiation request service_subscription(ServiceSubscription): ServiceSubscription pnf_instance_name (str): PNF instantiation name @@ -465,8 +465,8 @@ class ServiceInstance(Instance): # pylint: disable=too-many-instance-attributes def add_network(self, # pylint: disable=too-many-arguments network: "Network", - line_of_business: "LineOfBusiness", - platform: "Platform", + line_of_business: str, + platform: str, a_la_carte: bool = True, cloud_region: "CloudRegion" = None, tenant: "Tenant" = None, @@ -479,8 +479,8 @@ class ServiceInstance(Instance): # pylint: disable=too-many-instance-attributes Args: network (Network): Network from service configuration to instantiate - line_of_business (LineOfBusiness): LineOfBusiness to use in instantiation request - platform (Platform): Platform to use in instantiation request + line_of_business (str): LineOfBusiness name to use in instantiation request + platform (str): Platform name to use in instantiation request cloud_region (CloudRegion, optional): Cloud region to use in instantiation request. Defaults to None. THAT PROPERTY WILL BE REQUIRED IN ONE OF THE FUTURE RELEASE. REFACTOR YOUR CODE diff --git a/src/onapsdk/so/instantiation.py b/src/onapsdk/so/instantiation.py index b84e3a1..a75cec6 100644 --- a/src/onapsdk/so/instantiation.py +++ b/src/onapsdk/so/instantiation.py @@ -490,7 +490,7 @@ class VnfInstantiation(NodeTemplateInstantiation): # pylint: disable=too-many-a Args: vnf_object (Vnf): Vnf to instantiate - line_of_business_object (LineOfBusiness): LineOfBusiness to use in instantiation request + line_of_business_object (str): LineOfBusiness name to use in instantiation request platform_object (Platform): Platform to use in instantiation request cloud_region (CloudRegion): Cloud region to use in instantiation request. tenant (Tenant): Tenant to use in instnatiation request. @@ -553,7 +553,7 @@ class VnfInstantiation(NodeTemplateInstantiation): # pylint: disable=too-many-a Args: aai_service_instance (ServiceInstance): Service instance associated with request vnf_object (Vnf): Vnf to instantiate - line_of_business (LineOfBusiness): LineOfBusiness to use in instantiation request + line_of_business (str): LineOfBusiness name to use in instantiation request platform (Platform): Platform to use in instantiation request cloud_region (CloudRegion): Cloud region to use in instantiation request. tenant (Tenant): Tenant to use in instantiation request. @@ -639,7 +639,7 @@ class VnfInstantiation(NodeTemplateInstantiation): # pylint: disable=too-many-a vnf_object(VnfObject): vnf object operation_type (VnfOperation): name of the operation to trigger aai_service_instance (AaiService): Service Instance object from aai - line_of_business (LineOfBusiness): LineOfBusiness name to use + line_of_business (str): LineOfBusiness name to use in instantiation request platform (Platform): Platform name to use in instantiation request sdc_service (SdcService): Service model information @@ -817,7 +817,7 @@ class PnfInstantiation(NodeTemplateInstantiation): # pylint: disable=too-many-a Args: aai_service_instance (ServiceInstance): Service instance associated with request pnf_object (Pnf): Pnf to instantiate - line_of_business (LineOfBusiness): LineOfBusiness to use in instantiation request + line_of_business (str): LineOfBusiness name to use in instantiation request platform (Platform): Platform to use in instantiation request sdc_service(SdcService): service model to instantiate pnf_instance_name (str, optional): Pnf instance name. Defaults to None. @@ -1011,9 +1011,9 @@ class ServiceInstantiation(Instantiation): # pylint: disable=too-many-ancestors customer (Customer): Customer to use in instantiation request owning_entity (OwningEntity): Owning entity to use in instantiation request project (Project): Project name to use in instantiation request - line_of_business_object (LineOfBusiness): LineOfBusiness name to use + line_of_business (str): LineOfBusiness name to use in instantiation request - platform_object (Platform): Platform name to use in instantiation request + platform (str): Platform name to use in instantiation request aai_service (AaiService): Service object from aai sdc cloud_region (CloudRegion): Cloud region to use in instantiation request tenant (Tenant): Tenant to use in instantiation request -- cgit 1.2.3-korg