From 632c23e1bc6772b4471f8de19c761aaca909956a Mon Sep 17 00:00:00 2001 From: Gary Wu Date: Fri, 1 Sep 2017 12:45:12 -0700 Subject: Move version-check into integration repo Change-Id: Id3d3140ca20500970e470ca9ea32ca7329a5b1b9 Issue-ID: INT-124 Signed-off-by: Gary Wu --- version-manifest/pom.xml | 74 +++++++++++++ version-manifest/src/main/docker-manifest.csv | 1 + version-manifest/src/main/java-manifest.csv | 2 + .../oparent/versioncheck/VersionCheckMojo.java | 121 +++++++++++++++++++++ version.properties | 14 +++ versions/docker-manifest.csv | 1 - versions/java-manifest.csv | 2 - 7 files changed, 212 insertions(+), 3 deletions(-) create mode 100644 version-manifest/pom.xml create mode 100644 version-manifest/src/main/docker-manifest.csv create mode 100644 version-manifest/src/main/java-manifest.csv create mode 100644 version-manifest/src/main/java/org/onap/oparent/versioncheck/VersionCheckMojo.java create mode 100644 version.properties delete mode 100644 versions/docker-manifest.csv delete mode 100644 versions/java-manifest.csv diff --git a/version-manifest/pom.xml b/version-manifest/pom.xml new file mode 100644 index 000000000..11318e612 --- /dev/null +++ b/version-manifest/pom.xml @@ -0,0 +1,74 @@ + + + 4.0.0 + + org.onap.oparent + version + 0.1.0 + + org.onap.integration + version-manifest + maven-plugin + ONAP Version Manifest and Maven Plugin + https://www.onap.org + + UTF-8 + 3.2.3 + + + + org.apache.maven + maven-plugin-api + 2.0 + + + org.apache.maven.plugin-tools + maven-plugin-annotations + 3.2 + provided + + + org.codehaus.plexus + plexus-utils + 3.0.8 + + + org.apache.maven + maven-core + ${mavenVersion} + + + + org.apache.commons + commons-csv + 1.4 + + + + + + org.apache.maven.plugins + maven-plugin-plugin + 3.2 + + version-check + true + + + + mojo-descriptor + + descriptor + + + + help-goal + + helpmojo + + + + + + + diff --git a/version-manifest/src/main/docker-manifest.csv b/version-manifest/src/main/docker-manifest.csv new file mode 100644 index 000000000..dba913291 --- /dev/null +++ b/version-manifest/src/main/docker-manifest.csv @@ -0,0 +1 @@ +image,tag diff --git a/version-manifest/src/main/java-manifest.csv b/version-manifest/src/main/java-manifest.csv new file mode 100644 index 000000000..8baa86884 --- /dev/null +++ b/version-manifest/src/main/java-manifest.csv @@ -0,0 +1,2 @@ +groupId,artifactId,version +org.onap.oparent,oparent,0.1.0 diff --git a/version-manifest/src/main/java/org/onap/oparent/versioncheck/VersionCheckMojo.java b/version-manifest/src/main/java/org/onap/oparent/versioncheck/VersionCheckMojo.java new file mode 100644 index 000000000..0bb94f2d6 --- /dev/null +++ b/version-manifest/src/main/java/org/onap/oparent/versioncheck/VersionCheckMojo.java @@ -0,0 +1,121 @@ +/* + * Copyright 2017 Huawei Technologies, Ltd. and others. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.onap.oparent.versioncheck; + +import java.io.IOException; +import java.io.InputStreamReader; +import java.net.MalformedURLException; +import java.net.URI; +import java.nio.charset.StandardCharsets; +import java.util.HashMap; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Set; +import java.util.TreeSet; + +import org.apache.commons.csv.CSVFormat; +import org.apache.commons.csv.CSVRecord; +import org.apache.maven.model.Dependency; +import org.apache.maven.plugin.AbstractMojo; +import org.apache.maven.plugin.MojoExecutionException; +import org.apache.maven.plugin.logging.Log; +import org.apache.maven.plugins.annotations.LifecyclePhase; +import org.apache.maven.plugins.annotations.Mojo; +import org.apache.maven.plugins.annotations.Parameter; +import org.apache.maven.project.MavenProject; + +@Mojo(name = "version-check", defaultPhase = LifecyclePhase.PROCESS_SOURCES) +public class VersionCheckMojo extends AbstractMojo { + + /** + * The Maven Project. + * + * @since 1.0-alpha-1 + */ + @Parameter(defaultValue = "${project}", required = true, readonly = true) + protected MavenProject project; + + /** + * Location of the file. + */ + @Parameter(property = "manifestUri", required = true) + private URI manifestUri; + + public void execute() throws MojoExecutionException { + final Log log = getLog(); + + log.info("Checking version manifest " + manifestUri); + + Map expectedVersions = new HashMap<>(); + + try (InputStreamReader in = new InputStreamReader(manifestUri.toURL().openStream(), + StandardCharsets.ISO_8859_1)) { + Iterable records = CSVFormat.DEFAULT.withFirstRecordAsHeader().parse(in); + for (CSVRecord record : records) { + String groupId = record.get("groupId"); + String artifactId = record.get("artifactId"); + String version = record.get("version"); + log.debug("Expected version: " + groupId + ":" + artifactId + ":" + version); + expectedVersions.put(groupId + ":" + artifactId, version); + } + } catch (MalformedURLException e) { + log.error(e); + throw new MojoExecutionException(e.getMessage()); + } catch (IOException e) { + log.error(e); + throw new MojoExecutionException(e.getMessage()); + } + + Map actualVersions = new HashMap<>(); + MavenProject parent = project.getParent(); + if (parent != null) { + log.debug("Parent: " + parent); + actualVersions.put(parent.getGroupId() + ":" + parent.getArtifactId(), parent.getVersion()); + } else { + log.debug("No parent"); + } + + for (Dependency dep : project.getDependencies()) { + log.debug("Dependency: " + dep.toString()); + actualVersions.put(dep.getGroupId() + ":" + dep.getArtifactId(), dep.getVersion()); + } + + Set mismatches = new TreeSet<>(); + for (Entry expected : expectedVersions.entrySet()) { + String artifact = expected.getKey(); + String expectedVersion = expectedVersions.get(artifact); + String actualVersion = actualVersions.get(artifact); + if (actualVersion != null && !actualVersion.equals(expectedVersion)) { + mismatches.add(artifact); + } + } + + if (mismatches.isEmpty()) { + log.debug("No version mismatches found"); + } else { + log.warn("The following dependencies should be updated to match the version manifest:"); + for (String artifact : mismatches) { + String expectedVersion = expectedVersions.get(artifact); + String actualVersion = actualVersions.get(artifact); + if (actualVersion != null && !actualVersion.equals(expectedVersion)) { + log.warn(" " + artifact + " " + actualVersion + " -> " + expectedVersion); + } + } + } + + } +} diff --git a/version.properties b/version.properties new file mode 100644 index 000000000..f841ab77d --- /dev/null +++ b/version.properties @@ -0,0 +1,14 @@ +########################################################### +# Versioning variables +# Note that these variables cannot be structured (e.g. : version.release or version.snapshot etc... ) +# because they are used in Jenkins, whose plug-in doesn't support + +major_version=0 +minor_version=1 +patch_version=0 + +base_version=${major_version}.${minor_version}.${patch_version} + +# Release must be completed with GIT information # in Jenkins +release_version=${base_version} +snapshot_version=${base_version}-SNAPSHOT \ No newline at end of file diff --git a/versions/docker-manifest.csv b/versions/docker-manifest.csv deleted file mode 100644 index dba913291..000000000 --- a/versions/docker-manifest.csv +++ /dev/null @@ -1 +0,0 @@ -image,tag diff --git a/versions/java-manifest.csv b/versions/java-manifest.csv deleted file mode 100644 index 8baa86884..000000000 --- a/versions/java-manifest.csv +++ /dev/null @@ -1,2 +0,0 @@ -groupId,artifactId,version -org.onap.oparent,oparent,0.1.0 -- cgit 1.2.3-korg