aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-05-11Improve code testabilityBartek Grzybowski3-155/+181
A module is created with specific class methods to perform particular simulator services' lifecycle operations. Change-Id: I467360ab304a00f049bf53c3958e42f445f2d75b Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-11Allow importing the script as moduleBartek Grzybowski1-189/+196
Improves testability (TBD) Change-Id: I0c4845f85d14b49b4702270ffad537a19c1c7df7 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-11Rework input parameters handlingBartek Grzybowski3-45/+55
Main input options were turned into subcommands for improved CLI user experience. Input parameters handling and validation logic was moved out of the code to argparse native facilities. Updated the doc around script usage details. Change-Id: Ifaa2a0e49f2a0b5b677020307dc74942c422bbe1 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-08update vCPE local casezhaoliping1232-13/+32
Issue-ID: INT-1355 Change-Id: I3172f1aacebc7f226472dac1259d35c50f520473 Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
2020-05-08Add missing dependency for port scanningPawel Wieczorek1-0/+7
Issue-ID: SECCOM-261 Change-Id: Id4d14cf0997310b7e039fe3f5e18ea72a4f3d71c Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-05-08Use correct nmap filtersPawel Wieczorek1-1/+11
Both closed and filtered ports should be droppped from scan results to maintain compatibility with "check_for_nonssl_endpoints.sh" script. Issue-ID: SECCOM-261 Change-Id: Ic422bebf6e46bcc42a3e5198e7702bb8b901287f Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-05-08Exclude code location from code base URLPawel Wieczorek1-5/+6
Python method str.format allows easy templating using substitutions identified by braces ('{' and '}'). Using two levels of nested substitutions can be achieved by doubling braces ("{{" and "}}"). Hound configuration creator script was supposed to use two levels of nested substitutions and still leave braced components within the templated string for further substitution by the Hound tool. This would require using multitude of braces which would decrease readability significantly. This is why code location template is appended to the code base URL at the latest. If there will be need for more levels of nested templates, this code shall be further refactored to use only named fields, str.format_map() (available in Python 3.2+) and SafeDict, e.g. >>> class SafeDict(dict): ... def __missing__(self, key): ... return '{' + key + '}' ... which would leave braced components within the processed template in case given key is missing. Issue-ID: ONAPARC-579 Change-Id: I420d076867aa891edb2a945a8cd58e168c892ac3 Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
2020-05-08Refactor simulator instances IP setting logicBartek Grzybowski2-31/+38
Change-Id: I5bd36b364cd033d0d468c81f345be9255e7adb85 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-08Fix services IP addresses namingBartek Grzybowski1-22/+25
Use formatted string literals to make the code more readable. Change-Id: I712f887d73c29aacc5766052835f377a63e9eb06 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-08Drop superfluous variables and type castsBartek Grzybowski1-13/+10
Change-Id: Ic8e9eab90c537584b2c771bdeb59c0b43deb992e Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-08Supress ANSI escape sequences when terminal not detectedBartek Grzybowski1-2/+6
This prevents obscured output when redirecting output to a file descriptor. Change-Id: Ie56b6f65b1d2adffc69d3f75a9c8f98c0444faa8 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-07Fixed vFWDT do after modifications in OOF for policyLukasz Rajewski1-71/+10
Modified description of procedure to upload polcies used for TD procedure and OOF. Change-Id: I6e3760f2d2308a36388971e66280df3d3d35f224 Issue-ID: INT-1277 Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
2020-05-07Add policy and sdc staging images overridesjhh2-0/+32
Issue-ID: INT-1585 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia2682bc293ea403b56d3f4d27d6a1c219e6e90eb
2020-05-05Make script verbosity adjustibleBartek Grzybowski1-22/+30
Adds '--verbose' option and leverages 'logging' module facilities. Change-Id: I9b079c476949788678167afb1ed115ad4490d99c Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-05Add input opts description in usage synopsisBartek Grzybowski1-10/+12
Change-Id: I43b1c47509afef0f25176e244ab2f6f565afbc3b Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-05Leverage ArgumentParser facilities for input options validationBartek Grzybowski1-27/+28
The hassle of casting and validating input options values is moved from the script logic directly into the ArgumentParser's object instantiation. Change-Id: I79ed80286d1219f841d496538acdc50d2113d723 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-05Add helper functions for input options validationBartek Grzybowski2-0/+22
Change-Id: I0c8cd452fbf740f3b1c7988bf7aa7341a747c75e Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-03Rephrase the argparse arguments help messagesBartek Grzybowski1-61/+13
Show usage if no option provided. Change-Id: I1ed01464f4b689e6b716887e7719e8de6c0f1e42 Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-03Kill the 'sleep' process as wellBartek Grzybowski1-1/+1
ROP_file_creator.sh spawns 'sleep' cmd as a child hence it needs to be killed as well on clean up. Change-Id: Ic2007e710b6efa0028ebd239f26b7eff6a9e04ea Issue-ID: INT-1577 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-05-04pnf-sw-upgrade: fix lock-protected update of yang moduleebo1-54/+50
The update must be scoped by a lock on yang module Other changes: - 'action' field no longer deleted; handling CREATED/MODIFIED events on this field - Configurable delay on timed-transitions via SWUG_TIMED_TRANSITION_TO environment variable Issue-ID: INT-1516 Change-Id: I22fb7b558ae371b6cff487633eae606f8fe535e1 Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-05-01update the integration doc for vCPEzhaoliping1236-12/+18
Issue-ID: VFC-1668 Change-Id: Id66215e9b12a5aa5ac8d99ab734bd51c0bb3b1fc Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
2020-04-30Add csa as binary in .gitattributesmrichomme1-0/+1
Issue-ID: INT-1572 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: If307c3028372fc729aa848ff8d2b4042442aa313 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-29update the integration doc for vCPEzhaoliping12316-102/+125
Issue-ID: VFC-1668 Change-Id: I5fc41873f7a31e4c67669ea8bb07b674bc434cec Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
2020-04-29update docs_vCPE_tosca_local.rstzhaoliping1231-8/+8
Issue-ID: INT-1285 Change-Id: I6a365b56207ae3d21e8a6601f1110914d841160c Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
2020-04-28Documentation for vFW In-Place Upgrade with TDLukasz Rajewski10-194/+383
The documentation for vFW Traffic Distributino use case evolves to vFW InPlace Upgrade with TD one. There is changed description of the use case purpose, the workflow, the configuration procedure and information about the way of testing. Change-Id: I1e68d46871864b4e65df553355b3a11d86b4c9cb Issue-ID: INT-1277 Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
2020-04-27Exclude VFC-redis from xfail listmrichomme1-0/+1
Issue-ID: INT-1564 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I32d9e25e4d4d0bfab7fdfa5979db266a0826604c Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-23[INT] updating aks install w/ master passstark, steven9-14/+28
- Also updating openstack cli to py3 to fix import issues Issue-ID: INT-1557 Signed-off-by: stark, steven <steven.stark@att.com> Change-Id: I99cbc68614e0fcc8fd0572fd7c44c7cd431b215b
2020-04-22Add vcpe tosca local mode casezhaoliping12318-4/+898
- fix json errors - fix not related rst error (due to a broken link as jira.opnfv.org is no more responding) Issue-ID: INT-1285 Change-Id: I733a491c4204334fc532abcf9dbbdc2226900d5b Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com> Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-20Leverage pytest parametrize mark in test_rest_api_endpointsBartek Grzybowski1-34/+17
Change-Id: Ia29f79227e21e623489a7b340496f18def5f7a52 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-20Leverage pytest parametrize mark in test_bad_prefix testBartek Grzybowski1-21/+13
Change-Id: I0c0ea8612e0f0ac6b2198dc78908bd604f5ad61c Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-20Leverage pytest parametrize mark in test_bad_moi_class testBartek Grzybowski1-19/+8
Change-Id: I7218c5ca61669197d1e79189e841b0062524c02d Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-20Refactor test_unauthorized() to leverage pytest parametrize markBartek Grzybowski1-18/+11
Change-Id: I52079b276332c0bf2ffcea047ab8129066aff185 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-20Resize CLAMP pictureMarco Platania1-0/+0
Issue-ID: INT-1536 Signed-off-by: Marco Platania <platania@research.att.com> Change-Id: I27a213493377c4af80f914f3d8983b6d37ee6da1
2020-04-20netconf-pnp-simulator: fix sysrepod crash on TLS reconfigebo21-20/+527
The crash was caused by: - the '--permanent' option while updating the ietf-keystore by sysrepocfg - missing some Yang modules on sysrepo installation Other changes: 1. Added TLS integration tests, including reconfiguration 2. reconfigure-*.sh are now synchronous, only returnig after restart is completed Issue-ID: INT-1516 Change-Id: Iddc03fc968aaab60931596045437ba0c78448b08 Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-04-18Fix link in RST file for Scale Out docMarco Platania27-44/+63
Issue-ID: INT-1536 Signed-off-by: Marco Platania <platania@research.att.com> Change-Id: Ic16b339332033cd487cf19458464c1dc86c61d65 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-16Add test to verify bad API prefix handling by the serviceBartek Grzybowski2-0/+33
Functional test for verifying that the service handles bad API prefix in URI string properly and returns appropriate response to the client. Change-Id: I5e5e8a9dcd6fe05bd2b4536790d16e825aa21679 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Add test to verify bad MOI handling by the serviceBartek Grzybowski2-0/+30
Functional test for verifying that the service handles bad MOI class in URI string properly and returns appropriate response to the client. Change-Id: I606aaba5c400f81e8142a34f250bc249251feaf7 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Add test to verify unauthorized requestsBartek Grzybowski3-1/+27
Functional test for verifying that the service forbids API access with proper http code and message should the client provide wrong auth credentials. Change-Id: I78d5f050e99c23fd7116468ff007078b3cd56987 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Fix invalid prefix check handlingBartek Grzybowski1-20/+28
Should the URI prefix length in the request be incorrect and not contain two "/" the service would fail with "empty response" on client side due to unhandled "list index out of range" in the server process while trying to get the idName from pathlist[4] which throws IndexError. Prefix validation, id and class variable assignment are wrapped up in try-except clause to evaluate the prefix check correctly, catch the exception and return appropriate response to the client. Change-Id: If6333228fbdd3a8075ade55436c3ca9bb8a97caa Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-16Return http 404 for wrong prefix, not 401Bartek Grzybowski1-4/+8
The correct http code for wrong REST API url should be http "404 Not Found", not "401 Unauthorized". Change-Id: I78710fcd4c43926dbba3227c4099bf6239095f19 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Move tests to their own directoryBartek Grzybowski9-24/+30
File layout was also restructured for better readability. Change-Id: Id1cba755127319c45ec50b08d12daa543c8c9ae5 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Add tox runner for pytest in prov-mns-providerBartek Grzybowski2-0/+12
Pytest setup as entrypoint to gating job in CI. Change-Id: If052af0f7c8272844f644cb3789dbc3a8451c629 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Extend unit tests for provisioning management serviceBartek Grzybowski1-0/+25
This adds additional unit tests for the service provider for PATCH and DELETE request methods. Change-Id: If0cce9c713f2999c859910661308c24ac68f04d6 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Add unit tests for provisioning management serviceBartek Grzybowski1-0/+49
This adds pytest based unit tests for the service provider. Testing PUT and GET requests is covered within this patch. Change-Id: Id9bcb870b032c6fce64985a5fd501bbd44031f50 Issue-ID: INT-1529 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-15Fix rst errorsmrichomme18-70/+76
- Modify the linter to use sphinx linters (no coala bean) - Fix all broken links - fix minor rst issue - Add regex in ignore link (for ONAP URL and frankfurt doc) The rst target defined in tox will execute 3 steps: - local build of the documentation - check of the url Note 1: for the moment the Warning have not been turned into Error Note 2: frankfurt exeption shall be removed when frankfurt branch is available Issue-ID: INT-1523 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I6d7ad9d293a1b5c01f05a021d9a6f3767d04e62f Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-15netconf-pnp-simulator: enable NETCONF send/recv message loggingebo20-77/+717
to aid troubleshooting integration with OpenDaylight - Add more integration tests - Defaults to generic subscriber Issue-ID: INT-1516 Change-Id: Ib5bbf4cdbba6cdfee901f6c07dfa195a21cd8bbb Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-04-15Upgrade netconf-pnp-simulator image tag to 2.8.2Bartek Grzybowski4-4/+4
Change-Id: I430b3c8743d103f5e4bb6396a151495cc31843d6 Issue-ID: INT-1508 Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
2020-04-14Fix integration markdown errors for lintermrichomme19-364/+371
Issue-ID: INT-1523 Signed-off-by: mrichomme <morgan.richomme@orange.com> Change-Id: I2be0865395b12e1f277834b0c096f5d183cb5056 Signed-off-by: mrichomme <morgan.richomme@orange.com>
2020-04-14netconf-pnp-simulator: normalized image referenceebo2-4/+2
Required change for the forthcoming fix on tox execution in ci-management/jjb/integration/integration-docker.yaml Issue-ID: INT-1124 Change-Id: I70c3351e5cf691a9eaeb7b49ec276d825016e0fa Signed-off-by: ebo <eliezio.oliveira@est.tech>
2020-04-14netconf-pnp-simulator: fix invalid ref to libssh v0.8.8ebo2-6/+5
This version was upgraded to 0.8.9 on 2020-04-09. Fortunately the new 0.9.4 fixes the bug that was forcing us to use the old 0.8.x Issue-ID: INT-1124 Change-Id: I6dacac8925af047d2e5342a76da6eb221074ddd9 Signed-off-by: ebo <eliezio.oliveira@est.tech>