From c85baa839785a9bd02bc33e4302ac739dd5567c3 Mon Sep 17 00:00:00 2001 From: GuangrongFu Date: Fri, 17 Aug 2018 16:27:07 +0800 Subject: Added UT Codes Change-Id: I0f01e2ad4dde38e50231e3b5afef4786ccd0c54c Issue-ID: HOLMES-159 Signed-off-by: GuangrongFu --- .../holmes/rulemgt/send/RuleAllocationTest.java | 118 ------------ .../holmes/rulemgt/send/RuleAllocatorTest.java | 213 +++++++++++++++++++++ 2 files changed, 213 insertions(+), 118 deletions(-) delete mode 100644 rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocationTest.java create mode 100644 rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocatorTest.java (limited to 'rulemgt/src/test') diff --git a/rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocationTest.java b/rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocationTest.java deleted file mode 100644 index 696e32a..0000000 --- a/rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocationTest.java +++ /dev/null @@ -1,118 +0,0 @@ -/** -* Copyright 2017 ZTE Corporation. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -package org.onap.holmes.rulemgt.send; - - -import org.easymock.EasyMock; -import org.glassfish.hk2.api.ServiceLocator; -import org.junit.After; -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.onap.holmes.common.dropwizard.ioc.utils.ServiceLocatorHolder; -import org.onap.holmes.common.utils.DbDaoUtil; -import org.onap.holmes.rulemgt.bolt.enginebolt.EngineWrapper; -import org.onap.holmes.rulemgt.db.CorrelationRuleDao; -import org.onap.holmes.rulemgt.msb.EngineIpList; -import org.onap.holmes.rulemgt.wrapper.RuleMgtWrapper; -import org.onap.holmes.rulemgt.wrapper.RuleQueryWrapper; -import org.powermock.api.easymock.PowerMock; -import org.powermock.core.classloader.annotations.PrepareForTest; -import org.powermock.modules.junit4.PowerMockRunner; -import org.powermock.reflect.Whitebox; - -import java.util.ArrayList; -import java.util.List; - -import static org.hamcrest.core.IsEqual.equalTo; -import static org.junit.Assert.assertThat; - -@RunWith(PowerMockRunner.class) -@PrepareForTest({ServiceLocator.class, RuleMgtWrapper.class, RuleQueryWrapper.class, EngineWrapper.class, - EngineIpList.class, DbDaoUtil.class, RuleAllocation.class, ServiceLocatorHolder.class}) -public class RuleAllocationTest { - - @Before - public void prepare() { - - ServiceLocator locator = PowerMock.createMock(ServiceLocator.class); - RuleMgtWrapper ruleMgtWrapper = PowerMock.createMock(RuleMgtWrapper.class); - RuleQueryWrapper ruleQueryWrapper = PowerMock.createMock(RuleQueryWrapper.class); - EngineWrapper engineWrapper = PowerMock.createMock(EngineWrapper.class); - EngineIpList engineIpList = PowerMock.createMock(EngineIpList.class); - CorrelationRuleDao correlationRuleDao = PowerMock.createMock(CorrelationRuleDao.class); - DbDaoUtil daoUtil = PowerMock.createMock(DbDaoUtil.class); - PowerMock.mockStatic(ServiceLocatorHolder.class); - - EasyMock.expect(ServiceLocatorHolder.getLocator()).andReturn(locator); - EasyMock.expect(locator.getService(RuleMgtWrapper.class)).andReturn(ruleMgtWrapper); - EasyMock.expect(locator.getService(RuleQueryWrapper.class)).andReturn(ruleQueryWrapper); - EasyMock.expect(locator.getService(EngineWrapper.class)).andReturn(engineWrapper); - EasyMock.expect(locator.getService(EngineIpList.class)).andReturn(engineIpList); - EasyMock.expect(locator.getService(DbDaoUtil.class)).andReturn(daoUtil); - EasyMock.expect(daoUtil.getJdbiDaoByOnDemand(CorrelationRuleDao.class)).andReturn(correlationRuleDao); - try { - EasyMock.expect(engineIpList.getServiceCount()).andReturn(new ArrayList()); - } catch (Exception e) { - // Do nothing - } - - - PowerMock.replayAll(); - - } - - @After - public void destroy() { - PowerMock.resetAll(); - } - - @Test - public void extendCompareIpTest() throws Exception{ - RuleAllocation ruleAllocation = new RuleAllocation(); - - List newList = new ArrayList<>(); - newList.add("10.96.33.34"); - newList.add("10.74.65.24"); - - List oldList = new ArrayList<>(); - oldList.add("10.96.33.34"); - List extendIp = Whitebox.invokeMethod(ruleAllocation,"extendCompareIp",newList,oldList); - - PowerMock.verifyAll(); - - assertThat(extendIp.get(0),equalTo("10.74.65.24")); - } - - @Test - public void destroyCompareIpTest() throws Exception{ - RuleAllocation ruleAllocation = new RuleAllocation(); - - List newList = new ArrayList<>(); - newList.add("10.96.33.34"); - - List oldList = new ArrayList<>(); - oldList.add("10.96.33.34"); - oldList.add("10.74.65.24"); - List destoryIp = Whitebox.invokeMethod(ruleAllocation,"destroyCompareIp",newList,oldList); - - PowerMock.verifyAll(); - - assertThat(destoryIp.get(0),equalTo("10.74.65.24")); - } - -} diff --git a/rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocatorTest.java b/rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocatorTest.java new file mode 100644 index 0000000..1815ebb --- /dev/null +++ b/rulemgt/src/test/java/org/onap/holmes/rulemgt/send/RuleAllocatorTest.java @@ -0,0 +1,213 @@ +/** + * Copyright 2017 ZTE Corporation. + *

+ * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + *

+ * http://www.apache.org/licenses/LICENSE-2.0 + *

+ * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.onap.holmes.rulemgt.send; + + +import org.easymock.EasyMock; +import org.glassfish.hk2.api.ServiceLocator; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; +import org.junit.runner.RunWith; +import org.onap.holmes.common.api.entity.CorrelationRule; +import org.onap.holmes.common.dropwizard.ioc.utils.ServiceLocatorHolder; +import org.onap.holmes.common.utils.DbDaoUtil; +import org.onap.holmes.rulemgt.bolt.enginebolt.EngineWrapper; +import org.onap.holmes.rulemgt.db.CorrelationRuleDao; +import org.onap.holmes.rulemgt.msb.EngineInsQueryTool; +import org.onap.holmes.rulemgt.wrapper.RuleMgtWrapper; +import org.onap.holmes.rulemgt.wrapper.RuleQueryWrapper; +import org.powermock.api.easymock.PowerMock; +import org.powermock.core.classloader.annotations.PrepareForTest; +import org.powermock.modules.junit4.PowerMockRunner; +import org.powermock.reflect.Whitebox; + +import java.util.ArrayList; +import java.util.Calendar; +import java.util.Collections; +import java.util.List; +import java.util.stream.Collectors; + +import static org.hamcrest.core.IsEqual.equalTo; +import static org.junit.Assert.assertThat; +import static org.onap.holmes.rulemgt.send.RuleAllocator.ENABLE; + +@RunWith(PowerMockRunner.class) +@PrepareForTest({ServiceLocator.class, RuleMgtWrapper.class, RuleQueryWrapper.class, EngineWrapper.class, + EngineInsQueryTool.class, DbDaoUtil.class, RuleAllocator.class, ServiceLocatorHolder.class}) +public class RuleAllocatorTest { + + @Rule + public ExpectedException thrown = ExpectedException.none(); + + private RuleMgtWrapper ruleMgtWrapperMock; + private RuleQueryWrapper ruleQueryWrapperMock; + private EngineWrapper engineWrapperMock; + private EngineInsQueryTool engineInsQueryToolMock; + private DbDaoUtil dbDaoUtilMock; + private CorrelationRuleDao correlationRuleDaoMock; + + private List rules; + private List existingIps; + + @Before + public void before() { + PowerMock.mockStatic(ServiceLocatorHolder.class); + ServiceLocator locator = PowerMock.createMock(ServiceLocator.class); + EasyMock.expect(ServiceLocatorHolder.getLocator()).andReturn(locator); + + ruleMgtWrapperMock = PowerMock.createMock(RuleMgtWrapper.class); + ruleQueryWrapperMock = PowerMock.createMock(RuleQueryWrapper.class); + engineWrapperMock = PowerMock.createMock(EngineWrapper.class); + engineInsQueryToolMock = PowerMock.createMock(EngineInsQueryTool.class); + dbDaoUtilMock = PowerMock.createMock(DbDaoUtil.class); + correlationRuleDaoMock = PowerMock.createMock(CorrelationRuleDao.class); + + EasyMock.expect(locator.getService(RuleMgtWrapper.class)).andReturn(ruleMgtWrapperMock); + EasyMock.expect(locator.getService(RuleQueryWrapper.class)).andReturn(ruleQueryWrapperMock); + EasyMock.expect(locator.getService(EngineWrapper.class)).andReturn(engineWrapperMock); + EasyMock.expect(locator.getService(EngineInsQueryTool.class)).andReturn(engineInsQueryToolMock); + EasyMock.expect(locator.getService(DbDaoUtil.class)).andReturn(dbDaoUtilMock); + EasyMock.expect(dbDaoUtilMock.getJdbiDaoByOnDemand(CorrelationRuleDao.class)).andReturn(correlationRuleDaoMock); + + rules = new ArrayList<>(); + for (int i = 0; i < 20; ++i) { + CorrelationRule rule = new CorrelationRule(); + rule.setRid("rid-" + i); + rule.setName("rule-" + i); + rule.setDescription("desc-" + i); + rule.setEnabled(1); + rule.setTemplateID((long) i); + rule.setEngineID("engine-" + i); + rule.setCreateTime(Calendar.getInstance().getTime()); + rule.setUpdateTime(Calendar.getInstance().getTime()); + rule.setPackageName("package-" + i); + rule.setClosedControlLoopName("CL-" + i); + rule.setEngineInstance("10.15.3." + (i % 10)); + rules.add(rule); + } + + existingIps = new ArrayList<>(); + for (int i = 0; i < 10; ++i) { + existingIps.add("10.15.3." + i); + } + } + + @After + public void after() { + PowerMock.resetAll(); + } + + @Test + public void allocateRuleTest_engine_scaled_out() throws Exception { + + List ipListFromMsb = new ArrayList<>(); + ipListFromMsb.add("127.0.0.1"); + ipListFromMsb.add("10.23.0.72"); + ipListFromMsb.addAll(existingIps); + + EasyMock.expect(engineInsQueryToolMock.getInstanceList()).andReturn(existingIps); + EasyMock.expect(ruleQueryWrapperMock.queryRuleByEnable(ENABLE)).andReturn(rules.stream() + .filter(r -> r.getEnabled() == ENABLE).collect(Collectors.toList())); + for (String ip : existingIps) { + EasyMock.expect(ruleQueryWrapperMock.queryRuleByEngineInstance(EasyMock.anyObject(String.class))) + .andReturn(rules.stream().filter(r -> r.getEngineInstance().equals(ip)).collect(Collectors.toList())); + + } + EasyMock.expect(engineWrapperMock.deleteRuleFromEngine(EasyMock.anyObject(String.class), + EasyMock.anyObject(String.class))).andReturn(true).anyTimes(); + EasyMock.expect(ruleQueryWrapperMock.queryRuleByEngineInstance(EasyMock.anyObject(String.class))) + .andReturn(new ArrayList<>()).times(2); + + EasyMock.expect(ruleMgtWrapperMock.deployRule2Engine(EasyMock.anyObject(CorrelationRule.class), + EasyMock.anyObject(String.class))).andReturn("").anyTimes(); + correlationRuleDaoMock.updateRule(EasyMock.anyObject(CorrelationRule.class)); + EasyMock.expectLastCall().anyTimes(); + + PowerMock.replayAll(); + + RuleAllocator ruleAllocator = new RuleAllocator(); + ruleAllocator.allocateRules(ipListFromMsb); + + PowerMock.verifyAll(); + + } + + @Test + public void allocateRuleTest_engine_scaled_in() throws Exception { + + List ipListFromMsb = new ArrayList<>(); + ipListFromMsb.addAll(existingIps); + ipListFromMsb.remove(0); + + List rules = new ArrayList<>(); + + + EasyMock.expect(engineInsQueryToolMock.getInstanceList()).andReturn(existingIps); + for (String ip : existingIps) { + EasyMock.expect(ruleQueryWrapperMock.queryRuleByEngineInstance(EasyMock.anyObject(String.class))) + .andReturn(rules.stream().filter(r -> r.getEngineInstance().equals(ip)).collect(Collectors.toList())); + + } + EasyMock.expect(engineWrapperMock.deleteRuleFromEngine(EasyMock.anyObject(String.class), + EasyMock.anyObject(String.class))).andReturn(true).anyTimes(); + + PowerMock.replayAll(); + + RuleAllocator ruleAllocator = new RuleAllocator(); + ruleAllocator.allocateRules(ipListFromMsb); + + PowerMock.verifyAll(); + + } + + @Test + public void allocateRuleTest_empty_param() throws Exception { + + EasyMock.expect(engineInsQueryToolMock.getInstanceList()).andReturn(Collections.emptyList()); + + thrown.expect(NullPointerException.class); + + PowerMock.replayAll(); + + RuleAllocator ruleAllocator = new RuleAllocator(); + ruleAllocator.allocateRules(null); + + PowerMock.verifyAll(); + + } + + @Test + public void allocateRuleTest_equal_engine_instance_num() throws Exception { + + List ipListFromMsb = new ArrayList<>(); + ipListFromMsb.addAll(existingIps); + + EasyMock.expect(engineInsQueryToolMock.getInstanceList()).andReturn(existingIps); + + PowerMock.replayAll(); + + RuleAllocator ruleAllocator = new RuleAllocator(); + ruleAllocator.allocateRules(ipListFromMsb); + + PowerMock.verifyAll(); + + } + +} -- cgit 1.2.3-korg