From 3478377da4382d7654775d99a0b90494fc496b0d Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Mon, 27 Aug 2018 12:03:30 +0530 Subject: Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vafp32hFUzlqc5ro&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/metrics/publisher/CambriaClient.java Line No- L24 L28 Change-Id: I2ae6fa62452e936374e41d56609de98ce0d4f203 Issue-ID: DMAAP-648 Signed-off-by: Surendra Reddy Katam --- src/main/java/com/att/dmf/mr/metrics/publisher/CambriaClient.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/main/java/com') diff --git a/src/main/java/com/att/dmf/mr/metrics/publisher/CambriaClient.java b/src/main/java/com/att/dmf/mr/metrics/publisher/CambriaClient.java index 0993aa6..4b219b1 100644 --- a/src/main/java/com/att/dmf/mr/metrics/publisher/CambriaClient.java +++ b/src/main/java/com/att/dmf/mr/metrics/publisher/CambriaClient.java @@ -21,11 +21,11 @@ *******************************************************************************/ package com.att.dmf.mr.metrics.publisher; -//import org.slf4j.Logger; + // import com.att.eelf.configuration.EELFLogger; -//import com.att.eelf.configuration.EELFManager; + /** * -- cgit 1.2.3-korg From 79fb311458129d3ee7e686c3c554b4b529ce6cc0 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Mon, 27 Aug 2018 12:26:46 +0530 Subject: Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VafD32hFUzlqc5rW&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/listener/DME2EndPointLoader.java Line No- L54 Change-Id: I2dffd5df21665ed488ac62f54b0cd663b02d88bb Issue-ID: DMAAP-649 Signed-off-by: Surendra Reddy Katam --- src/main/java/com/att/dmf/mr/listener/DME2EndPointLoader.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com') diff --git a/src/main/java/com/att/dmf/mr/listener/DME2EndPointLoader.java b/src/main/java/com/att/dmf/mr/listener/DME2EndPointLoader.java index 7f27798..f61b6ea 100644 --- a/src/main/java/com/att/dmf/mr/listener/DME2EndPointLoader.java +++ b/src/main/java/com/att/dmf/mr/listener/DME2EndPointLoader.java @@ -51,7 +51,7 @@ public class DME2EndPointLoader { private String protocol; private String serviceURL; private static DME2EndPointLoader loader = new DME2EndPointLoader(); -// private static final Logger LOG = LoggerFactory.getLogger(EventsServiceImpl.class); + private static final EELFLogger LOG = EELFManager.getInstance().getLogger(EventsServiceImpl.class); private DME2EndPointLoader() { } -- cgit 1.2.3-korg From be7925558af3d13fa1d2e4707a1ccabdb4cb5aca Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Mon, 27 Aug 2018 12:55:35 +0530 Subject: Sonar Major issues Replace the type specification in this constructor call with the diamond operator Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VadZ32hFUzlqc5qX&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java Line No- L91 L103 Change-Id: I093fde71871e39a667a943b4f6386fe39769c4b1 Issue-ID: DMAAP-650 Signed-off-by: Surendra Reddy Katam --- src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/main/java/com') diff --git a/src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java b/src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java index b6fcbf5..963ff2d 100644 --- a/src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java +++ b/src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java @@ -88,7 +88,7 @@ public class DMaaPNsaApiDb { // if neither value was provided, don't encrypt api key db if (keyBase64 == null && initVectorBase64 == null) { log.info("This server is configured to use an unencrypted API key database. See the settings documentation."); - return new BaseNsaApiDbImpl(cdb, + return new BaseNsaApiDbImpl<>(cdb, new NsaSimpleApiKeyFactory()); } else if (keyBase64 == null) { // neither or both, otherwise something's goofed @@ -100,7 +100,7 @@ public class DMaaPNsaApiDb { log.info("This server is configured to use an encrypted API key database."); final Key key = EncryptingLayer.readSecretKey(keyBase64); final byte[] iv = rrConvertor.base64Decode(initVectorBase64); - return new EncryptingApiDbImpl(cdb, + return new EncryptingApiDbImpl<>(cdb, new NsaSimpleApiKeyFactory(), key, iv); } } -- cgit 1.2.3-korg