From e7954efb84ebdef62ac524e7960a7fa66fecdfc7 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Tue, 17 Apr 2018 13:14:34 +0530 Subject: Sonar critical issues Either re-interrupt this method or rethrow the InterruptedException Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VahN32hFUzlqc5tz&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/resources/CambriaOutboundEventStream.java Line No-329 Change-Id: If36c06fc3fbfd94a455e90b2c1f5c12ed7575eb4 Issue-ID: DMAAP-417 Signed-off-by: Surendra Reddy Katam --- .../com/att/nsa/cambria/resources/CambriaOutboundEventStream.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/main/java/com/att/nsa/cambria') diff --git a/src/main/java/com/att/nsa/cambria/resources/CambriaOutboundEventStream.java b/src/main/java/com/att/nsa/cambria/resources/CambriaOutboundEventStream.java index e519f71..7366dde 100644 --- a/src/main/java/com/att/nsa/cambria/resources/CambriaOutboundEventStream.java +++ b/src/main/java/com/att/nsa/cambria/resources/CambriaOutboundEventStream.java @@ -44,6 +44,8 @@ import com.att.nsa.cambria.metabroker.Topic; import com.att.nsa.cambria.utils.DMaaPResponseBuilder.StreamWriter; import com.att.nsa.cambria.utils.Utils; +import jline.internal.Log; + /** * class used to write the consumed messages @@ -327,7 +329,8 @@ public class CambriaOutboundEventStream implements StreamWriter { // FIXME: would be good to wait/signal Thread.sleep(100); } catch (InterruptedException e) { - // ignore + Log.error(e.toString()); + Thread.currentThread().interrupt(); } } }); -- cgit 1.2.3-korg From fda5f3ac35cdfa6c28802344ae28bea2e3ec5c24 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Tue, 17 Apr 2018 15:07:25 +0530 Subject: Sonar critical issues Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vah332hFUzlqc5uo&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaTextStreamReader.java Line No-132 Change-Id: I124eefbc7834d6eb3d02ceda34425967506227f4 Issue-ID: DMAAP-419 Signed-off-by: Surendra Reddy Katam --- .../nsa/cambria/resources/streamReaders/CambriaTextStreamReader.java | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/main/java/com/att/nsa/cambria') diff --git a/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaTextStreamReader.java b/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaTextStreamReader.java index 2b76a61..41b9275 100644 --- a/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaTextStreamReader.java +++ b/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaTextStreamReader.java @@ -25,6 +25,7 @@ import java.io.BufferedReader; import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; +import java.util.logging.Logger; import javax.servlet.http.HttpServletResponse; @@ -33,6 +34,8 @@ import com.att.nsa.cambria.backends.Publisher.message; import com.att.nsa.cambria.beans.LogDetails; import com.att.nsa.cambria.resources.CambriaEventSet.reader; +import jline.internal.Log; + /** * This stream reader just pulls single lines. It uses the default partition if provided. If * not, the key is the current time, which does not guarantee ordering. @@ -42,6 +45,7 @@ import com.att.nsa.cambria.resources.CambriaEventSet.reader; */ public class CambriaTextStreamReader implements reader { + private Logger log = Logger.getLogger(CambriaTextStreamReader.class.toString()); /** * This is the constructor for Cambria Text Reader format * @param is @@ -131,6 +135,7 @@ public class CambriaTextStreamReader implements reader } catch ( IOException e ) { + Log.error(e); throw new CambriaApiException ( HttpServletResponse.SC_BAD_REQUEST, e.getMessage () ); } } -- cgit 1.2.3-korg From 32599ce8a647cc18393d40ccc51ebd59f1b19aca Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Tue, 17 Apr 2018 18:52:10 +0530 Subject: Sonar critical issues Define and throw a dedicated exception instead of using a generic one Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vaf-32hFUzlqc5ry&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/metrics/publisher/CambriaPublisherUtility.java Line No-56 Change-Id: I43199346fee31ed87618c69e7f46c7ef6d0a0a69 Issue-ID: DMAAP-426 Signed-off-by: Surendra Reddy Katam --- .../com/att/nsa/cambria/metrics/publisher/CambriaPublisherUtility.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com/att/nsa/cambria') diff --git a/src/main/java/com/att/nsa/cambria/metrics/publisher/CambriaPublisherUtility.java b/src/main/java/com/att/nsa/cambria/metrics/publisher/CambriaPublisherUtility.java index 8e54ee5..511053e 100644 --- a/src/main/java/com/att/nsa/cambria/metrics/publisher/CambriaPublisherUtility.java +++ b/src/main/java/com/att/nsa/cambria/metrics/publisher/CambriaPublisherUtility.java @@ -53,7 +53,7 @@ public class CambriaPublisherUtility } catch ( UnsupportedEncodingException e ) { - throw new RuntimeException ( e ); + throw new AssertionError ( e ); } } /** -- cgit 1.2.3-korg From 3744ebfceb35de70a65c6faeb69d00fc50dca533 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Wed, 18 Apr 2018 20:06:31 +0530 Subject: Sonar critical issues Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vakn32hFUzlqc5yP&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java Line No-225 Change-Id: I5e879cf1f2d1a96ec7207278d9395fa8771c6e6f Issue-ID: DMAAP-429 Signed-off-by: Surendra Reddy Katam --- src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com/att/nsa/cambria') diff --git a/src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java b/src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java index da024f1..04cc51c 100644 --- a/src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java +++ b/src/main/java/com/att/nsa/cambria/service/impl/MMServiceImpl.java @@ -223,7 +223,7 @@ public class MMServiceImpl implements MMService { metricsSet.consumeTick(sent); } catch (UnavailableException excp) { - + LOG.error(excp.toString()); ErrorResponse errRes = new ErrorResponse(HttpStatus.SC_SERVICE_UNAVAILABLE, DMaaPResponseCode.SERVER_UNAVAILABLE.getResponseCode(), errorMessages.getServerUnav() + excp.getMessage(), null, Utils.getFormattedDate(new Date()), topic, -- cgit 1.2.3-korg From e25f2025171ba6f9f2f3fddc76cee021bf86c9d1 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Wed, 18 Apr 2018 20:43:19 +0530 Subject: Sonar critical issues Either log or rethrow this exception Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vahb32hFUzlqc5uC&resolved=false&severities=CRITICAL Location: src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java Line No-74 Change-Id: I624da3f9a741d243595a0f7da9593ddbb64b4e43 Issue-ID: DMAAP-430 Signed-off-by: Surendra Reddy Katam --- .../att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java | 1 + 1 file changed, 1 insertion(+) (limited to 'src/main/java/com/att/nsa/cambria') diff --git a/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java b/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java index 54a9bc6..c8172a9 100644 --- a/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java +++ b/src/main/java/com/att/nsa/cambria/resources/streamReaders/CambriaJsonStreamReader.java @@ -72,6 +72,7 @@ public class CambriaJsonStreamReader implements reader { throw new CambriaApiException(HttpServletResponse.SC_BAD_REQUEST, "Expecting an array or an object."); } } catch (JSONException e) { + Log.error(e); throw new CambriaApiException(HttpServletResponse.SC_BAD_REQUEST, e.getMessage()); } } -- cgit 1.2.3-korg