From a759f919b452d439cbad4ba73f053df30b2d61f9 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Mon, 24 Sep 2018 14:33:16 +0530 Subject: Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWX77U9WligbnTmNJMpE&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java Line No- L108 L175 L267 Change-Id: I00d8d5f74ee9ba2aef6701f778de87095a1cc593 Issue-ID: DMAAP-819 Signed-off-by: Surendra Reddy Katam --- .../java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java b/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java index 97d1fa5..0c7f8bc 100644 --- a/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java +++ b/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java @@ -105,7 +105,7 @@ public class CambriaOutboundEventStream implements StreamWriter { fPretty = false; fWithMeta = false; - // fOffset = CambriaEvents.kNextOffset; + } /** @@ -172,7 +172,7 @@ public class CambriaOutboundEventStream implements StreamWriter { // public Builder atOffset ( int pos ) - // fOffset = pos; + // return this; // } /** @@ -264,7 +264,7 @@ public class CambriaOutboundEventStream implements StreamWriter { */ public void write(final OutputStream os) throws IOException { - // final boolean transactionEnabled = isTransEnabled(); + // final boolean transactionEnabled = istransEnable; // synchronized(this){ os.write('['); -- cgit 1.2.3-korg From 1513792efbf0b414854fb2f3850061ccec30f992 Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Mon, 24 Sep 2018 15:08:22 +0530 Subject: Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VamI32hFUzlqc5z-&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java Line No- L167 L169 Change-Id: I10fc7c7de82d6015c852ebb7c11b43177b7da5f9 Issue-ID: DMAAP-820 Signed-off-by: Surendra Reddy Katam --- src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java b/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java index fdf2d28..ab74e9c 100644 --- a/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java +++ b/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java @@ -164,9 +164,9 @@ public class ConfigurationReader { fMetrics.toJson(); fMetrics.setupCambriaSender(); // add the admin authenticator - // final String adminSecret = settings.getString ( CambriaConstants.kSetting_AdminSecret, null ); + final String adminSecret = com.att.ajsc.filemonitor.AJSCPropertiesMap.getProperty(CambriaConstants.msgRtr_prop,CambriaConstants.kSetting_AdminSecret); - //adminSecret = "fe3cCompound"; + if ( adminSecret != null && adminSecret.length () > 0 ) { try -- cgit 1.2.3-korg From 6b7d17de13af62c22e747ad0f0394f9a5503833b Mon Sep 17 00:00:00 2001 From: Surendra Reddy Katam Date: Mon, 24 Sep 2018 16:02:11 +0530 Subject: Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWX77U9WligbnTmNJMpH&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java Line No-L303 Change-Id: Ic282f482c7f03849ae94bea2416adc6eaa7f23af Issue-ID: DMAAP-821 Signed-off-by: Surendra Reddy Katam --- src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java b/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java index 0c7f8bc..aae15fb 100644 --- a/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java +++ b/src/main/java/com/att/dmf/mr/resources/CambriaOutboundEventStream.java @@ -300,7 +300,7 @@ public class CambriaOutboundEventStream implements StreamWriter { if (istransEnable && istransType) { // final String transactionId = - // responseTransactionId = transId; + StringBuilder consumerInfo = new StringBuilder(); if (null != dmaapContext && null != dmaapContext.getRequest()) { final HttpServletRequest request = dmaapContext.getRequest(); -- cgit 1.2.3-korg