From a8d86dd9661d7e57616fa1835860937affb56cb3 Mon Sep 17 00:00:00 2001 From: Sahani Ravindrana Naik Date: Wed, 9 May 2018 11:55:42 +0530 Subject: sonar critical for conditional statement This line will not be executed conditionally; only the first line of this 2-line block will be. The rest will execute unconditionally Sonar Link: https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false Location: src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java Line No-166 Change-Id: I8e07515bb42960205f7f4982d99184cf946402ac Issue-ID: DMAAP-480 Signed-off-by: Sahani Ravindrana Naik --- src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java b/src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java index 7875b90..bfd005e 100644 --- a/src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java +++ b/src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java @@ -163,7 +163,9 @@ public class TopicServiceImpl implements TopicService { if (null!=t.getOwners ()) o.put ( "owner", t.getOwners ().iterator ().next () ); if(null!=t.getReaderAcl ()) - o.put ( "readerAcl", aclToJson ( t.getReaderAcl () ) ); + { + o.put ( "readerAcl", aclToJson ( t.getReaderAcl () ) ); + } if(null!=t.getWriterAcl ()) o.put ( "writerAcl", aclToJson ( t.getWriterAcl () ) ); -- cgit 1.2.3-korg