From 72a9ab9e886cdeabc4b43418a7054a5796a0ff55 Mon Sep 17 00:00:00 2001
From: sliard <samuel.liard@gmail.com>
Date: Mon, 12 Apr 2021 15:58:22 +0200
Subject: [DMAAP-CLIENT] First sonar issues review part2

update Copyright informations
fix checkstyle warning and fix code review comments
remove Prop

Issue-ID: DMAAP-1585
Change-Id: I445ca5d0888a555acbac70af7ed571be26d74f79
Signed-off-by: sliard <samuel.liard@gmail.com>
---
 .../dme/client/PreferredRouteReplyHandlerTest.java | 94 +++++++++++-----------
 1 file changed, 45 insertions(+), 49 deletions(-)

(limited to 'src/test/java/org/onap/dmaap/mr/dme/client/PreferredRouteReplyHandlerTest.java')

diff --git a/src/test/java/org/onap/dmaap/mr/dme/client/PreferredRouteReplyHandlerTest.java b/src/test/java/org/onap/dmaap/mr/dme/client/PreferredRouteReplyHandlerTest.java
index acfea5a..fb3b8d0 100644
--- a/src/test/java/org/onap/dmaap/mr/dme/client/PreferredRouteReplyHandlerTest.java
+++ b/src/test/java/org/onap/dmaap/mr/dme/client/PreferredRouteReplyHandlerTest.java
@@ -4,12 +4,14 @@
  * ================================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
+ * Modifications Copyright © 2021 Orange.
+ * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -20,70 +22,64 @@
 
 package org.onap.dmaap.mr.dme.client;
 
-import java.util.HashMap;
-import java.util.Map;
-
+import com.att.aft.dme2.api.util.DME2ExchangeResponseContext;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
-import com.att.aft.dme2.api.util.DME2ExchangeResponseContext;
+import java.util.HashMap;
+import java.util.Map;
+
 import static org.junit.Assert.assertNotNull;
 
 public class PreferredRouteReplyHandlerTest {
-	private PreferredRouteReplyHandler handler = null;
-
-	@Before
-	public void setUp() throws Exception {
-		handler = new PreferredRouteReplyHandler();
-
-	}
-
-	@After
-	public void tearDown() throws Exception {
+    private PreferredRouteReplyHandler handler = null;
 
-	}
+    @Before
+    public void setUp() throws Exception {
+        handler = new PreferredRouteReplyHandler();
 
-	@Test
-	public void testHandleReply() {
-		
-		Map <String, String> responseHeaders = new HashMap <String, String>();
-		responseHeaders.put("transactionId", "1234");
+    }
 
-		DME2ExchangeResponseContext responseData =  new DME2ExchangeResponseContext ("service", 
-				200, new HashMap<String, String>(), responseHeaders, "routeOffer", "1.0.0", "http://");
+    @After
+    public void tearDown() throws Exception {
 
-		handler.handleReply(responseData);
-		assert(true);
-		assertNotNull(responseHeaders);
+    }
 
-	}
-/*
-	@Test
-	public void testHandleFault() {
-
-		handler.handleFault(null);
-		assertTrue(true);
+    @Test
+    public void testHandleReply() {
 
-	}
-	
-	@Test
-	public void testHandleEndpointFault() {
+        Map<String, String> responseHeaders = new HashMap<String, String>();
+        responseHeaders.put("transactionId", "1234");
 
-		handler.handleEndpointFault(null);
-		assertTrue(true);
+        DME2ExchangeResponseContext responseData = new DME2ExchangeResponseContext("service",
+                200, new HashMap<String, String>(), responseHeaders, "routeOffer", "1.0.0", "http://");
 
-	}
-	
-	@Test
-	public void testRouteWriter() {
+        handler.handleReply(responseData);
+        assert (true);
+        assertNotNull(responseHeaders);
 
-		handler.routeWriter("routeKey", "routeValue");
-		assertTrue(true);
+    }
+/*
+    @Test
+    public void testHandleFault() {
+        handler.handleFault(null);
+        assertTrue(true);
+    }
+
+    @Test
+    public void testHandleEndpointFault() {
+        handler.handleEndpointFault(null);
+        assertTrue(true);
+    }
+
+    @Test
+    public void testRouteWriter() {
+        handler.routeWriter("routeKey", "routeValue");
+        assertTrue(true);
+    }
 
-	}
-	
 */
-	
+
 
 }
-- 
cgit 1.2.3-korg