From 72a9ab9e886cdeabc4b43418a7054a5796a0ff55 Mon Sep 17 00:00:00 2001
From: sliard <samuel.liard@gmail.com>
Date: Mon, 12 Apr 2021 15:58:22 +0200
Subject: [DMAAP-CLIENT] First sonar issues review part2

update Copyright informations
fix checkstyle warning and fix code review comments
remove Prop

Issue-ID: DMAAP-1585
Change-Id: I445ca5d0888a555acbac70af7ed571be26d74f79
Signed-off-by: sliard <samuel.liard@gmail.com>
---
 .../java/org/onap/dmaap/mr/client/MRClient.java    | 81 ++++++++++++----------
 1 file changed, 44 insertions(+), 37 deletions(-)

(limited to 'src/main/java/org/onap/dmaap/mr/client/MRClient.java')

diff --git a/src/main/java/org/onap/dmaap/mr/client/MRClient.java b/src/main/java/org/onap/dmaap/mr/client/MRClient.java
index 8cbf9e0..f1a642b 100644
--- a/src/main/java/org/onap/dmaap/mr/client/MRClient.java
+++ b/src/main/java/org/onap/dmaap/mr/client/MRClient.java
@@ -4,11 +4,13 @@
  *  ================================================================================
  *  Copyright © 2017 AT&T Intellectual Property. All rights reserved.
  *  ================================================================================
+ *  Modifications Copyright © 2021 Orange.
+ *  ================================================================================
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
  *        http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing, software
  *  distributed under the License is distributed on an "AS IS" BASIS,
  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -17,50 +19,55 @@
  *  ============LICENSE_END=========================================================
  *
  *  ECOMP is a trademark and service mark of AT&T Intellectual Property.
- *  
+ *
  *******************************************************************************/
+
 package org.onap.dmaap.mr.client;
 
 import org.slf4j.Logger;
 
 
-public interface MRClient
-{
-	/**
-	 * An exception at the MR layer. This is used when the HTTP transport
-	 * layer returns a success code but the transaction is not completed as expected.
-	 */
-	public class MRApiException extends Exception
-	{
-		private static final long serialVersionUID = 1L;
-		public MRApiException ( String msg ) { super ( msg ); }
-		public MRApiException ( String msg, Throwable t ) { super ( msg, t ); }
-	}
+public interface MRClient {
+    /**
+     * An exception at the MR layer. This is used when the HTTP transport
+     * layer returns a success code but the transaction is not completed as expected.
+     */
+    class MRApiException extends Exception {
+        private static final long serialVersionUID = 1L;
+
+        public MRApiException(String msg) {
+            super(msg);
+        }
+
+        public MRApiException(String msg, Throwable t) {
+            super(msg, t);
+        }
+    }
 
-	/**
-	 * Optionally set the Logger to use
-	 * @param log log
-	 */
-	void logTo ( Logger log );
+    /**
+     * Optionally set the Logger to use.
+     *
+     * @param log log
+     */
+    void logTo(Logger log);
 
-	/**
-	 * Set the API credentials for this client connection. Subsequent calls will
-	 * include authentication headers.who i 
-	 */
-	/**
-	 * @param apiKey apikey
-	 * @param apiSecret apisec
-	 */
-	void setApiCredentials ( String apiKey, String apiSecret );
+    /**
+     * Set the API credentials for this client connection. Subsequent calls will
+     * include authentication headers.who i
+     *
+     * @param apiKey    apikey
+     * @param apiSecret apisec
+     */
+    void setApiCredentials(String apiKey, String apiSecret);
 
-	/**
-	 * Remove API credentials, if any, on this connection. Subsequent calls will not include
-	 * authentication headers.
-	 */
-	void clearApiCredentials ();
+    /**
+     * Remove API credentials, if any, on this connection. Subsequent calls will not include
+     * authentication headers.
+     */
+    void clearApiCredentials();
 
-	/**
-	 * Close this connection. Some client interfaces have additional close capability.
-	 */
-	void close ();
+    /**
+     * Close this connection. Some client interfaces have additional close capability.
+     */
+    void close();
 }
-- 
cgit 1.2.3-korg