From 269250a5700086cc68d20706ee6a9b345e0387be Mon Sep 17 00:00:00 2001 From: wasala Date: Thu, 17 May 2018 13:36:01 +0200 Subject: Added tests for DmaapConsumerTask Change-Id: I1068eb44eba5871f5c1e44e34f149584e056a7a2 Issue-ID: DCAEGEN2-396 Signed-off-by: wasala --- .../services/prh/tasks/AAIConsumerTask.java | 2 +- .../services/prh/tasks/AAIConsumerTaskImpl.java | 10 +++------ .../services/prh/tasks/AAIProducerTaskImpl.java | 5 ----- .../services/prh/tasks/DmaapConsumerTask.java | 6 +++-- .../services/prh/tasks/DmaapConsumerTaskImpl.java | 26 ++++++++++++++++------ .../services/prh/tasks/DmaapPublisherTask.java | 4 ++-- .../services/prh/tasks/DmaapPublisherTaskImpl.java | 16 ++++++------- .../services/prh/tasks/ScheduledTasks.java | 6 ++--- .../org/onap/dcaegen2/services/prh/tasks/Task.java | 4 ++-- 9 files changed, 42 insertions(+), 37 deletions(-) (limited to 'prh-app-server/src/main') diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTask.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTask.java index b4b66036..ffc81324 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTask.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTask.java @@ -22,7 +22,7 @@ package org.onap.dcaegen2.services.prh.tasks; import org.onap.dcaegen2.services.prh.exceptions.AAINotFoundException; -public abstract class AAIConsumerTask extends Task { +public abstract class AAIConsumerTask extends Task { protected abstract V consume(U message) throws AAINotFoundException; diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTaskImpl.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTaskImpl.java index 31af9c80..3c2b2974 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTaskImpl.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/AAIConsumerTaskImpl.java @@ -33,7 +33,8 @@ import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; @Component -public class AAIConsumerTaskImpl extends AAIConsumerTask { +public class AAIConsumerTaskImpl extends + AAIConsumerTask { private static final Logger logger = LoggerFactory.getLogger(AAIConsumerTaskImpl.class); @@ -66,16 +67,11 @@ public class AAIConsumerTaskImpl extends AAIConsumerTaskPrzemysław Wąsala on 4/13/18 */ -public abstract class DmaapConsumerTask extends Task { +public abstract class DmaapConsumerTask extends Task { protected abstract V consume(U message) throws DmaapNotFoundException; - protected abstract T resolveConfiguration(); + protected abstract T resolveClient(); + + abstract void initConfigs(); } diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTaskImpl.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTaskImpl.java index 3b5a164e..d5cf91d3 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTaskImpl.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTaskImpl.java @@ -37,12 +37,14 @@ import org.springframework.stereotype.Component; * @author Przemysław Wąsala on 3/23/18 */ @Component -public class DmaapConsumerTaskImpl extends DmaapConsumerTask { +public class DmaapConsumerTaskImpl extends + DmaapConsumerTask { private static final Logger logger = LoggerFactory.getLogger(DmaapConsumerTaskImpl.class); private final Config prhAppConfig; + private ExtendedDmaapConsumerHttpClientImpl extendedDmaapConsumerHttpClient; @Autowired public DmaapConsumerTaskImpl(AppConfig prhAppConfig) { @@ -57,20 +59,30 @@ public class DmaapConsumerTaskImpl extends DmaapConsumerTask + return consume((extendedDmaapConsumerHttpClient.getHttpConsumerResponse().orElseThrow(() -> new PrhTaskException("DmaapConsumerTask has returned null")))); } @Override - protected DmaapConsumerConfiguration resolveConfiguration() { + void initConfigs() { + prhAppConfig.initFileStreamReader(); + } + + protected void setDmaapClientConfig() { + extendedDmaapConsumerHttpClient = resolveClient(); + } + + @Override + DmaapConsumerConfiguration resolveConfiguration() { return prhAppConfig.getDmaapConsumerConfiguration(); } @Override - protected void initConfigs() { - prhAppConfig.initFileStreamReader(); + protected ExtendedDmaapConsumerHttpClientImpl resolveClient() { + return new ExtendedDmaapConsumerHttpClientImpl(resolveConfiguration()); } + + } \ No newline at end of file diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTask.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTask.java index 2329274b..8985133a 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTask.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTask.java @@ -24,9 +24,9 @@ import org.onap.dcaegen2.services.prh.exceptions.DmaapNotFoundException; /** * @author Przemysław Wąsala on 3/23/18 */ -public abstract class DmaapPublisherTask extends Task { +public abstract class DmaapPublisherTask extends Task { protected abstract String publish(U message) throws DmaapNotFoundException; - protected abstract T resolveConfiguration(); + protected abstract T resolveClient(); } diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTaskImpl.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTaskImpl.java index 77373e41..d03f8061 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTaskImpl.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapPublisherTaskImpl.java @@ -38,7 +38,7 @@ import org.springframework.stereotype.Component; */ @Component public class DmaapPublisherTaskImpl extends - DmaapPublisherTask { + DmaapPublisherTask { private static final Logger logger = LoggerFactory.getLogger(DmaapPublisherTaskImpl.class); private static final Gson gson = new Gson(); @@ -53,11 +53,11 @@ public class DmaapPublisherTaskImpl extends protected String publish(ConsumerDmaapModel consumerDmaapModel) throws DmaapNotFoundException { logger.trace("Method called with arg {}", consumerDmaapModel); ExtendedDmaapProducerHttpClientImpl dmaapProducerHttpClient = new ExtendedDmaapProducerHttpClientImpl( - resolveConfiguration()); + resolveConfiguration()); return dmaapProducerHttpClient.getHttpProducerResponse(consumerDmaapModel) - .filter(x -> !x.isEmpty() && x.equals(String.valueOf(HttpStatus.OK.value()))) - .orElseThrow(() -> new DmaapNotFoundException("Incorrect response from Dmaap")); + .filter(x -> !x.isEmpty() && x.equals(String.valueOf(HttpStatus.OK.value()))) + .orElseThrow(() -> new DmaapNotFoundException("Incorrect response from Dmaap")); } @Override @@ -70,12 +70,12 @@ public class DmaapPublisherTaskImpl extends } @Override - void initConfigs() { - logger.trace("initConfigs for DmaapPublisherTaskImpl not needed/supported"); + DmaapPublisherConfiguration resolveConfiguration() { + return prhAppConfig.getDmaapPublisherConfiguration(); } @Override - protected DmaapPublisherConfiguration resolveConfiguration() { - return prhAppConfig.getDmaapPublisherConfiguration(); + protected ExtendedDmaapProducerHttpClientImpl resolveClient() { + return null; } } \ No newline at end of file diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTasks.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTasks.java index 07c0a58a..6b868d67 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTasks.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTasks.java @@ -33,9 +33,9 @@ public class ScheduledTasks { private static final Logger logger = LoggerFactory.getLogger(ScheduledTasks.class); - private final Task dmaapConsumerTask; - private final Task dmaapProducerTask; - private final Task aaiProducerTask; + private final DmaapConsumerTask dmaapConsumerTask; + private final DmaapPublisherTask dmaapProducerTask; + private final AAIProducerTask aaiProducerTask; @Autowired public ScheduledTasks(DmaapConsumerTask dmaapConsumerTask, DmaapPublisherTask dmaapPublisherTask, diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/Task.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/Task.java index 97202146..42f0405c 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/Task.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/Task.java @@ -26,7 +26,7 @@ import org.onap.dcaegen2.services.prh.exceptions.PrhTaskException; */ -public abstract class Task { +public abstract class Task { private Task taskProcess; @@ -44,5 +44,5 @@ public abstract class Task { abstract Object execute(Object object) throws PrhTaskException; - abstract void initConfigs(); + abstract T resolveConfiguration(); } -- cgit 1.2.3-korg