From cfdf0dbbcd208a669c9919f23f1c30b2ec16b4d8 Mon Sep 17 00:00:00 2001
From: Bogumil Zebek <bogumil.zebek@nokia.com>
Date: Fri, 6 Dec 2019 08:37:39 +0100
Subject: Improve code coverage

Issue-ID: DCAEGEN2-1980
Signed-off-by: Zebek Bogumil <bogumil.zebek@nokia.com>
Change-Id: I062a4a7f6508a6a3b2c212793bdad019ab46f7e2
---
 .../DcaeServicesGroupbyApiServiceImplTests.java    | 88 ----------------------
 1 file changed, 88 deletions(-)
 delete mode 100644 src/test/java/io/swagger/api/impl/DcaeServicesGroupbyApiServiceImplTests.java

(limited to 'src/test/java/io/swagger/api/impl/DcaeServicesGroupbyApiServiceImplTests.java')

diff --git a/src/test/java/io/swagger/api/impl/DcaeServicesGroupbyApiServiceImplTests.java b/src/test/java/io/swagger/api/impl/DcaeServicesGroupbyApiServiceImplTests.java
deleted file mode 100644
index c2d0944..0000000
--- a/src/test/java/io/swagger/api/impl/DcaeServicesGroupbyApiServiceImplTests.java
+++ /dev/null
@@ -1,88 +0,0 @@
-package io.swagger.api.impl;/*-
- * ============LICENSE_START=======================================================
- * dcae-inventory
- * ================================================================================
- * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
- * ================================================================================
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- * ============LICENSE_END=========================================================
- */
-
-import static org.junit.Assert.assertEquals;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-import javax.ws.rs.core.Response;
-import javax.ws.rs.core.UriInfo;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.onap.dcae.inventory.daos.InventoryDAOManager;
-import org.powermock.api.mockito.PowerMockito;
-import org.powermock.core.classloader.annotations.PrepareForTest;
-import org.powermock.modules.junit4.PowerMockRunner;
-
-import io.swagger.api.Util;
-
-/**
- * Created by mhwang on 9/27/17.
- */
-@PrepareForTest({InventoryDAOManager.class})
-@RunWith(PowerMockRunner.class)
-public class DcaeServicesGroupbyApiServiceImplTests {
-
-    @Before
-    public void setupClass() {
-        // PowerMockito does bytecode magic to mock static methods and use final classes
-        PowerMockito.mockStatic(InventoryDAOManager.class);
-        InventoryDAOManager mockDaoManager = mock(InventoryDAOManager.class);
-
-        when(InventoryDAOManager.getInstance()).thenReturn(mockDaoManager);
-    }
-
-    @Test
-    public void testBadRequest() {
-        DcaeServicesGroupbyApiServiceImpl api = new DcaeServicesGroupbyApiServiceImpl();
-
-        String propertyName = "non-existent";
-        UriInfo uriInfo = new Util.FakeUriInfo();
-        Response response = api.dcaeServicesGroupbyPropertyNameGet(propertyName, uriInfo, null);
-        assertEquals(response.getStatus(), 400);
-    }
-
-    /*
-    Commented this unit test because could not get past Nullpointer in the line trying to mock the explicit "bind" 
-    function call. Mockito does not handle mocking overloaded functions well so it goes into the actual method where
-    an member variable called foreman is null.
-    @Test
-    public void testNoResults() {
-        DcaeServicesGroupbyApiServiceImpl api = new DcaeServicesGroupbyApiServiceImpl();
-
-        String propertyName = "type";
-        UriInfo uriInfo = new io.swagger.api.Util.FakeUriInfo();
-
-        Handle mockHandle = mock(Handle.class);
-        when(InventoryDAOManager.getInstance().getHandle()).thenReturn(mockHandle);
-        Query mockQueryGeneric = mock(Query.class);
-        when(mockHandle.createQuery(any())).thenReturn(mockQueryGeneric);
-        // LOOK HERE!
-        when(mockQueryGeneric.bind(any(), DCAEServiceObject.DCAEServiceStatus.RUNNING)).thenReturn(mockQueryGeneric);
-        when(mockQueryGeneric.list()).thenReturn(null);
-
-        Response response = api.dcaeServicesGroupbyPropertyNameGet(propertyName, uriInfo, null);
-        assertEquals(response.getStatus(), 400);
-    }
-    */
-
-}
-- 
cgit 1.2.3-korg