From 7ae9816dd0da3e374d9b1153db2b09048b422e6d Mon Sep 17 00:00:00 2001 From: Remigiusz Janeczek Date: Wed, 9 Oct 2019 11:24:51 +0200 Subject: Add tests for EventValidator Issue-ID: DCAEGEN2-1819 Change-Id: Ic9f3ea73f8e7e42f5d6e7a821d550823de3f13e7 Signed-off-by: Remigiusz Janeczek --- .../org/onap/dcae/restapi/EventValidatorTest.java | 124 +++++++++++++++++++++ 1 file changed, 124 insertions(+) create mode 100644 src/test/java/org/onap/dcae/restapi/EventValidatorTest.java (limited to 'src/test/java/org/onap/dcae/restapi/EventValidatorTest.java') diff --git a/src/test/java/org/onap/dcae/restapi/EventValidatorTest.java b/src/test/java/org/onap/dcae/restapi/EventValidatorTest.java new file mode 100644 index 00000000..5bacd31c --- /dev/null +++ b/src/test/java/org/onap/dcae/restapi/EventValidatorTest.java @@ -0,0 +1,124 @@ +/*- + * ============LICENSE_START======================================================= + * org.onap.dcaegen2.collectors.ves + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.onap.dcae.restapi; + +import com.github.fge.jackson.JsonLoader; +import com.github.fge.jsonschema.core.exceptions.ProcessingException; +import com.github.fge.jsonschema.main.JsonSchemaFactory; +import org.json.JSONObject; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.InjectMocks; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; +import org.onap.dcae.ApplicationSettings; +import org.springframework.http.ResponseEntity; + +import java.io.IOException; +import java.util.Optional; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.when; + +@ExtendWith(MockitoExtension.class) +public class EventValidatorTest { + private static final String DUMMY_SCHEMA_VERSION = "v5"; + private static final String DUMMY_TYPE = "type"; + + private static JSONObject jsonObject; + + @Mock + private static ApplicationSettings settings; + + @InjectMocks + private static EventValidator sut; + + @BeforeAll + static void setupTests(){ + jsonObject = new JSONObject("{" + DUMMY_TYPE + ":dummy}"); + } + + @Test + public void shouldReturnEmptyOptionalOnJsonSchemaValidationDisabled() { + //given + when(settings.jsonSchemaValidationEnabled()).thenReturn(false); + + //when + Optional> result = sut.validate(jsonObject, DUMMY_TYPE, DUMMY_SCHEMA_VERSION); + + //then + assertEquals(Optional.empty(), result); + + } + + @Test + public void shouldReturnInvalidJsonErrorOnWrongType() { + //given + when(settings.jsonSchemaValidationEnabled()).thenReturn(true); + + //when + Optional> result = sut.validate(jsonObject, "wrongType", DUMMY_SCHEMA_VERSION); + + //then + assertEquals(generateResponseOptional(ApiException.INVALID_JSON_INPUT), result); + } + + @Test + public void shouldReturnSchemaValidationFailedErrorOnInvalidJsonObjectSchema() throws ProcessingException, IOException { + //given + String schemaRejectingEverything = "{\"not\":{}}"; + mockJsonSchema(schemaRejectingEverything); + when(settings.jsonSchemaValidationEnabled()).thenReturn(true); + + //when + Optional> result = sut.validate(jsonObject, DUMMY_TYPE, DUMMY_SCHEMA_VERSION); + + //then + assertEquals(generateResponseOptional(ApiException.SCHEMA_VALIDATION_FAILED), result); + } + + @Test + public void shouldReturnEmptyOptionalOnValidJsonObjectSchema() throws ProcessingException, IOException { + //given + String schemaAcceptingEverything = "{}"; + mockJsonSchema(schemaAcceptingEverything); + when(settings.jsonSchemaValidationEnabled()).thenReturn(true); + + //when + Optional> result = sut.validate(jsonObject, DUMMY_TYPE, DUMMY_SCHEMA_VERSION); + + //then + assertEquals(Optional.empty(), result); + } + + private void mockJsonSchema(String jsonSchema) throws IOException, ProcessingException { + when(settings.jsonSchema(any())).thenReturn( + JsonSchemaFactory.byDefault() + .getJsonSchema(JsonLoader.fromString(jsonSchema))); + } + + private Optional> generateResponseOptional(ApiException schemaValidationFailed) { + return Optional.of(ResponseEntity.status(schemaValidationFailed.httpStatusCode) + .body(schemaValidationFailed.toJSON().toString())); + } +} \ No newline at end of file -- cgit 1.2.3-korg '#n58'>58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 
#!/bin/bash

# ================================================================================
# Copyright (c) 2017-2018 AT&T Intellectual Property. All rights reserved.
# ================================================================================
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ============LICENSE_END=========================================================
#


set -ex

echo "running script: [$0] for module [$1] at stage [$2]"

MVN_PROJECT_MODULEID="$1"
MVN_PHASE="$2"
PROJECT_ROOT=$(dirname $0)


echo "MVN_RELEASE_TAG is set to [$MVN_RELEASE_TAG]"
RELEASE_TAG=${MVN_RELEASE_TAG:-R2}
if [ "$RELEASE_TAG" != "R1" ]; then
  RELEASE_TAGGED_DIR="${RELEASE_TAG}/"
else
  RELEASE_TAGGED_DIR=""
fi
if ! wget -O ${PROJECT_ROOT}/mvn-phase-lib.sh \
  "$MVN_RAWREPO_BASEURL_DOWNLOAD"/org.onap.dcaegen2.utils/${RELEASE_TAGGED_DIR}scripts/mvn-phase-lib.sh; then
  echo "Fail to download mvn-phase-lib.sh"
  exit 1
fi
source "${PROJECT_ROOT}"/mvn-phase-lib.sh


TIMESTAMP=$(date +%C%y%m%dT%H%M%S)
export BUILD_NUMBER="${TIMESTAMP}"
shift 2

case $MVN_PHASE in
clean)
  echo "==> clean phase script"
  clean_templated_files
  clean_tox_files
  rm -rf ./venv-* ./*.wgn ./site ./coverage.xml ./xunit-results.xml
  ;;
generate-sources)
  echo "==> generate-sources phase script"
  expand_templates
  ;;
compile)
  echo "==> compile phase script"
  ;;
test)
  echo "==> test phase script"
  ;;
package)
  echo "==> package phase script"
  ;;
install)
  echo "==> install phase script"
  case $MVN_PROJECT_MODULEID in
  bootstrap)
    upload_files_of_extension sh
    ;;
  esac
  ;;
deploy)
  echo "==> deploy phase script"

  case $MVN_PROJECT_MODULEID in
  bootstrap)
    # build docker image from Docker file (under module dir) and push to registry
    upload_files_of_extension sh
    build_and_push_docker
    ;;
  k8s-bootstrap|tca-cdap-container|cmcontainer|redis-cluster-container)
    build_and_push_docker
    ;;
  scripts|cloud_init)
    # upload all sh file under the root of module 
    upload_files_of_extension_recursively sh
    upload_files_of_extension_recursively py
    upload_files_of_extension_recursively yaml
    ;;
  *)
    echo "====> unknown mvn project module"
    ;;
  esac
  ;;
*)
  echo "==> unprocessed phase"
  ;;
esac