From 77f896523f2065b1da1be21545155a29edea5122 Mon Sep 17 00:00:00 2001 From: Filip Krzywka Date: Tue, 27 Nov 2018 13:04:48 +0100 Subject: Bump checkstyle version - changed plugin invocation due to backwards incompatible changes made in detekt's RC9 version - disabled few rules that we actually don't follow in our code and we seem to be fine with it - turned on UnusedPrivateMember as it actually is a code smell/debt - supressed warnings in where it was plausible (according to common sense) - fixed warnings wherever possible Change-Id: I7be97f471ff46786ef1fca3432b759e7820ac681 Issue-ID: DCAEGEN2-996 Signed-off-by: Filip Krzywka --- .../src/main/kotlin/org/onap/dcae/collectors/veshv/domain/ByteData.kt | 1 - .../src/main/kotlin/org/onap/dcae/collectors/veshv/domain/codec.kt | 2 +- .../src/main/kotlin/org/onap/dcae/collectors/veshv/domain/wire_frame.kt | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) (limited to 'hv-collector-domain') diff --git a/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/ByteData.kt b/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/ByteData.kt index 38be9aee..a1ebba37 100644 --- a/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/ByteData.kt +++ b/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/ByteData.kt @@ -19,7 +19,6 @@ */ package org.onap.dcae.collectors.veshv.domain -import com.google.protobuf.MessageLite import io.netty.buffer.ByteBuf import java.nio.charset.Charset diff --git a/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/codec.kt b/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/codec.kt index 480ec693..7fabdf14 100644 --- a/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/codec.kt +++ b/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/codec.kt @@ -77,6 +77,7 @@ class WireFrameDecoder(private val maxPayloadSizeBytes: Int) { } } + @Suppress("ReturnCount") private fun parsePayloadFrame(byteBuf: ByteBuf): Either { val versionMajor = byteBuf.readUnsignedByte() val versionMinor = byteBuf.readUnsignedByte() @@ -97,6 +98,5 @@ class WireFrameDecoder(private val maxPayloadSizeBytes: Int) { val payload = ByteData.readFrom(byteBuf, payloadSize) return Right(WireFrameMessage(payload, versionMajor, versionMinor, payloadTypeRaw, payloadSize)) - } } diff --git a/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/wire_frame.kt b/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/wire_frame.kt index de6a5045..de37b140 100644 --- a/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/wire_frame.kt +++ b/hv-collector-domain/src/main/kotlin/org/onap/dcae/collectors/veshv/domain/wire_frame.kt @@ -19,7 +19,6 @@ */ package org.onap.dcae.collectors.veshv.domain - /** * Wire frame structure is presented bellow using ASN.1 notation. Please note that official supported specification * should be available on -- cgit 1.2.3-korg