From 77e469b27708d2fabe6281082716a8c086f8107d Mon Sep 17 00:00:00 2001 From: ToineSiebelink Date: Tue, 1 Oct 2024 18:40:39 +0100 Subject: Policy Executor: handle errors, part 2 (fighting between IntelliJ and Checkstyle best practices) - non-2xx responses are processed using web client exceptions - handle unknown host exception - upgraded spotbugs (checkstyle and related mvn plugin) - fixed some small spotbugs due to upgrade - added commented instructions in docker compose to enable debugging - added some environment variables for policy executor configuration - extract out Sleeper in stub service to achieve 100% coverage - added cause to Policy Executor exceptions where applicable - ignored (new) spotbug rule about catch NPE because of issue in 3pp - ignored (new) spotbug rule about \n in string due to multiline string block Issue-ID: CPS-2412 Change-Id: I6835a73320c436cbeea12cc7a06f15899eec7bf1 Signed-off-by: ToineSiebelink --- cps-service/src/main/java/org/onap/cps/utils/YangParserHelper.java | 2 ++ 1 file changed, 2 insertions(+) (limited to 'cps-service/src/main/java') diff --git a/cps-service/src/main/java/org/onap/cps/utils/YangParserHelper.java b/cps-service/src/main/java/org/onap/cps/utils/YangParserHelper.java index 597164598a..232ea74c8e 100644 --- a/cps-service/src/main/java/org/onap/cps/utils/YangParserHelper.java +++ b/cps-service/src/main/java/org/onap/cps/utils/YangParserHelper.java @@ -22,6 +22,7 @@ package org.onap.cps.utils; import com.google.gson.JsonSyntaxException; import com.google.gson.stream.JsonReader; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.IOException; import java.io.StringReader; import java.net.URISyntaxException; @@ -127,6 +128,7 @@ public class YangParserHelper { return dataContainerNodeBuilder.build(); } + @SuppressFBWarnings(value = "DCN_NULLPOINTER_EXCEPTION", justification = "Problem originates in 3PP code") private ContainerNode parseXmlData(final String xmlData, final SchemaContext schemaContext, final String parentNodeXpath) { -- cgit 1.2.3-korg