From 65816190e45f25a78b4c1498cb81c6d23d52e72e Mon Sep 17 00:00:00 2001 From: Hanif Kukkalli Date: Wed, 10 Mar 2021 10:57:22 +0100 Subject: Fix SonarQube Coverage for test cases NfProxy Test Coverage Issue-ID: CPS-89 Signed-off-by: Hanif Kukkalli Change-Id: I7314e3fb1557d2f47f03db9c4ac12b0bf86c63b2 --- .../cps/nfproxy/config/NfProxyConfigSpec.groovy | 32 +++++++ .../NfProxyRestExceptionHandlerSpec.groovy | 97 ++++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/config/NfProxyConfigSpec.groovy create mode 100644 cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/rest/exceptions/NfProxyRestExceptionHandlerSpec.groovy (limited to 'cps-nf-proxy-rest') diff --git a/cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/config/NfProxyConfigSpec.groovy b/cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/config/NfProxyConfigSpec.groovy new file mode 100644 index 000000000..da021218d --- /dev/null +++ b/cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/config/NfProxyConfigSpec.groovy @@ -0,0 +1,32 @@ +/* + * ============LICENSE_START======================================================= + * Copyright (C) 2021 highstreet technologies GmbH + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.cps.nfproxy.config + +import spock.lang.Specification +import springfox.documentation.spring.web.plugins.Docket + +class NfProxyConfigSpec extends Specification { + def objectUnderTest = new NfProxyConfig() + + def 'NfProxy configuration has a Docket API.'() { + expect: 'the NfProxy configuration has a Docket API' + objectUnderTest.api() instanceof Docket + } +} diff --git a/cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/rest/exceptions/NfProxyRestExceptionHandlerSpec.groovy b/cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/rest/exceptions/NfProxyRestExceptionHandlerSpec.groovy new file mode 100644 index 000000000..73b57c5f9 --- /dev/null +++ b/cps-nf-proxy-rest/src/test/groovy/org/onap/cps/nfproxy/rest/exceptions/NfProxyRestExceptionHandlerSpec.groovy @@ -0,0 +1,97 @@ +/* + * ============LICENSE_START======================================================= + * Copyright (C) 2021 highstreet technologies GmbH + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.cps.nfproxy.rest.exceptions + +import groovy.json.JsonSlurper +import org.onap.cps.nfproxy.api.NfProxyDataService +import org.onap.cps.spi.FetchDescendantsOption +import org.onap.cps.spi.exceptions.CpsException +import org.spockframework.spring.SpringBean +import org.springframework.beans.factory.annotation.Autowired +import org.springframework.beans.factory.annotation.Value +import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest +import org.springframework.test.web.servlet.MockMvc +import spock.lang.Shared +import spock.lang.Specification + +import static org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get + +@WebMvcTest +class NfProxyRestExceptionHandlerSpec extends Specification { + + @Autowired + MockMvc mvc + + @SpringBean + NfProxyDataService mockNfProxyDataService = Mock() + + @Value('${rest.api.xnf-base-path}') + def basePath + + def dataNodeBaseEndpoint + + @Shared + def errorMessage = 'some error message' + @Shared + def errorDetails = 'some error details' + + def cmHandle = 'some handle' + def xpath = 'some xpath' + + def setup() { + dataNodeBaseEndpoint = "$basePath/v1" + } + + def 'Get request with runtime exception returns HTTP Status Internal Server Error.'() { + when: 'runtime exception is thrown by the service' + setupTestException(new IllegalStateException(errorMessage)) + def response = performTestRequest() + then: 'an HTTP Internal Server Error response is returned with correct message and details' + assertTestResponse(response, INTERNAL_SERVER_ERROR, errorMessage, null) + } + + def 'Get request with generic CPS exception returns HTTP Status Internal Server Error.'() { + when: 'generic CPS exception is thrown by the service' + setupTestException(new CpsException(errorMessage, errorDetails)) + def response = performTestRequest() + then: 'an HTTP Internal Server Error response is returned with correct message and details' + assertTestResponse(response, INTERNAL_SERVER_ERROR, errorMessage, errorDetails) + } + + def setupTestException(exception) { + mockNfProxyDataService.getDataNode(cmHandle, xpath, FetchDescendantsOption.OMIT_DESCENDANTS) >> + { throw exception} + } + + def performTestRequest() { + return mvc.perform(get("$dataNodeBaseEndpoint/cm-handles/$cmHandle/node").param('xpath', xpath)) + .andReturn().response + } + + static void assertTestResponse(response, expectedStatus,expectedErrorMessage, + expectedErrorDetails) { + assert response.status == expectedStatus.value() + def content = new JsonSlurper().parseText(response.contentAsString) + assert content['status'] == expectedStatus.toString() + assert content['message'] == expectedErrorMessage + assert expectedErrorDetails == null || content['details'] == expectedErrorDetails + } +} -- cgit 1.2.3-korg