From 8f254ba0f91be28ffdba801d03a7493d94bdc0b8 Mon Sep 17 00:00:00 2001 From: ToineSiebelink Date: Tue, 21 Sep 2021 17:29:04 +0100 Subject: Address Sonar Qube issues - Add missing lombok.config to exclude lombok generated code in some modules - Increased Coverage treshold where possible Issue-ID: CPS-475 Signed-off-by: ToineSiebelink Change-Id: I4974aa1abec47980e15c2da10afc7288c2cc7c54 --- cps-ncmp-service/lombok.config | 20 ++++++++++++++++++++ cps-ncmp-service/pom.xml | 4 ---- .../ncmp/api/impl/NetworkCmProxyDataServiceImpl.java | 2 +- 3 files changed, 21 insertions(+), 5 deletions(-) create mode 100644 cps-ncmp-service/lombok.config (limited to 'cps-ncmp-service') diff --git a/cps-ncmp-service/lombok.config b/cps-ncmp-service/lombok.config new file mode 100644 index 000000000..0736fc58c --- /dev/null +++ b/cps-ncmp-service/lombok.config @@ -0,0 +1,20 @@ +# ============LICENSE_START======================================================= +# Copyright (C) 2021 Nordix Foundation +# ================================================================================ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# SPDX-License-Identifier: Apache-2.0 +# ============LICENSE_END========================================================= + +config.stopBubbling = true +lombok.addLombokGeneratedAnnotation = true diff --git a/cps-ncmp-service/pom.xml b/cps-ncmp-service/pom.xml index ac2593998..96aa4e5cc 100644 --- a/cps-ncmp-service/pom.xml +++ b/cps-ncmp-service/pom.xml @@ -32,10 +32,6 @@ cps-ncmp-service - - 0.90 - - ${project.groupId} diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java index dc5dc7733..08370ab89 100755 --- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java +++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java @@ -459,7 +459,7 @@ public class NetworkCmProxyDataServiceImpl implements NetworkCmProxyDataService private static ModuleReference toModuleReference(final JsonObject moduleReferenceAsJson) { final var moduleReference = new ModuleReference(); moduleReference.setModuleName(moduleReferenceAsJson.get("moduleName").getAsString()); - moduleReference.setRevision(moduleReferenceAsJson.get("revision").getAsString()); + moduleReference.setRevision(moduleReferenceAsJson.get(REVISION).getAsString()); return moduleReference; } } -- cgit 1.2.3-korg