From 8ef2400744c93c1c13f8ac1ae7eae1c0969989f8 Mon Sep 17 00:00:00 2001
From: danielhanrahan <daniel.hanrahan@est.tech>
Date: Fri, 24 Jan 2025 15:40:13 +0000
Subject: Less logging during registration

During investigation of CPS-2576 bug, stack traces were added to log
output (by logging the exception object). This produces massive log
output during registration, since all CM-handles fail to sync and go
to LOCKED state initially due to initial DMI delay.

This patch logs exception details at warning level but not stacktrace

Issue-ID: CPS-2576
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ibb55991e75c058e9f4983bd876285b48917ee28e
---
 .../ncmp/impl/inventory/sync/ModuleSyncService.java   | 19 ++++++-------------
 .../cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java |  2 +-
 2 files changed, 7 insertions(+), 14 deletions(-)

(limited to 'cps-ncmp-service/src/main/java')

diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncService.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncService.java
index 6c1dc731c6..017995e778 100644
--- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncService.java
+++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncService.java
@@ -36,7 +36,6 @@ import org.onap.cps.api.CpsAnchorService;
 import org.onap.cps.api.CpsDataService;
 import org.onap.cps.api.CpsModuleService;
 import org.onap.cps.api.exceptions.AlreadyDefinedException;
-import org.onap.cps.api.exceptions.DuplicatedYangResourceException;
 import org.onap.cps.api.model.ModuleReference;
 import org.onap.cps.ncmp.impl.inventory.models.YangModelCmHandle;
 import org.onap.cps.utils.ContentType;
@@ -73,8 +72,8 @@ public class ModuleSyncService {
         try {
             cpsAnchorService.createAnchor(NFP_OPERATIONAL_DATASTORE_DATASPACE_NAME, schemaSetName, cmHandleId);
         } catch (final AlreadyDefinedException alreadyDefinedException) {
-            log.warn("Ignoring (anchor) already exist exception for {}. Exception details: ",
-                yangModelCmHandle.getId(), alreadyDefinedException);
+            log.warn("Ignoring (Anchor) already exists exception for {}. Exception details: {}", cmHandleId,
+                    alreadyDefinedException.getDetails());
         }
     }
 
@@ -105,9 +104,10 @@ public class ModuleSyncService {
 
     private void syncAndCreateSchemaSet(final YangModelCmHandle yangModelCmHandle, final String schemaSetName) {
         if (isNewSchemaSet(schemaSetName)) {
+            final String cmHandleId = yangModelCmHandle.getId();
             final ModuleDelta moduleDelta = getModuleDelta(yangModelCmHandle);
             try {
-                log.info("Creating Schema Set {} for CM Handle {}", schemaSetName, yangModelCmHandle.getId());
+                log.info("Creating Schema Set {} for CM Handle {}", schemaSetName, cmHandleId);
                 cpsModuleService.createSchemaSetFromModules(
                     NFP_OPERATIONAL_DATASTORE_DATASPACE_NAME,
                     schemaSetName,
@@ -117,15 +117,8 @@ public class ModuleSyncService {
                 log.info("Successfully created Schema Set {} for CM Handle {}", schemaSetName,
                     yangModelCmHandle.getId());
             } catch (final AlreadyDefinedException alreadyDefinedException) {
-                log.warn("Ignoring already exist (schema set) exception for {}. Exception details: ",
-                     yangModelCmHandle.getId(), alreadyDefinedException);
-            } catch (final DuplicatedYangResourceException duplicatedYangResourceException) {
-                log.warn("Duplicate Yang Resource {} creation for {}. "
-                        + "CM Handle will be LOCKED (for retry). Exception details: ",
-                    duplicatedYangResourceException.getName(),
-                    yangModelCmHandle.getId(),
-                    duplicatedYangResourceException);
-                throw duplicatedYangResourceException;
+                log.warn("Ignoring (Schema Set) already exists exception for {}. Exception details: {}", cmHandleId,
+                        alreadyDefinedException.getDetails());
             }
         }
     }
diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java
index b63496753e..f039cf3c02 100644
--- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java
+++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java
@@ -114,7 +114,7 @@ public class ModuleSyncTasks {
             compositeState.setLockReason(null);
             return CmHandleState.READY;
         } catch (final Exception e) {
-            log.warn("Processing of {} failed,reason : ", yangModelCmHandle.getId(), e);
+            log.warn("Processing of {} failed, reason: {}.", yangModelCmHandle.getId(), e.getMessage());
             final LockReasonCategory lockReasonCategory = inUpgrade
                     ? LockReasonCategory.MODULE_UPGRADE_FAILED
                     : LockReasonCategory.MODULE_SYNC_FAILED;
-- 
cgit