From 8060d1b698fed834a6ebf423c2d84bbc94b041e2 Mon Sep 17 00:00:00 2001
From: seanbeirne <sean.beirne@est.tech>
Date: Wed, 4 Dec 2024 16:23:11 +0000
Subject: Increase Test coverage for cps-ncmp-service

Issue-ID: CPS-475
Change-Id: I35f127540e0fe5d412a9f855b647fef30f47159f
Signed-off-by: seanbeirne <sean.beirne@est.tech>
---
 .../cmnotificationsubscription/ncmp/CmSubscriptionComparator.java | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

(limited to 'cps-ncmp-service/src/main/java/org/onap')

diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/cmnotificationsubscription/ncmp/CmSubscriptionComparator.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/cmnotificationsubscription/ncmp/CmSubscriptionComparator.java
index d7f15a2c72..99c5695850 100644
--- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/cmnotificationsubscription/ncmp/CmSubscriptionComparator.java
+++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/cmnotificationsubscription/ncmp/CmSubscriptionComparator.java
@@ -46,24 +46,20 @@ public class CmSubscriptionComparator {
             final List<DmiCmSubscriptionPredicate> existingDmiCmSubscriptionPredicates) {
         final List<DmiCmSubscriptionPredicate> newDmiCmSubscriptionPredicates =
                 new ArrayList<>();
-
         for (final DmiCmSubscriptionPredicate dmiCmSubscriptionPredicate : existingDmiCmSubscriptionPredicates) {
-
             final Set<String> targetCmHandleIds = new HashSet<>();
             final Set<String> xpaths = new HashSet<>();
             final DatastoreType datastoreType = dmiCmSubscriptionPredicate.getDatastoreType();
-
             for (final String cmHandleId : dmiCmSubscriptionPredicate.getTargetCmHandleIds()) {
                 for (final String xpath : dmiCmSubscriptionPredicate.getXpaths()) {
                     if (!cmSubscriptionPersistenceService.isOngoingCmSubscription(datastoreType,
                             cmHandleId, xpath)) {
-                        xpaths.add(xpath);
                         targetCmHandleIds.add(cmHandleId);
+                        xpaths.add(xpath);
 
                     }
                 }
             }
-
             populateValidDmiSubscriptionPredicates(targetCmHandleIds, xpaths, datastoreType,
                     newDmiCmSubscriptionPredicates);
         }
@@ -73,7 +69,7 @@ public class CmSubscriptionComparator {
     private void populateValidDmiSubscriptionPredicates(final Set<String> targetCmHandleIds,
             final Set<String> xpaths, final DatastoreType datastoreType,
             final List<DmiCmSubscriptionPredicate> dmiCmSubscriptionPredicates) {
-        if (!(targetCmHandleIds.isEmpty() || xpaths.isEmpty())) {
+        if (!targetCmHandleIds.isEmpty()) {
             final DmiCmSubscriptionPredicate dmiCmSubscriptionPredicate =
                     new DmiCmSubscriptionPredicate(targetCmHandleIds, datastoreType, xpaths);
             dmiCmSubscriptionPredicates.add(dmiCmSubscriptionPredicate);
-- 
cgit