From 2bdd4f82bb6d2d7928044228bf0893cf6aa5921d Mon Sep 17 00:00:00 2001
From: "priyanka.akhade" <priyanka.akhade@huawei.com>
Date: Tue, 4 Aug 2020 19:07:52 +0530
Subject: Code improvement - Pending sonar issues

Signed-off-by: priyanka.akhade <priyanka.akhade@huawei.com>
Issue-ID: CLI-270
Change-Id: I11bff3e6fa5f3299ee3ad0f7bf5d3e42ee7a704c
---
 validate/validation/pom.xml                            | 18 ------------------
 .../org/onap/cli/validation/OnapValidationTest.java    |  3 +++
 2 files changed, 3 insertions(+), 18 deletions(-)

(limited to 'validate')

diff --git a/validate/validation/pom.xml b/validate/validation/pom.xml
index c2701d68..5d7cd430 100644
--- a/validate/validation/pom.xml
+++ b/validate/validation/pom.xml
@@ -128,24 +128,6 @@
             <version>2.6</version>
         </dependency>
   </dependencies>
-<!--   <build>
-        <plugins>
-            <plugin>
-                 <groupId>org.apache.maven.plugins</groupId>
-                 <artifactId>maven-surefire-plugin</artifactId>
-                 <version>2.9</version>
-                  <configuration>
-                     <useManifestOnlyJar>false</useManifestOnlyJar>
-                    <useSystemClassLoader>false</useSystemClassLoader>
-                     <additionalClasspathElements>
-                        <additionalClasspathElement>
-                                ${project.build.directory}/../../deployment/zip/target/deployunzip/lib/*.jar
-                           </additionalClasspathElement>
-                    </additionalClasspathElements>
-                </configuration>
-           </plugin>
-        </plugins>
-    </build> -->
     <build><plugins>
         <!--Step-2:- SonarCloud migration from SonarQube -->
         <plugin>
diff --git a/validate/validation/src/test/java/org/onap/cli/validation/OnapValidationTest.java b/validate/validation/src/test/java/org/onap/cli/validation/OnapValidationTest.java
index d24fe1e7..ca01dd0a 100644
--- a/validate/validation/src/test/java/org/onap/cli/validation/OnapValidationTest.java
+++ b/validate/validation/src/test/java/org/onap/cli/validation/OnapValidationTest.java
@@ -52,6 +52,7 @@ import org.onap.cli.fw.utils.OnapCommandDiscoveryUtils;
 
 import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
+import static org.junit.Assert.assertFalse;
 
 public class OnapValidationTest {
 
@@ -121,6 +122,7 @@ public class OnapValidationTest {
                 }
             }
         }
+        assertFalse(OnapCommandRegistrar.getRegistrar().getAvailableProductVersions().isEmpty());
     }
 
     @Test
@@ -144,6 +146,7 @@ public class OnapValidationTest {
                 }
             }
         }
+        assertFalse(OnapCommandRegistrar.getRegistrar().getAvailableProductVersions().isEmpty());
     }
 
     @Test
-- 
cgit 1.2.3-korg